Re: [Libguestfs] [PATCH libnbd 3/3] copy: Do not initialize read buffer

2022-03-10 Thread Nir Soffer
On Thu, Mar 10, 2022 at 5:58 PM Eric Blake wrote: > > On Sun, Mar 06, 2022 at 10:27:30PM +0200, Nir Soffer wrote: > > nbdcopy checks pread error now, so we will never leak uninitialized data > > from the heap to the destination server. Testing show 3-8% speedup when > > copying a real image. > > >

Re: [Libguestfs] [PATCH libnbd 3/3] copy: Do not initialize read buffer

2022-03-10 Thread Eric Blake
On Sun, Mar 06, 2022 at 10:27:30PM +0200, Nir Soffer wrote: > nbdcopy checks pread error now, so we will never leak uninitialized data > from the heap to the destination server. Testing show 3-8% speedup when > copying a real image. > > +++ b/copy/nbd-ops.c > @@ -52,20 +52,21 @@ static void > op

Re: [Libguestfs] [PATCH libnbd 3/3] copy: Do not initialize read buffer

2022-03-06 Thread Richard W.M. Jones
On Sun, Mar 06, 2022 at 10:27:30PM +0200, Nir Soffer wrote: > nbdcopy checks pread error now, so we will never leak uninitialized data > from the heap to the destination server. Testing show 3-8% speedup when > copying a real image. > > On laptop with 12 cores and 2 consumer NVMe drives: > > $ qe

[Libguestfs] [PATCH libnbd 3/3] copy: Do not initialize read buffer

2022-03-06 Thread Nir Soffer
nbdcopy checks pread error now, so we will never leak uninitialized data from the heap to the destination server. Testing show 3-8% speedup when copying a real image. On laptop with 12 cores and 2 consumer NVMe drives: $ qemu-nbd --read-only --persistent --shared 8 --cache none --aio native \