Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

2022-02-21 Thread Nir Soffer
On Mon, Feb 21, 2022 at 12:17 PM Richard W.M. Jones wrote: > > On Mon, Feb 21, 2022 at 08:28:54AM +0200, Nir Soffer wrote: > > On Sun, Feb 20, 2022 at 8:53 PM Richard W.M. Jones > > wrote: > > > > > > On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffer wrote: > > > > +static inline void > > >

Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

2022-02-21 Thread Richard W.M. Jones
On Mon, Feb 21, 2022 at 08:28:54AM +0200, Nir Soffer wrote: > On Sun, Feb 20, 2022 at 8:53 PM Richard W.M. Jones wrote: > > > > On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffer wrote: > > > +static inline void > > > +increase_queue_size(struct worker *worker, size_t len) > > > >

Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

2022-02-20 Thread Nir Soffer
On Sun, Feb 20, 2022 at 8:53 PM Richard W.M. Jones wrote: > > On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffer wrote: > > +static inline void > > +increase_queue_size(struct worker *worker, size_t len) > > ^ space > > and the same in the next function: Sure will fix

Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

2022-02-20 Thread Richard W.M. Jones
On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffer wrote: > +static inline void > +increase_queue_size(struct worker *worker, size_t len) ^ space and the same in the next function: > +{ > + worker->queue_size += len; > +} > + > +static inline void >

[Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

2022-02-20 Thread Nir Soffer
Tracking the number of queued bytes per worker will allow optimizing the number of in flight requests based on the actual requests size. The goal is to allow large number of small requests, required to get good performance, and in the same time limit the number of large requests, that can be