Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-15 Thread Nir Soffer
On Tue, Feb 15, 2022 at 12:18 AM Nir Soffer wrote: > On Mon, Feb 14, 2022 at 3:22 PM Eric Blake wrote: > >> On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: >> > Add unit tests and benchmarks for AioBuffer. The tests are trivial but >> > they server as running documentation, and they

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-14 Thread Nir Soffer
On Mon, Feb 14, 2022 at 3:22 PM Eric Blake wrote: > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > they server as running documentation, and they point out important > > serve > Fixed > > > details abou

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-14 Thread Eric Blake
On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > they server as running documentation, and they point out important serve > details about the type. > > The benchmarks show the efficiency of allocating a new buf

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-12 Thread Richard W.M. Jones
On Sat, Feb 12, 2022 at 01:05:29AM +0200, Nir Soffer wrote: > On Fri, Feb 11, 2022 at 9:08 PM Nir Soffer wrote: > > > > On Fri, Feb 11, 2022 at 1:22 PM Richard W.M. Jones > > wrote: > > > > > > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > > > Add unit tests and benchmarks for

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-11 Thread Nir Soffer
On Fri, Feb 11, 2022 at 9:08 PM Nir Soffer wrote: > > On Fri, Feb 11, 2022 at 1:22 PM Richard W.M. Jones wrote: > > > > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > > they server as running documentati

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-11 Thread Nir Soffer
On Fri, Feb 11, 2022 at 1:22 PM Richard W.M. Jones wrote: > > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > they server as running documentation, and they point out important > > details about the type. >

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-11 Thread Richard W.M. Jones
On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > they server as running documentation, and they point out important > details about the type. > > The benchmarks show the efficiency of allocating a new buffer, zer

[Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-10 Thread Nir Soffer
Add unit tests and benchmarks for AioBuffer. The tests are trivial but they server as running documentation, and they point out important details about the type. The benchmarks show the efficiency of allocating a new buffer, zeroing it, and interfacing with Go code. These tests will also ensure t