Re: [Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-29 Thread Richard W.M. Jones
On Thu, Sep 29, 2022 at 09:08:26AM -0500, Eric Blake wrote: > On Thu, Sep 29, 2022 at 02:42:05PM +0100, Richard W.M. Jones wrote: > > > > + (* Output __attribute__((nonnull)) for the function parameters: > > > > + * eg. struct nbd_handle *, int, char * > > > > + * => [ true, false, true ]

Re: [Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-29 Thread Eric Blake
On Thu, Sep 29, 2022 at 02:42:05PM +0100, Richard W.M. Jones wrote: > > > + (* Output __attribute__((nonnull)) for the function parameters: > > > + * eg. struct nbd_handle *, int, char * > > > + * => [ true, false, true ] > > > + * => LIBNBD_ATTRIBUTE_NONNULL((1,3)) > > > + *

Re: [Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-29 Thread Richard W.M. Jones
On Thu, Sep 29, 2022 at 08:25:29AM -0500, Eric Blake wrote: > On Wed, Sep 28, 2022 at 06:25:35PM +0100, Richard W.M. Jones wrote: > > For API parameters that are pointers and must not be NULL, add the > > appropriate GCC annotations. > > > > Reviewed-by: Laszlo Ersek > > --- > > generator/C.ml

Re: [Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-29 Thread Eric Blake
On Wed, Sep 28, 2022 at 06:25:35PM +0100, Richard W.M. Jones wrote: > For API parameters that are pointers and must not be NULL, add the > appropriate GCC annotations. > > Reviewed-by: Laszlo Ersek > --- > generator/C.ml | 59 +++-- >

Re: [Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-29 Thread Laszlo Ersek
On 09/28/22 23:53, Eric Blake wrote: > On Wed, Sep 28, 2022 at 06:25:35PM +0100, Richard W.M. Jones wrote: >> For API parameters that are pointers and must not be NULL, add the >> appropriate GCC annotations. >> >> Reviewed-by: Laszlo Ersek >> --- >> generator/C.ml | 59

Re: [Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-28 Thread Eric Blake
On Wed, Sep 28, 2022 at 06:25:35PM +0100, Richard W.M. Jones wrote: > For API parameters that are pointers and must not be NULL, add the > appropriate GCC annotations. > > Reviewed-by: Laszlo Ersek > --- > generator/C.ml | 59 +++-- >

[Libguestfs] [PATCH libnbd v3 2/6] generator: Add attribute((nonnull)) annotations to non-NULL parameters

2022-09-28 Thread Richard W.M. Jones
For API parameters that are pointers and must not be NULL, add the appropriate GCC annotations. Reviewed-by: Laszlo Ersek --- generator/C.ml | 59 +++-- tests/errors-connect-null.c | 4 +++ 2 files changed, 61 insertions(+), 2 deletions(-) diff