Re: [Libguestfs] [PATCH libnbd v3 4/6] generator: Check that more parameters are not NULL

2022-09-29 Thread Laszlo Ersek
On 09/29/22 00:14, Eric Blake wrote: > On Wed, Sep 28, 2022 at 06:25:37PM +0100, Richard W.M. Jones wrote: >> We previously checked only that String parameters are not NULL, >> returning an error + EFAULT if so. >> >> However we did not check Bytes*, SockAddrAndLen, Path or StringList >>

Re: [Libguestfs] [PATCH libnbd v3 4/6] generator: Check that more parameters are not NULL

2022-09-28 Thread Eric Blake
On Wed, Sep 28, 2022 at 06:25:37PM +0100, Richard W.M. Jones wrote: > We previously checked only that String parameters are not NULL, > returning an error + EFAULT if so. > > However we did not check Bytes*, SockAddrAndLen, Path or StringList > parameters, also never NULL. Be consistent about

[Libguestfs] [PATCH libnbd v3 4/6] generator: Check that more parameters are not NULL

2022-09-28 Thread Richard W.M. Jones
We previously checked only that String parameters are not NULL, returning an error + EFAULT if so. However we did not check Bytes*, SockAddrAndLen, Path or StringList parameters, also never NULL. Be consistent about checks. Thanks: Eric Blake for help and an earlier version of the patch ---