Re: [Libguestfs] [PATCH nbdkit] rust: Drop box ptr

On Thu, Sep 29, 2022 at 09:56:34AM -0600, alan somers wrote: > This change is correct. You can consider it reviewed by me and commit > it. As for the warning from Mockall, that's a bug in Mockall. I'll > fix it. Thanks Alan - the drop() addition pushed as 6836e4c36. Rich. > On Thu, Sep 29,

Re: [Libguestfs] [PATCH nbdkit] rust: Drop box ptr

Here's the bug https://github.com/asomers/mockall/issues/414 On Thu, Sep 29, 2022 at 9:56 AM alan somers wrote: > > This change is correct. You can consider it reviewed by me and commit > it. As for the warning from Mockall, that's a bug in Mockall. I'll > fix it. > > On Thu, Sep 29, 2022 at

Re: [Libguestfs] [PATCH nbdkit] rust: Drop box ptr

This change is correct. You can consider it reviewed by me and commit it. As for the warning from Mockall, that's a bug in Mockall. I'll fix it. On Thu, Sep 29, 2022 at 8:21 AM Richard W.M. Jones wrote: > > Because of this recent change to rust, our close function warned that > we calculate

[Libguestfs] [PATCH nbdkit] rust: Drop box ptr

Because of this recent change to rust, our close function warned that we calculate Box::from_raw but never use it. I added the suggested call to drop() around the function. https://github.com/rust-lang/rust/pull/99270 --- plugins/rust/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1

[Libguestfs] [PATCH nbdkit] rust: Drop box ptr

This isn't a complete fix. There's still this error when running the tests. I don't understand which expect function it's complaining about. One generated by the MockServer? -- warning: the cargo feature `resolver` has been