Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Nikolaus Rath
On May 17 2022, Laszlo Ersek wrote: > I think so, yes: from your description, "test-S3-unit.sh" seems "less > demanding" than "test-S3.sh", so if the mocked module satisfies the > latter, it should be good enough for the former too. Not quite. test-S3-unit.sh exercises the write path and the

Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Richard W.M. Jones
On Tue, May 17, 2022 at 12:50:53PM +0200, Laszlo Ersek wrote: > On 05/17/22 12:11, Richard W.M. Jones wrote: > > > > OK I see what's going on. > > > > test-S3.sh uses the mocked boto3 in tests/test-S3/ to do an end-to-end > > test (nbdcopy). > > > > test-S3-unit.sh runs the unit tests within

Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Laszlo Ersek
On 05/17/22 12:11, Richard W.M. Jones wrote: > > OK I see what's going on. > > test-S3.sh uses the mocked boto3 in tests/test-S3/ to do an end-to-end > test (nbdcopy). > > test-S3-unit.sh runs the unit tests within the plugin. It's basically > testing the plugin as if it was a standalone

Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Richard W.M. Jones
OK I see what's going on. test-S3.sh uses the mocked boto3 in tests/test-S3/ to do an end-to-end test (nbdcopy). test-S3-unit.sh runs the unit tests within the plugin. It's basically testing the plugin as if it was a standalone Python script (without nbdkit being involved). This uses an

Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Richard W.M. Jones
On Tue, May 17, 2022 at 11:53:44AM +0200, Laszlo Ersek wrote: > On 05/17/22 10:55, Richard W.M. Jones wrote: > > ERROR: S3 (unittest.loader._FailedTest) > > -- > > ImportError: Failed to import test module: S3 > > Traceback (most

Re: [Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Laszlo Ersek
On 05/17/22 10:55, Richard W.M. Jones wrote: > ERROR: S3 (unittest.loader._FailedTest) > -- > ImportError: Failed to import test module: S3 > Traceback (most recent call last): > File "/usr/lib64/python3.10/unittest/loader.py",

[Libguestfs] [PATCH nbdkit] s3: Only run the tests if boto3 is installed

2022-05-17 Thread Richard W.M. Jones
ERROR: S3 (unittest.loader._FailedTest) -- ImportError: Failed to import test module: S3 Traceback (most recent call last): File "/usr/lib64/python3.10/unittest/loader.py", line 154, in loadTestsFromName module =