Re: [Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.

2017-09-13 Thread Pino Toscano
On Tuesday, 12 September 2017 19:58:44 CEST Richard W.M. Jones wrote: > On Tue, Sep 12, 2017 at 06:42:11PM +0200, Pino Toscano wrote: > > On Wednesday, 9 August 2017 19:23:39 CEST Richard W.M. Jones wrote: > > > hivex has a function hivex_value_string. We were not calling it under > > > the

Re: [Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.

2017-09-12 Thread Richard W.M. Jones
On Tue, Sep 12, 2017 at 06:42:11PM +0200, Pino Toscano wrote: > On Wednesday, 9 August 2017 19:23:39 CEST Richard W.M. Jones wrote: > > hivex has a function hivex_value_string. We were not calling it under > > the mistaken belief that because hivex implements this using iconv, > > the function

Re: [Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.

2017-09-12 Thread Pino Toscano
On Wednesday, 9 August 2017 19:23:39 CEST Richard W.M. Jones wrote: > hivex has a function hivex_value_string. We were not calling it under > the mistaken belief that because hivex implements this using iconv, > the function wouldn't work inside the daemon. Instead we > reimplemented the

[Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.

2017-08-09 Thread Richard W.M. Jones
hivex has a function hivex_value_string. We were not calling it under the mistaken belief that because hivex implements this using iconv, the function wouldn't work inside the daemon. Instead we reimplemented the functionality in the library. This commit deprecates hivex_value_utf8 and removes