Re: [Libguestfs] [PATCH v2] lib: Convert all drive socket parameters to an absolute path (RHBZ#1588451).

2018-06-21 Thread Pino Toscano
On Friday, 15 June 2018 15:50:49 CEST Richard W.M. Jones wrote: > Also fix two tests which assumed that you could add a non-existent > socket. > --- This approach LGTM, although maybe a simpler one can be to resolve the path when starting the appliance. This patch breaks the case when an user

[Libguestfs] [PATCH v2] lib: Convert all drive socket parameters to an absolute path (RHBZ#1588451).

2018-06-15 Thread Richard W.M. Jones
Also fix two tests which assumed that you could add a non-existent socket. --- fish/test-add-uri.sh | 16 lib/drives.c | 14 +- tests/disks/test-qemu-drive.sh | 19 ++- 3 files changed, 39 insertions(+), 10 deletions(-)