On Thu, Oct 04, 2018 at 04:52:28PM +0200, Pino Toscano wrote:
> On Thursday, 4 October 2018 14:50:07 CEST Richard W.M. Jones wrote:
> > On Thu, Oct 04, 2018 at 01:34:59PM +0100, Richard W.M. Jones wrote:
> > > On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote:
> > > > On Friday, 21 Septe
On Thursday, 4 October 2018 14:50:07 CEST Richard W.M. Jones wrote:
> On Thu, Oct 04, 2018 at 01:34:59PM +0100, Richard W.M. Jones wrote:
> > On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote:
> > > On Friday, 21 September 2018 11:53:52 CEST Richard W.M. Jones wrote:
> > > > +/**
> > > >
On Thu, Oct 04, 2018 at 01:34:59PM +0100, Richard W.M. Jones wrote:
> On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote:
> > On Friday, 21 September 2018 11:53:52 CEST Richard W.M. Jones wrote:
> > > +/**
> > > + * Test if the qemu-img info command supports the C<-U> option to
> > > + *
On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote:
> On Friday, 21 September 2018 11:53:52 CEST Richard W.M. Jones wrote:
> > +/**
> > + * Test if the qemu-img info command supports the C<-U> option to
> > + * disable locking. The result is memoized in the handle.
> > + *
> > + * Note t
+1 LGTM.
Thanks Richard.
On Fri, Sep 21, 2018 at 12:53 PM Richard W.M. Jones
wrote:
> https://bugs.launchpad.net/qemu/+bug/1740364
> ---
> lib/guestfs-internal.h | 3 +++
> lib/handle.c | 2 ++
> lib/info.c | 39 +++
> 3 files changed,
This patch needs a bit more work as Pino outlined in his reply.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bind
On Friday, 21 September 2018 11:53:52 CEST Richard W.M. Jones wrote:
> +/**
> + * Test if the qemu-img info command supports the C<-U> option to
> + * disable locking. The result is memoized in the handle.
> + *
> + * Note this option was added in qemu 2.11. We can remove this test
> + * when we
https://bugs.launchpad.net/qemu/+bug/1740364
---
lib/guestfs-internal.h | 3 +++
lib/handle.c | 2 ++
lib/info.c | 39 +++
3 files changed, 44 insertions(+)
diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h
index adeb9478a..c6