Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-15 Thread Richard W.M. Jones
On Tue, Feb 15, 2022 at 12:14:11PM +0100, Laszlo Ersek wrote: > On 02/15/22 11:43, Richard W.M. Jones wrote: > > On Mon, Feb 14, 2022 at 04:08:21PM +, Richard W.M. Jones wrote: > >> On Mon, Feb 14, 2022 at 04:52:17PM +0100, Laszlo Ersek wrote: > >>> On 02/14/22 14:01, Richard W.M. Jones wrote:

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-15 Thread Laszlo Ersek
On 02/15/22 11:43, Richard W.M. Jones wrote: > On Mon, Feb 14, 2022 at 04:08:21PM +, Richard W.M. Jones wrote: >> On Mon, Feb 14, 2022 at 04:52:17PM +0100, Laszlo Ersek wrote: >>> On 02/14/22 14:01, Richard W.M. Jones wrote: But nbdcopy needs to be reworked to make the input and output

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-15 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 04:08:21PM +, Richard W.M. Jones wrote: > On Mon, Feb 14, 2022 at 04:52:17PM +0100, Laszlo Ersek wrote: > > On 02/14/22 14:01, Richard W.M. Jones wrote: > > > But nbdcopy needs to be reworked to make the input and output requests > > > separate, so that nbdcopy will

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 04:08:21PM +, Richard W.M. Jones wrote: > There is a limit on the number of parallel requests in flight > (nbdcopy --requests, default 64). This limits the implicit buffer to > max_requests * request_size. That's 16MB in the default > configuration. Quite small

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 04:52:17PM +0100, Laszlo Ersek wrote: > On 02/14/22 14:01, Richard W.M. Jones wrote: > > But nbdcopy needs to be reworked to make the input and output requests > > separate, so that nbdcopy will coalesce and split blocks as it copies. > > This is difficult. > > > > Another

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Laszlo Ersek
On 02/14/22 14:01, Richard W.M. Jones wrote: > On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: >> On 02/14/22 10:56, Richard W.M. Jones wrote: >>> This change slowed things down (slightly) for me, although the change >>> is within the margin of error so it probably made no

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 03:59:34PM +0200, Nir Soffer wrote: > On Mon, Feb 14, 2022 at 3:01 PM Richard W.M. Jones wrote: > > > > On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: > > > On 02/14/22 10:56, Richard W.M. Jones wrote: > > > > This change slowed things down (slightly) for

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Nir Soffer
On Mon, Feb 14, 2022 at 3:01 PM Richard W.M. Jones wrote: > > On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: > > On 02/14/22 10:56, Richard W.M. Jones wrote: > > > This change slowed things down (slightly) for me, although the change > > > is within the margin of error so it

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: > On 02/14/22 10:56, Richard W.M. Jones wrote: > > This change slowed things down (slightly) for me, although the change > > is within the margin of error so it probably made no difference. > > > > Before: > > > > $ time ./run

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 01:11:52PM +0200, Nir Soffer wrote: > On Mon, Feb 14, 2022 at 11:56 AM Richard W.M. Jones wrote: > > > > This change slowed things down (slightly) for me, although the change > > is within the margin of error so it probably made no difference. > > > > Before: > ... > > [

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Laszlo Ersek
On 02/14/22 10:56, Richard W.M. Jones wrote: > This change slowed things down (slightly) for me, although the change > is within the margin of error so it probably made no difference. > > Before: > > $ time ./run virt-v2v -i disk /var/tmp/fedora-35.qcow2 -o rhv-upload -oc >

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Laszlo Ersek
On 02/13/22 20:56, Nir Soffer wrote: > Output modules can specify now request_size to override the default > request size in nbdcopy. > > The rhv-upload plugin is translating every NBD command to HTTP request, > translated back to NBD command on imageio server. The HTTP client and > server, and

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Nir Soffer
On Mon, Feb 14, 2022 at 11:56 AM Richard W.M. Jones wrote: > > This change slowed things down (slightly) for me, although the change > is within the margin of error so it probably made no difference. > > Before: ... > [ 79.3] Copying disk 1/1 > █ 100% [] >

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
This change slowed things down (slightly) for me, although the change is within the margin of error so it probably made no difference. Before: $ time ./run virt-v2v -i disk /var/tmp/fedora-35.qcow2 -o rhv-upload -oc https://ovirt4410/ovirt-engine/api -op /tmp/ovirt-passwd -oo rhv-direct -os

[Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-13 Thread Nir Soffer
Output modules can specify now request_size to override the default request size in nbdcopy. The rhv-upload plugin is translating every NBD command to HTTP request, translated back to NBD command on imageio server. The HTTP client and server, and the NBD client on the imageio server side are