Re: [Libguestfs] [PATCH v2 4/5] appliance: Added filesystem_walk command

2016-04-04 Thread Pino Toscano
On Monday 04 April 2016 15:00:26 NoxDaFox wrote: > 2016-04-04 13:09 GMT+03:00 Pino Toscano : > > > Hi, > > > > some of the comments for patch #3 apply also for this one, namely: > > - wrapping of commit message > > - indentation of forward declarations > > - usage of XDR

Re: [Libguestfs] [PATCH v2 4/5] appliance: Added filesystem_walk command

2016-04-04 Thread NoxDaFox
2016-04-04 13:09 GMT+03:00 Pino Toscano : > Hi, > > some of the comments for patch #3 apply also for this one, namely: > - wrapping of commit message > - indentation of forward declarations > - usage of XDR deserialization from guestfs_protocol.h > - > > On Sunday 03 April

Re: [Libguestfs] [PATCH v2 4/5] appliance: Added filesystem_walk command

2016-04-04 Thread Pino Toscano
Hi, some of the comments for patch #3 apply also for this one, namely: - wrapping of commit message - indentation of forward declarations - usage of XDR deserialization from guestfs_protocol.h - On Sunday 03 April 2016 16:30:49 Matteo Cafasso wrote: > The filesystem_walk command is the

[Libguestfs] [PATCH v2 4/5] appliance: Added filesystem_walk command

2016-04-03 Thread Matteo Cafasso
The filesystem_walk command is the appliance's counterpart of the daemon's internal_filesystem_walk command. It writes the daemon's command output on a temporary file and parses it, deserialising the XDR formatted tsk_dirent structs. It returns to the caller the list of tsk_dirent structs