Re: [Libguestfs] [PATCH v7 1/7] daemon: expose file upload logic

2017-04-24 Thread NoxDaFox
2017-04-24 11:58 GMT+03:00 Richard W.M. Jones : > On Sun, Apr 23, 2017 at 07:49:56PM +0300, Matteo Cafasso wrote: > > + if (r == -1) { /* write error */ > > +err = errno; > > +r = cancel_receive (); > > You need to use ignore_value here, and it needs to be in a separate > comm

Re: [Libguestfs] [PATCH v7 1/7] daemon: expose file upload logic

2017-04-24 Thread Richard W.M. Jones
On Sun, Apr 23, 2017 at 07:49:56PM +0300, Matteo Cafasso wrote: > + if (r == -1) { /* write error */ > +err = errno; > +r = cancel_receive (); You need to use ignore_value here, and it needs to be in a separate commit, as discussed previously. Rich. -- Richard Jones, Virtua

Re: [Libguestfs] [PATCH v7 1/7] daemon: expose file upload logic

2017-04-24 Thread Richard W.M. Jones
This fails to compile for me: upload.c: In function 'upload': upload.c:93:7: error: variable 'r' set but not used [-Werror=unused-but-set-variable] int r, err, is_dev, fd; ^ Please make sure you are using ‘./configure --enable-werror’. Rich. -- Richard Jones, Virtualization Group, R

[Libguestfs] [PATCH v7 1/7] daemon: expose file upload logic

2017-04-23 Thread Matteo Cafasso
Allows other modules to use the same logic for uploading files. Signed-off-by: Matteo Cafasso --- daemon/daemon.h | 3 +++ daemon/upload.c | 66 - 2 files changed, 40 insertions(+), 29 deletions(-) diff --git a/daemon/daemon.h b/daemon/da