Re: [Libguestfs] [libnbd PATCH 1/2] api: Add LIBNBD_STRICT_PAYLOAD to honor qemu 32M write limit

2022-11-15 Thread Richard W.M. Jones
On Wed, Nov 09, 2022 at 05:26:06PM -0600, Eric Blake wrote: > Modern qemu tends to advertise a strict 32M payload limit. Yet we > default to allowing the user to attempt up to 64M in pwrite. For > pread, qemu will reply with EINVAL but keep the connection up; but for > pwrite, an overlarge

Re: [Libguestfs] [libnbd PATCH 1/2] api: Add LIBNBD_STRICT_PAYLOAD to honor qemu 32M write limit

2022-11-11 Thread Eric Blake
On Fri, Nov 11, 2022 at 08:52:31AM +0100, Laszlo Ersek wrote: > On 11/10/22 00:26, Eric Blake wrote: > > Modern qemu tends to advertise a strict 32M payload limit. Yet we > > default to allowing the user to attempt up to 64M in pwrite. For > > pread, qemu will reply with EINVAL but keep the

Re: [Libguestfs] [libnbd PATCH 1/2] api: Add LIBNBD_STRICT_PAYLOAD to honor qemu 32M write limit

2022-11-10 Thread Laszlo Ersek
On 11/10/22 00:26, Eric Blake wrote: > Modern qemu tends to advertise a strict 32M payload limit. Yet we > default to allowing the user to attempt up to 64M in pwrite. For > pread, qemu will reply with EINVAL but keep the connection up; but for > pwrite, an overlarge buffer is fatal. It's time

[Libguestfs] [libnbd PATCH 1/2] api: Add LIBNBD_STRICT_PAYLOAD to honor qemu 32M write limit

2022-11-09 Thread Eric Blake
Modern qemu tends to advertise a strict 32M payload limit. Yet we default to allowing the user to attempt up to 64M in pwrite. For pread, qemu will reply with EINVAL but keep the connection up; but for pwrite, an overlarge buffer is fatal. It's time to teach libnbd to honor qemu's max buffer by