Re: [Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-06-12 Thread Eric Blake
On Thu, Jun 01, 2023 at 08:00:55AM -0500, Eric Blake wrote: > > > @@ -83,13 +96,18 @@ REPLY.STRUCTURED_REPLY.CHECK: > > > * not worth keeping the connection alive. > > > */ > > >if (length > MAX_REQUEST_SIZE + sizeof > > > h->sbuf.reply.payload.offset_data) { > > > -set_error (0,

Re: [Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-06-08 Thread Laszlo Ersek
On 6/7/23 16:55, Richard W.M. Jones wrote: > On Thu, Jun 01, 2023 at 11:04:05AM +0200, Laszlo Ersek wrote: >> On 5/25/23 15:00, Eric Blake wrote: >>> @@ -69,11 +75,18 @@ REPLY.STRUCTURED_REPLY.RECV_REMAINING: >>> REPLY.STRUCTURED_REPLY.CHECK: >>>struct command *cmd = h->reply_cmd; >>>uin

Re: [Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-06-07 Thread Richard W.M. Jones
On Thu, Jun 01, 2023 at 11:04:05AM +0200, Laszlo Ersek wrote: > On 5/25/23 15:00, Eric Blake wrote: > > @@ -69,11 +75,18 @@ REPLY.STRUCTURED_REPLY.RECV_REMAINING: > > REPLY.STRUCTURED_REPLY.CHECK: > >struct command *cmd = h->reply_cmd; > >uint16_t flags, type; > > - uint32_t length; > >

Re: [Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-06-01 Thread Laszlo Ersek
On 6/1/23 15:00, Eric Blake wrote: > On Thu, Jun 01, 2023 at 11:04:05AM +0200, Laszlo Ersek wrote: >> Probably best to reorder the files in this patch for review: > > I see what you mean: because of the state hierarchy, it is probably > worth tweaking the git orderfile to favor files nearer the t

Re: [Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-06-01 Thread Eric Blake
On Thu, Jun 01, 2023 at 11:04:05AM +0200, Laszlo Ersek wrote: > On 5/25/23 15:00, Eric Blake wrote: > > Support receiving headers for 64-bit replies if extended headers were > > negotiated. We already insist that the server not send us too much > > payload in one reply, so we can exploit that and

Re: [Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-06-01 Thread Laszlo Ersek
On 5/25/23 15:00, Eric Blake wrote: > Support receiving headers for 64-bit replies if extended headers were > negotiated. We already insist that the server not send us too much > payload in one reply, so we can exploit that and merge the 64-bit > length back into a normalized 32-bit field for the

[Libguestfs] [libnbd PATCH v3 05/22] states: Prepare to receive 64-bit replies

2023-05-25 Thread Eric Blake
Support receiving headers for 64-bit replies if extended headers were negotiated. We already insist that the server not send us too much payload in one reply, so we can exploit that and merge the 64-bit length back into a normalized 32-bit field for the rest of the payload length calculations. Th