Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-18 Thread alan somers
Just released Mockall 0.11.3. On Sat, Oct 15, 2022 at 1:11 AM Richard W.M. Jones wrote: > > > Thanks - I'll push Thomas's patch shortly. We can always revert it > later when the updated mockall package is released. > > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-15 Thread Richard W.M. Jones
Thanks - I'll push Thomas's patch shortly. We can always revert it later when the updated mockall package is released. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-15 Thread Richard W.M. Jones
On Fri, Oct 14, 2022 at 10:59:30PM +0200, Thomas Weißschuh wrote: > On 2022-10-14 21:54+0100, Richard W.M. Jones wrote: > > On Fri, Oct 14, 2022 at 10:42:30PM +0200, Thomas Weißschuh wrote: > > > rustc 1.64.0 generates warnings for the mocked Server. > > > This leads to a failure of test.sh. > > >

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread alan somers
The best strategy for Mockall consumers is to use the #[allow(dead_code)] just like you did. Or else, you know, to bug Mockall's maintainer to release the patch ;) On Fri, Oct 14, 2022, 2:59 PM Thomas Weißschuh wrote: > On 2022-10-14 21:54+0100, Richard W.M. Jones wrote: > > On Fri, Oct 14,

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread Thomas Weißschuh
On 2022-10-14 21:54+0100, Richard W.M. Jones wrote: > On Fri, Oct 14, 2022 at 10:42:30PM +0200, Thomas Weißschuh wrote: > > rustc 1.64.0 generates warnings for the mocked Server. > > This leads to a failure of test.sh. > > > > ``` > > warning: associated function `expect` is never used > > -->

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread Richard W.M. Jones
On Fri, Oct 14, 2022 at 10:42:30PM +0200, Thomas Weißschuh wrote: > rustc 1.64.0 generates warnings for the mocked Server. > This leads to a failure of test.sh. > > ``` > warning: associated function `expect` is never used > --> tests/common/mod.rs:49:1 >| > 49 | / mock!{ > 50 | | pub

[Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread Thomas Weißschuh
rustc 1.64.0 generates warnings for the mocked Server. This leads to a failure of test.sh. ``` warning: associated function `expect` is never used --> tests/common/mod.rs:49:1 | 49 | / mock!{ 50 | | pub Server {} 51 | | impl Server for Server { 52 | | fn cache(, count: u32,