Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-15 Thread Richard W.M. Jones
On Tue, Nov 15, 2022 at 06:40:33PM +0100, Laszlo Ersek wrote: > On 11/15/22 17:02, Richard W.M. Jones wrote: > > On Thu, Nov 10, 2022 at 04:08:57PM +0100, Laszlo Ersek wrote: > >> Per perlpod(1), the canonical Formatting Code for this would be Z<>, as > >> in (untested): > >> > >> =item Z<>6 > >>

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-15 Thread Laszlo Ersek
On 11/15/22 17:02, Richard W.M. Jones wrote: > On Thu, Nov 10, 2022 at 04:08:57PM +0100, Laszlo Ersek wrote: >> Per perlpod(1), the canonical Formatting Code for this would be Z<>, as >> in (untested): >> >> =item Z<>6 >> >> However, I can't see a single instance of Z<> in the v2v projects, so it

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-15 Thread Richard W.M. Jones
On Wed, Nov 09, 2022 at 02:43:53PM -0600, Eric Blake wrote: > Make it possible for the sh and eval plugins to disconnect a client or > shut down the entire nbdkit server by use of special return values. > Prior to this patch we had reserved 4-7 for future use; this defines > 4-8, and extends the

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-15 Thread Richard W.M. Jones
On Thu, Nov 10, 2022 at 04:08:57PM +0100, Laszlo Ersek wrote: > Per perlpod(1), the canonical Formatting Code for this would be Z<>, as > in (untested): > > =item Z<>6 > > However, I can't see a single instance of Z<> in the v2v projects, so it > could cause compatibility problems. I guess let's

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-14 Thread Laszlo Ersek
On 11/11/22 20:40, Eric Blake wrote: > This refactoring is big enough that I decided to split it into two > separate patches: one to add the return value and get rid of all the > redundant switch statements, the other to add the new enum values. Great, I didn't dare suggest it, but it's

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-11 Thread Eric Blake
On Thu, Nov 10, 2022 at 04:08:57PM +0100, Laszlo Ersek wrote: > On 11/09/22 21:43, Eric Blake wrote: > > Make it possible for the sh and eval plugins to disconnect a client or > > shut down the entire nbdkit server by use of special return values. > > Prior to this patch we had reserved 4-7 for

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Laszlo Ersek
On 11/09/22 21:43, Eric Blake wrote: > Make it possible for the sh and eval plugins to disconnect a client or > shut down the entire nbdkit server by use of special return values. > Prior to this patch we had reserved 4-7 for future use; this defines > 4-8, and extends the set of reserved return

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-09 Thread Eric Blake
On Wed, Nov 09, 2022 at 02:43:53PM -0600, Eric Blake wrote: > Make it possible for the sh and eval plugins to disconnect a client or > shut down the entire nbdkit server by use of special return values. > Prior to this patch we had reserved 4-7 for future use; this defines > 4-8, and extends the

[Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-09 Thread Eric Blake
Make it possible for the sh and eval plugins to disconnect a client or shut down the entire nbdkit server by use of special return values. Prior to this patch we had reserved 4-7 for future use; this defines 4-8, and extends the set of reserved return values to 9-15. We figure it is unlikely that