Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-13 Thread Laszlo Ersek
On 06/09/22 15:53, Laszlo Ersek wrote: > We can't rely on "nm-online" if it doesn't do its advertized job! I've checked the nm-online source code, and various other stuff in the NetworkManager source tree. nm-online is *completely unusable* for its stated purpose. The source code made my hair

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-10 Thread Laszlo Ersek
On 06/09/22 16:11, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 03:53:39PM +0200, Laszlo Ersek wrote: >> On 06/09/22 15:10, Laszlo Ersek wrote: >> >>> nm-online -x -q || >>> ( >>> systemctl -q is-active systemd-networkd && >>> /usr/lib/systemd/systemd-networkd-wait-online -q

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 03:53:39PM +0200, Laszlo Ersek wrote: > On 06/09/22 15:10, Laszlo Ersek wrote: > > > nm-online -x -q || > > ( > > systemctl -q is-active systemd-networkd && > > /usr/lib/systemd/systemd-networkd-wait-online -q --timeout=30 > > ) > > > > If the final exit status is

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-09 Thread Laszlo Ersek
On 06/09/22 15:10, Laszlo Ersek wrote: > nm-online -x -q || > ( > systemctl -q is-active systemd-networkd && > /usr/lib/systemd/systemd-networkd-wait-online -q --timeout=30 > ) > > If the final exit status is nonzero, I think that's not a problem for > the firstboot script. > > The whole

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-09 Thread Laszlo Ersek
On 06/07/22 14:59, Richard W.M. Jones wrote: > virt-p2v uses: > > nm-online -t 30 > > Apparently systemd-networkd (which I've never knowingly used) has > another command: > > /usr/lib/systemd/systemd-networkd-wait-online > > which ought to do the same thing. (It defaults to 120 second

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-08 Thread Laszlo Ersek
On 06/07/22 17:22, Richard W.M. Jones wrote: > On Tue, Jun 07, 2022 at 01:59:30PM +0100, Richard W.M. Jones wrote: >> On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote: >>> +(* Disable SELinux temporarily around package installation. >>> Refer to >>> + *

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-08 Thread Laszlo Ersek
On 06/07/22 14:59, Richard W.M. Jones wrote: > On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote: >> Register a firstboot script, for installing the guest agent with the >> guest's own package manager -- that is, "Guest_packages.install_command". >> >> For installing the package,

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-07 Thread Richard W.M. Jones
On Tue, Jun 07, 2022 at 01:59:30PM +0100, Richard W.M. Jones wrote: > On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote: > > +(* Disable SELinux temporarily around package installation. > > Refer to > > + *

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-07 Thread Richard W.M. Jones
On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote: > Register a firstboot script, for installing the guest agent with the > guest's own package manager -- that is, "Guest_packages.install_command". > > For installing the package, network connectivity is required; for lack of > a

[Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-06 Thread Laszlo Ersek
Register a firstboot script, for installing the guest agent with the guest's own package manager -- that is, "Guest_packages.install_command". For installing the package, network connectivity is required; for lack of a universal "wait online" dependency expression, register "sleep 60" as a