Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-30 Thread Laszlo Ersek
On 6/30/23 09:38, Richard W.M. Jones wrote: > On Fri, Jun 30, 2023 at 09:32:33AM +0200, Laszlo Ersek wrote: >> On 6/29/23 19:16, Richard W.M. Jones wrote: >>> On Thu, Jun 29, 2023 at 06:40:27PM +0200, Laszlo Ersek wrote: >> Either way, I can restore the parens. Do you want me to submit a v3?

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-30 Thread Richard W.M. Jones
On Fri, Jun 30, 2023 at 09:32:33AM +0200, Laszlo Ersek wrote: > On 6/29/23 19:16, Richard W.M. Jones wrote: > > On Thu, Jun 29, 2023 at 06:40:27PM +0200, Laszlo Ersek wrote: > > >> Either way, I can restore the parens. Do you want me to submit a v3? > > > > I think the parens are clearer. Don't

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-30 Thread Laszlo Ersek
On 6/29/23 19:16, Richard W.M. Jones wrote: > On Thu, Jun 29, 2023 at 06:40:27PM +0200, Laszlo Ersek wrote: >> Either way, I can restore the parens. Do you want me to submit a v3? > > I think the parens are clearer. Don't need a v3, thanks! Can I add your R-b that way (with the parens

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-29 Thread Richard W.M. Jones
On Thu, Jun 29, 2023 at 06:40:27PM +0200, Laszlo Ersek wrote: > On 6/29/23 17:48, Richard W.M. Jones wrote: > > On Thu, Jun 29, 2023 at 05:39:34PM +0200, Laszlo Ersek wrote: > >> On 6/29/23 14:54, Richard W.M. Jones wrote: > >>> On Thu, Jun 29, 2023 at 02:34:42PM +0200, Laszlo Ersek wrote: >

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-29 Thread Laszlo Ersek
On 6/29/23 17:48, Richard W.M. Jones wrote: > On Thu, Jun 29, 2023 at 05:39:34PM +0200, Laszlo Ersek wrote: >> On 6/29/23 14:54, Richard W.M. Jones wrote: >>> On Thu, Jun 29, 2023 at 02:34:42PM +0200, Laszlo Ersek wrote: Currently "chown_for_libvirt_rhbz_1045069" is best effort; if it fails,

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-29 Thread Richard W.M. Jones
On Thu, Jun 29, 2023 at 05:39:34PM +0200, Laszlo Ersek wrote: > On 6/29/23 14:54, Richard W.M. Jones wrote: > > On Thu, Jun 29, 2023 at 02:34:42PM +0200, Laszlo Ersek wrote: > >> Currently "chown_for_libvirt_rhbz_1045069" is best effort; if it fails, we > >> suppress the exception (we log it in

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-29 Thread Laszlo Ersek
On 6/29/23 14:54, Richard W.M. Jones wrote: > On Thu, Jun 29, 2023 at 02:34:42PM +0200, Laszlo Ersek wrote: >> Currently "chown_for_libvirt_rhbz_1045069" is best effort; if it fails, we >> suppress the exception (we log it in verbose mode only, even). >> >> That's not proved helpful: it almost

Re: [Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-29 Thread Richard W.M. Jones
On Thu, Jun 29, 2023 at 02:34:42PM +0200, Laszlo Ersek wrote: > Currently "chown_for_libvirt_rhbz_1045069" is best effort; if it fails, we > suppress the exception (we log it in verbose mode only, even). > > That's not proved helpful: it almost certainly leads to later errors, but > those errors

[Libguestfs] [v2v PATCH v2 2/3] lib/utils: make "chown_for_libvirt_rhbz_1045069" fail hard

2023-06-29 Thread Laszlo Ersek
Currently "chown_for_libvirt_rhbz_1045069" is best effort; if it fails, we suppress the exception (we log it in verbose mode only, even). That's not proved helpful: it almost certainly leads to later errors, but those errors are less clear than the original (suppressed) exception. Namely, the