Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 09:23:50PM +0300, Nir Soffer wrote: > On Thu, Jun 9, 2022 at 6:24 PM Richard W.M. Jones wrote: > > $ emacs -nw run.in# comment out GODEBUG line ... > > $ make -C golang check > > ... > > PASS: run-tests.sh > > So when skipping libnbd_020_aio_buffer_test.go we don't

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 05:33:03PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 07:22:45PM +0300, Nir Soffer wrote: > > On Thu, Jun 9, 2022 at 6:48 PM Richard W.M. Jones wrote: > > > NB: this _does not_ address the other problem where GODEBUG=cgocheck=2 > > > complains about "fatal

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Nir Soffer
On Thu, Jun 9, 2022 at 6:24 PM Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > + go test -count=1 -v > > > === RUN Test010Load > > > --- PASS: Test010Load (0.00s) > > > === RUN TestAioBuffer > > > --- PASS: TestAioBuffer (0.00s) > > >

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 07:22:45PM +0300, Nir Soffer wrote: > On Thu, Jun 9, 2022 at 6:48 PM Richard W.M. Jones wrote: > > NB: this _does not_ address the other problem where GODEBUG=cgocheck=2 > > complains about "fatal error: Go pointer stored into non-Go memory". > > Do we keep go pointers in

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 05:00:46PM +0100, Daniel P. Berrangé wrote: > Well it isn't use-after-free, because we've cleared the > pointer we freed. Yes, indeed that's what I meant to say! > > It seems a bit of an odd function however. Wouldn't it be better to > > changes the Bytes function so

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Nir Soffer
On Thu, Jun 9, 2022 at 6:48 PM Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 04:24:12PM +0100, Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > > + go test -count=1 -v > > > > === RUN Test010Load > > > > --- PASS: Test010Load

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 04:48:34PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 04:24:12PM +0100, Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > > + go test -count=1 -v > > > > === RUN Test010Load > > > > --- PASS:

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 04:24:12PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > + go test -count=1 -v > > > === RUN Test010Load > > > --- PASS: Test010Load (0.00s) > > > === RUN TestAioBuffer > > > --- PASS: TestAioBuffer (0.00s)

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > + go test -count=1 -v > > === RUN Test010Load > > --- PASS: Test010Load (0.00s) > > === RUN TestAioBuffer > > --- PASS: TestAioBuffer (0.00s) > > === RUN TestAioBufferFree > > --- PASS: TestAioBufferFree (0.00s) > > ===

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 03:08:51PM +0100, Richard W.M. Jones wrote: > On Thu, Jun 09, 2022 at 02:14:07PM +0100, Daniel P. Berrangé wrote: > > If you can get the test to core dump, then plain old GDB core > > dump could also be useful - might identify which specific API > > is being called, which

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
On Thu, Jun 09, 2022 at 02:14:07PM +0100, Daniel P. Berrangé wrote: > Setting GODEBUG=cgocheck=1 or GODEBUG=cgocheck=2 can sometimes > get more info. Took me a while to work out that we are actually setting that already (in ./run) which explains a couple of things: why I couldn't reproduce the

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 02:03:04PM +0100, Richard W.M. Jones wrote: > make[2]: Entering directory '/home/rjones/d/libnbd/golang' > perl /home/rjones/d/libnbd/podwrapper.pl --section=3 --man libnbd-golang.3 \ > --html ../html/libnbd-golang.3.html \ > libnbd-golang.pod >

[Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Richard W.M. Jones
make[2]: Entering directory '/home/rjones/d/libnbd/golang' perl /home/rjones/d/libnbd/podwrapper.pl --section=3 --man libnbd-golang.3 \ --html ../html/libnbd-golang.3.html \ libnbd-golang.pod /home/rjones/d/libnbd/run go build write of Go pointer 0x3fa8028000 to non-Go memory 0x3fd2c0fb20