Re: [Libguestfs] [PATCH common 2/4] mltools: Reimplement On_exit to use a list of actions

2022-07-15 Thread Laszlo Ersek
On 07/15/22 10:12, Richard W.M. Jones wrote: > On Fri, Jul 15, 2022 at 09:12:24AM +0200, Laszlo Ersek wrote: >>> +let do_action action = >>> + try >>> +match action with >>> +| Unlink file -> Unix.unlink file >>> +| Rm_rf dir -> >>> + let cmd = sprintf "rm -rf %s"

Re: [Libguestfs] [PATCH common 2/4] mltools: Reimplement On_exit to use a list of actions

2022-07-15 Thread Richard W.M. Jones
On Fri, Jul 15, 2022 at 09:12:24AM +0200, Laszlo Ersek wrote: > > +let do_action action = > > + try > > +match action with > > +| Unlink file -> Unix.unlink file > > +| Rm_rf dir -> > > + let cmd = sprintf "rm -rf %s" (Filename.quote dir) in ... > > (2) Shouldn't we use two

Re: [Libguestfs] [PATCH common 2/4] mltools: Reimplement On_exit to use a list of actions

2022-07-15 Thread Laszlo Ersek
On 07/14/22 14:36, Richard W.M. Jones wrote: > Previously we used separate lists of files, dirs, pids, etc. This > makes it harder to introduce new features to reorder actions. > Reimplement the module so we use a simple list of actions, where each > action can have type File, Rm_rf, Kill, etc.