Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-23 Thread Eric Blake
On 9/21/19 2:59 PM, Richard W.M. Jones wrote: >> Is it usable without any plugins? Does the null plugin take much space? I >> wouldn't think so. Would it be too messy to just ship the null plugin >> unconditionally, even if just for this particular purpose? > > Right! My original plan was

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Martin Kletzander
On Sat, Sep 21, 2019 at 08:59:54PM +0100, Richard W.M. Jones wrote: On Sat, Sep 21, 2019 at 09:45:16PM +0200, Martin Kletzander wrote: On Sat, Sep 21, 2019 at 03:54:11PM +0100, Richard W.M. Jones wrote: >On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: >>Checking for file existence

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Richard W.M. Jones
On Sat, Sep 21, 2019 at 09:45:16PM +0200, Martin Kletzander wrote: > On Sat, Sep 21, 2019 at 03:54:11PM +0100, Richard W.M. Jones wrote: > >On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: > >>Checking for file existence for filters is somewhat less fragile than > >>for plugins, because

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Martin Kletzander
On Sat, Sep 21, 2019 at 03:54:11PM +0100, Richard W.M. Jones wrote: On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: Checking for file existence for filters is somewhat less fragile than for plugins, because all filters are built in-tree (we've specifically documented that we don't

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Richard W.M. Jones
On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: > Checking for file existence for filters is somewhat less fragile than > for plugins, because all filters are built in-tree (we've specifically > documented that we don't provide ABI guarantees for filters, so the only > sane way to use

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-20 Thread Martin Kletzander
On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: On 9/20/19 9:04 AM, Martin Kletzander wrote: On Fri, Sep 20, 2019 at 10:28:18AM +0100, Richard W.M. Jones wrote: The readahead filter is a self-configuring filter that makes sequential reads faster when the plugin is slow (and all of

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-20 Thread Richard W.M. Jones
Also of note in this conversation: https://github.com/libguestfs/nbdkit/blob/master/docs/nbdkit-probing.pod which currently doesn't mention filters, but ought to once we settle on the definitive way to detect them. Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-20 Thread Martin Kletzander
On Fri, Sep 20, 2019 at 10:28:18AM +0100, Richard W.M. Jones wrote: The readahead filter is a self-configuring filter that makes sequential reads faster when the plugin is slow (and all of the plugins we use here are always slow). I observed the behaviour of the readahead filter with our qcow2