Re: [Libguestfs] [V2V PATCH v2 0/5] Bring support for virtio-scsi back to Windows

2023-03-09 Thread Richard W.M. Jones
On Thu, Mar 09, 2023 at 05:03:02PM +0200, Andrey Drobyshev wrote: > On 3/9/23 16:50, Andrey Drobyshev wrote: > > On 3/8/23 22:46, Richard W.M. Jones wrote: > >> > >> The patch series looks generally fine, but it really needs a test ... > >> > >> We find that having tests prevents unnoticed

Re: [Libguestfs] [V2V PATCH v2 0/5] Bring support for virtio-scsi back to Windows

2023-03-09 Thread Andrey Drobyshev
On 3/9/23 16:50, Andrey Drobyshev wrote: > On 3/8/23 22:46, Richard W.M. Jones wrote: >> >> The patch series looks generally fine, but it really needs a test ... >> >> We find that having tests prevents unnoticed regressions from >> happening later. >> >> Rich. >> > > Could you please elaborate

Re: [Libguestfs] [V2V PATCH v2 0/5] Bring support for virtio-scsi back to Windows

2023-03-09 Thread Andrey Drobyshev
On 3/8/23 22:46, Richard W.M. Jones wrote: > > The patch series looks generally fine, but it really needs a test ... > > We find that having tests prevents unnoticed regressions from > happening later. > > Rich. > Could you please elaborate on how do you imagine such a test case? Basically

Re: [Libguestfs] [V2V PATCH v2 0/5] Bring support for virtio-scsi back to Windows

2023-03-08 Thread Richard W.M. Jones
The patch series looks generally fine, but it really needs a test ... We find that having tests prevents unnoticed regressions from happening later. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: