Re: [Libguestfs] [libguestfs PATCH 2/7] lib/launch-libvirt: support networking with passt

2023-07-14 Thread Richard W.M. Jones
On Fri, Jul 14, 2023 at 12:18:21PM +0200, Laszlo Ersek wrote: > On 7/14/23 11:40, Richard W.M. Jones wrote: > > On Thu, Jul 13, 2023 at 07:10:47PM +0200, Laszlo Ersek wrote: > >> We generate the element on libvirt 3.8.0+ already. > >> > >> For selecting passt rather than SLIRP, we only need to

Re: [Libguestfs] [libguestfs PATCH 2/7] lib/launch-libvirt: support networking with passt

2023-07-14 Thread Laszlo Ersek
On 7/14/23 11:40, Richard W.M. Jones wrote: > On Thu, Jul 13, 2023 at 07:10:47PM +0200, Laszlo Ersek wrote: >> We generate the element on libvirt 3.8.0+ already. >> >> For selecting passt rather than SLIRP, we only need to insert the child >> element . Make that child element conditional on >>

Re: [Libguestfs] [libguestfs PATCH 2/7] lib/launch-libvirt: support networking with passt

2023-07-14 Thread Richard W.M. Jones
On Thu, Jul 13, 2023 at 07:10:47PM +0200, Laszlo Ersek wrote: > We generate the element on libvirt 3.8.0+ already. > > For selecting passt rather than SLIRP, we only need to insert the child > element . Make that child element conditional on > libvirt 9.0.0+, plus "passt --help" being