Re: [Libguestfs] [libnbd PATCH] internal: s/handle/cookie/ to match NBD spec

2023-05-31 Thread Richard W.M. Jones
On Tue, May 30, 2023 at 12:44:41PM -0500, Eric Blake wrote: > On Tue, May 30, 2023 at 01:18:55PM +0200, Laszlo Ersek wrote: > > On 5/29/23 18:24, Eric Blake wrote: > > > Externally, we have been exposing the 64-bit opaque marker for each > > > NBD packet as the "cookie", because it was less

Re: [Libguestfs] [libnbd PATCH] internal: s/handle/cookie/ to match NBD spec

2023-05-30 Thread Eric Blake
On Tue, May 30, 2023 at 01:18:55PM +0200, Laszlo Ersek wrote: > On 5/29/23 18:24, Eric Blake wrote: > > Externally, we have been exposing the 64-bit opaque marker for each > > NBD packet as the "cookie", because it was less confusing when > > contrasted with our 'struct nbd_handle *' holding all

Re: [Libguestfs] [libnbd PATCH] internal: s/handle/cookie/ to match NBD spec

2023-05-30 Thread Laszlo Ersek
On 5/29/23 18:24, Eric Blake wrote: > Externally, we have been exposing the 64-bit opaque marker for each > NBD packet as the "cookie", because it was less confusing when > contrasted with our 'struct nbd_handle *' holding all libnbd state. > It also avoids confusion between the noun 'handle' as a