Re: [Libguestfs] [libnbd PATCH v2 02/12] api: Fix nbd_can_meta_context if NBD_OPT_SET_META_CONTEXT fails

2022-09-01 Thread Eric Blake
On Thu, Sep 01, 2022 at 11:04:09AM +0200, Laszlo Ersek wrote: ... > > > > Rather than open-code a cleanup loop on all error paths, I instead fix > > the problem by adding a meta_valid witness that is only set to true in > > select places. The obvious place is when handling NBD_REP_ACK; but it

Re: [Libguestfs] [libnbd PATCH v2 02/12] api: Fix nbd_can_meta_context if NBD_OPT_SET_META_CONTEXT fails

2022-09-01 Thread Laszlo Ersek
On 08/31/22 16:39, Eric Blake wrote: > If a server replies to NBD_OPT_SET_META_CONTEXT first with > NBD_REP_META_CONTEXT, then with NBD_REP_ERR_*, we have already > modified h->meta_contexts, but fail to clean it up before moving on to > OPT_GO in the OPT_META_CONTEXT.CHECK_REPLY's default: