Re: [Libguestfs] LZO compression for NBD ?

2018-10-04 Thread Eric Blake
[adding libguestfs list, for nbdkit reference below] On 10/4/18 8:39 AM, Stefan Fröberg wrote: Hello. Is it possible to improve NBD throughtput with LZO compression ? As in, have a way for the client and server to negotiate that both understand an LZO extension, at which point the client can

Re: [Libguestfs] [PATCH v2] lib: Use qemu-img info -U option to avoid locking error.

2018-10-04 Thread Richard W.M. Jones
On Thu, Oct 04, 2018 at 04:52:28PM +0200, Pino Toscano wrote: > On Thursday, 4 October 2018 14:50:07 CEST Richard W.M. Jones wrote: > > On Thu, Oct 04, 2018 at 01:34:59PM +0100, Richard W.M. Jones wrote: > > > On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote: > > > > On Friday, 21

[Libguestfs] [PATCH 1/2] v2v: linux: remove open-vm-tools packages

2018-10-04 Thread Pino Toscano
Linux distributions usually ship the open source VMware tools as open-vm-tools (and open-vm-tools-desktop for the integration with X). While they will not run already anymore after the conversion, uninstall them during the conversion, to save some space in the converted guest. ---

[Libguestfs] [PATCH 2/2] v2v: linux: try to trick vmware-uninstall-tools.pl

2018-10-04 Thread Pino Toscano
When installing the VMware tools from tarball, the installation script rebuilds the initramdisk of all the available kernels to inject the missing kernel drivers; in the end, the information on which kernels were changed is recorded in the internal "database" of the installation answers. When

[Libguestfs] [PATCH 0/2] v2v: uninstall VMware tools on all Linux guests

2018-10-04 Thread Pino Toscano
Hi, this patch series attempt to uninstall VMware tools on all the Linux guests, and reduce the uninstallation time needed in some cases: - v2v tries to workaround the slowest part of the tarball-installed VMware tools - v2v uninstalls the open source VMware tools (open-vm-tools) Thanks, Pino

Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-10-04 Thread Richard W.M. Jones
On Thu, Jul 19, 2018 at 04:24:57PM +0200, Pino Toscano wrote: > On Thursday, 19 July 2018 15:51:04 CEST Tomáš Golembiovský wrote: > > Add oVirt specific elemnt to OVF. It represents the combination of > > machine type (i440fx/q35) and firmware (BIOS/UEFI). > > Other than adding a new element in

Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-10-04 Thread Richard W.M. Jones
On Thu, Jul 19, 2018 at 03:51:04PM +0200, Tomáš Golembiovský wrote: > Add oVirt specific elemnt to OVF. It represents the combination of > machine type (i440fx/q35) and firmware (BIOS/UEFI). > > Signed-off-by: Tomáš Golembiovský > --- > v2v/create_ovf.ml| 20

[Libguestfs] [PATCH 2/2] inspector: Use libxml writer macros.

2018-10-04 Thread Richard W.M. Jones
Change virt-inspector so it uses the common set of macros. I also added: - single_element(): creates bar which is used extensively by virt-inspector - base64(): used by virt-inspector for the icon --- common/utils/libxml2-writer-macros.h | 24 ++ inspector/inspector.c

[Libguestfs] [PATCH 1/2] common/utils: Move libxml2 writer macros to a common header file.

2018-10-04 Thread Richard W.M. Jones
In some places when generating XML output in C code we use some clever macros: start_element ("memory") { attribute ("unit", "MiB"); string ("%d", g->memsize); } end_element (); This commit which is mostly refactoring moves the repeated definitions of these macros into a common

[Libguestfs] [PATCH v2 0/4] common/utils: Move libxml2 writer macros to a common header file.

2018-10-04 Thread Richard W.M. Jones
v1 was here: https://www.redhat.com/archives/libguestfs/2018-October/msg00047.html However it was broken in a few ways. First of all the documentation was broken because "/**" enhanced comments were not permitted on macros. This is fixed in the new 1/4 patch. Secondly we didn't use

[Libguestfs] [PATCH v2 2/4] common/utils: Move libxml2 writer macros to a common header file.

2018-10-04 Thread Richard W.M. Jones
In some places when generating XML output in C code we use some clever macros: start_element ("memory") { attribute ("unit", "MiB"); string ("%d", g->memsize); } end_element (); This commit which is mostly refactoring moves the repeated definitions of these macros into a common

[Libguestfs] [PATCH v2 3/4] inspector: Use libxml writer macros.

2018-10-04 Thread Richard W.M. Jones
Change virt-inspector so it uses the common set of macros. I also added: - single_element(): creates bar which is used extensively by virt-inspector - base64(): used by virt-inspector for the icon --- common/utils/libxml2-writer-macros.h | 26 ++ inspector/inspector.c

[Libguestfs] [PATCH v2 1/4] docs: Allow enhanced comments for macros (ie. #define).

2018-10-04 Thread Richard W.M. Jones
--- docs/make-internal-documentation.pl | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/make-internal-documentation.pl b/docs/make-internal-documentation.pl index a6673c48f..e08adad70 100755 --- a/docs/make-internal-documentation.pl +++

[Libguestfs] [PATCH v2 4/4] lib, p2v: Use single_element() macro where possible.

2018-10-04 Thread Richard W.M. Jones
After the previous commit, wherever we had: start_element ("foo") { string ("bar"); } end_element (); this can now be replaced by: single_element ("foo", "bar"); --- lib/launch-libvirt.c | 81 p2v/physical-xml.c | 15 +++- 2 files

Re: [Libguestfs] [PATCH 2/2] v2v: linux: try to trick vmware-uninstall-tools.pl

2018-10-04 Thread Richard W.M. Jones
On Thu, Oct 04, 2018 at 12:11:12PM +0200, Pino Toscano wrote: > When installing the VMware tools from tarball, the installation script > rebuilds the initramdisk of all the available kernels to inject the > missing kernel drivers; in the end, the information on which kernels > were changed is

Re: [Libguestfs] [PATCH] v2v: Remove ‘-io vimapiver’ option (RHBZ#1527334).

2018-10-04 Thread Pino Toscano
On Wednesday, 26 September 2018 11:20:45 CEST Richard W.M. Jones wrote: > This option was added in error. It never had any effect and now the > nbdkit VDDK plugin ignores it. Virt-v2v users shouldn't have been > using it. > > This removes the option completely (so if anyone was using it they >

Re: [Libguestfs] OpenStack output workflow

2018-10-04 Thread Fabien Dupont
New code tries SIGTERM first, with a grace period of 30 seconds: https://github.com/ManageIQ/manageiq-content/pull/433. On Wed, Sep 26, 2018 at 6:10 PM Richard W.M. Jones wrote: > On Wed, Sep 26, 2018 at 04:57:19PM +0200, Fabien Dupont wrote: > > It's not virt-v2v-wrapper that kills virt-v2v,

Re: [Libguestfs] [PATCH] v2v: -it vddk: Add a warning about using vddk* options (RHBZ#1527334).

2018-10-04 Thread Pino Toscano
On Wednesday, 26 September 2018 11:25:22 CEST Richard W.M. Jones wrote: > Stress these options shouldn't be used unless you know what you're > doing. > --- A bit faint as warnings, but OK. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: [Libguestfs] [PATCH v2] lib: Use qemu-img info -U option to avoid locking error.

2018-10-04 Thread Richard W.M. Jones
On Thu, Oct 04, 2018 at 01:34:59PM +0100, Richard W.M. Jones wrote: > On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote: > > On Friday, 21 September 2018 11:53:52 CEST Richard W.M. Jones wrote: > > > +/** > > > + * Test if the qemu-img info command supports the C<-U> option to > > > + *

Re: [Libguestfs] [PATCH v2] lib: Use qemu-img info -U option to avoid locking error.

2018-10-04 Thread Pino Toscano
On Thursday, 4 October 2018 14:50:07 CEST Richard W.M. Jones wrote: > On Thu, Oct 04, 2018 at 01:34:59PM +0100, Richard W.M. Jones wrote: > > On Wed, Sep 26, 2018 at 06:36:47PM +0200, Pino Toscano wrote: > > > On Friday, 21 September 2018 11:53:52 CEST Richard W.M. Jones wrote: > > > > +/** > > >