Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Richard W.M. Jones
On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: > Checking for file existence for filters is somewhat less fragile than > for plugins, because all filters are built in-tree (we've specifically > documented that we don't provide ABI guarantees for filters, so the only > sane way to use

[Libguestfs] [PATCH nbdkit] docs: Suggest how to detect if a filter is installed.

2019-09-21 Thread Richard W.M. Jones
Thanks: Eric Blake, Martin Kletzander. --- docs/nbdkit-probing.pod | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/nbdkit-probing.pod b/docs/nbdkit-probing.pod index 94bdfb4..46a7c47 100644 --- a/docs/nbdkit-probing.pod +++ b/docs/nbdkit-probing.pod @@ -80,6 +80,17 @@

[Libguestfs] [PATCH nbdkit] server: public: Add nbdkit_parse_* functions for safely parsing integers.

2019-09-21 Thread Richard W.M. Jones
sscanf is sadly not safe (because it doesn't handle integer overflow correctly), and strto*l functions are a pain to use correctly. Therefore add some functions to hide the pain of parsing integers from the command line. The simpler uses of sscanf and strto*l are replaced. There are still a few

Re: [Libguestfs] [PATCH nbdkit] docs: Suggest how to detect if a filter is installed.

2019-09-21 Thread Martin Kletzander
On Sat, Sep 21, 2019 at 03:53:45PM +0100, Richard W.M. Jones wrote: Thanks: Eric Blake, Martin Kletzander. --- docs/nbdkit-probing.pod | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/nbdkit-probing.pod b/docs/nbdkit-probing.pod index 94bdfb4..46a7c47 100644 ---

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Martin Kletzander
On Sat, Sep 21, 2019 at 03:54:11PM +0100, Richard W.M. Jones wrote: On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: Checking for file existence for filters is somewhat less fragile than for plugins, because all filters are built in-tree (we've specifically documented that we don't

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Richard W.M. Jones
On Sat, Sep 21, 2019 at 09:45:16PM +0200, Martin Kletzander wrote: > On Sat, Sep 21, 2019 at 03:54:11PM +0100, Richard W.M. Jones wrote: > >On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: > >>Checking for file existence for filters is somewhat less fragile than > >>for plugins, because

Re: [Libguestfs] [PATCH v4 07/12] v2v: nbdkit: Add the readahead filter unconditionally if it is available.

2019-09-21 Thread Martin Kletzander
On Sat, Sep 21, 2019 at 08:59:54PM +0100, Richard W.M. Jones wrote: On Sat, Sep 21, 2019 at 09:45:16PM +0200, Martin Kletzander wrote: On Sat, Sep 21, 2019 at 03:54:11PM +0100, Richard W.M. Jones wrote: >On Fri, Sep 20, 2019 at 09:33:06AM -0500, Eric Blake wrote: >>Checking for file existence

Re: [Libguestfs] [PATCH nbdkit] docs: Suggest how to detect if a filter is installed.

2019-09-21 Thread Richard W.M. Jones
On Sat, Sep 21, 2019 at 09:41:04PM +0200, Martin Kletzander wrote: > On Sat, Sep 21, 2019 at 03:53:45PM +0100, Richard W.M. Jones wrote: > >Thanks: Eric Blake, Martin Kletzander. > >--- > >docs/nbdkit-probing.pod | 11 +++ > >1 file changed, 11 insertions(+) > > > >diff --git