[Libguestfs] libnbd ocaml test pipeline failure (was: Re: [libnbd PATCH] api: Fix block status assertion under set_strict bypass)

2023-07-17 Thread Richard W.M. Jones
On Sun, Jul 16, 2023 at 04:10:56PM +0100, Richard W.M. Jones wrote: > The pipeline failed after you pushed this: > > https://gitlab.com/nbdkit/libnbd/-/pipelines/932589424 > > but I think it's an unrelated OCaml failure. I'll take a proper look > at it tomorrow. The error is: FAIL:

Re: [Libguestfs] [libnbd PATCH 1/2] api: Tighten rules on completion.callback

2023-07-17 Thread Tage Johansson
On 7/14/2023 4:13 PM, Eric Blake wrote: On Fri, Jul 14, 2023 at 09:13:42AM +0200, Laszlo Ersek wrote: On 7/13/23 21:29, Eric Blake wrote: The documentation has claimed since commit 6f4dcdab that any completion callback will be called exactly once; but this is not consistent with the code: if

Re: [Libguestfs] [libnbd PATCH] api: Fix block status assertion under set_strict bypass

2023-07-17 Thread Eric Blake
On Sun, Jul 16, 2023 at 04:10:56PM +0100, Richard W.M. Jones wrote: > On Sat, Jul 15, 2023 at 08:49:51PM -0500, Eric Blake wrote: > > A compliant server should not send NBD_REPLY_TYPE_BLOCK_STATUS unless > > we successfully negotiated a meta context. And our default strictness > > settings refuse

Re: [Libguestfs] [libnbd PATCH 1/2] api: Tighten rules on completion.callback

2023-07-17 Thread Eric Blake
On Sun, Jul 16, 2023 at 04:39:18PM +, Tage Johansson wrote: > > @@ -194,7 +198,10 @@ calls. The cookie is unique (per libnbd handle) and > > E 1. > > > > You may register a function which is called when the command > > completes, see L below. In this case we have > > -specified a null

[Libguestfs] LIBNBD SECURITY: Assertion failure with unexpected block status

2023-07-17 Thread Eric Blake
We have discovered a security flaw with potential minor impact in libnbd. Lifecycle - Reported: 2023-07-14 Fixed: 2023-07-15 Published: 2023-07-17 This was not deemed severe enough to warrant a CVE: even though a malicious server can cause libnbd to crash in a specific scenario, it