Re: [Libguestfs] [PATCH libguestfs] daemon: lvm: Do reverse device name translation on pvs_full device fields

2023-07-20 Thread Richard W.M. Jones
This is another failure, this time in virt-diff (see attachment for full build log). virt-diff works by opening two handles to different disk images and the comparing the filesystems in each. When we stat files in the two handles: handle 'g1' returns st_dev = 2065 [8:17, /dev/sdb1] handle

Re: [Libguestfs] [libguestfs PATCH v2 0/7] lib: support networking with passt

2023-07-20 Thread Richard W.M. Jones
So I get this error with upstream libguestfs: Original error from libvirt: internal error: Child process (/usr/bin/passt --one-off --socket /run/user/1000/libvirt/qemu/run/passt/160-guestfs-s42xm02n9vqv-net0.socket --mac-addr 52:54:00:3d:ce:ce --pid

[Libguestfs] Intermittent test failure in guestfs-tools test-virt-filesystems.sh

2023-07-20 Thread Richard W.M. Jones
(See attachment for full log) https://github.com/rwmjones/guestfs-tools/blob/master/cat/test-virt-filesystems.sh This test uses virt-filesystems to list the filesystems in the Fedora phony disk image. In one run of this test it found an "extra" /dev/sdb2 filesystem that obviously doesn't exist.

[Libguestfs] [PATCH libguestfs] daemon: lvm: Do reverse device name translation on pvs_full device fields

2023-07-20 Thread Richard W.M. Jones
Intermittent test failures in virt-filesystems showed that when using the pvs_full API, the pv_name field in the returned list of structures was not being reverse translated. As a result internal partition names could appear in the output of virt-filesystems. See:

Re: [Libguestfs] [libguestfs PATCH v2 0/7] lib: support networking with passt

2023-07-20 Thread Richard W.M. Jones
On Thu, Jul 20, 2023 at 11:45:11AM +0100, Richard W.M. Jones wrote: > So I get this error with upstream libguestfs: > > Original error from libvirt: internal error: Child process (/usr/bin/passt > --one-off --socket > /run/user/1000/libvirt/qemu/run/passt/160-guestfs-s42xm02n9vqv-net0.socket

Re: [Libguestfs] [PATCH guestfs-tools] diff: Don't compare st_dev or st_ino fields

2023-07-20 Thread Richard W.M. Jones
On Thu, Jul 20, 2023 at 05:31:28PM +0200, Laszlo Ersek wrote: > On 7/20/23 16:15, Richard W.M. Jones wrote: > > See comment for details. > > > > Link: https://listman.redhat.com/archives/libguestfs/2023-July/032061.html > > --- > > diff/diff.c | 16 ++-- > > 1 file changed, 14

[Libguestfs] [PATCH guestfs-tools] diff: Don't compare st_dev or st_ino fields

2023-07-20 Thread Richard W.M. Jones
See comment for details. Link: https://listman.redhat.com/archives/libguestfs/2023-July/032061.html --- diff/diff.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/diff/diff.c b/diff/diff.c index fb66a2bbd3..b6344b4ec2 100644 --- a/diff/diff.c +++

Re: [Libguestfs] [PATCH guestfs-tools] diff: Don't compare st_dev or st_ino fields

2023-07-20 Thread Laszlo Ersek
On 7/20/23 16:15, Richard W.M. Jones wrote: > See comment for details. > > Link: https://listman.redhat.com/archives/libguestfs/2023-July/032061.html > --- > diff/diff.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/diff/diff.c b/diff/diff.c > index

Re: [Libguestfs] [PATCH libguestfs] daemon: lvm: Do reverse device name translation on pvs_full device fields

2023-07-20 Thread Richard W.M. Jones
Upstream in commit 32cb5b45cf. I tested this using guestfs-tools & virt-v2v and nothing failed. However I was never able to reproduce the original issue. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: