Re: [Libguestfs] Another virt-p2v blew up

2012-01-05 Thread Greg Scott
> libguestfs should detect \winnt as the %systemroot%. You can check > by doing: > > virt-inspector2 Guest | grep -i systemroot The challenge here is I never get to look at the resulting disk image because virt-p2v-server gets rid of it right after it finishes building it. If it's happy with

Re: [Libguestfs] Another virt-p2v blew up

2012-01-05 Thread Greg Scott
I just checked the versions on the conversion server: [root@Fedora16-64P2V ~]# rpm -qa | grep libguestfs python-libguestfs-1.14.2-1.fc16.x86_64 libguestfs-tools-c-1.14.2-1.fc16.x86_64 libguestfs-tools-1.14.2-1.fc16.x86_64 libguestfs-1.14.2-1.fc16.x86_64 [root@Fedora16-64P2V ~]# [root@Fedora16-64P2

[Libguestfs] virt-v2v should add kernel console= to Xen->KVM converted guest's grub.conf

2012-01-05 Thread Chuck Anderson
I'm using virt-v2v (0.8.3 currently) on EL6 to convert Xen guests to KVM. I see how virt-v2v converts any existing references to xvc0 and hvc0 serial console devices in /etc/inittab, /etc/securetty, and grub.conf. However, my Xen DomU grub.conf's don't have any mention of console= on the kernel l

Re: [Libguestfs] [hivex] [PATCH 1/1] hivexml: Change value type output to standard names

2012-01-05 Thread Richard W.M. Jones
On Mon, Dec 12, 2011 at 10:03:57PM -0800, Alex Nelson wrote: > Signed-off-by: Alex Nelson Unfortunately this patch doesn't compile cleanly with gcc warnings enabled, because of lots of const-correctness problems. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~r

Re: [Libguestfs] [hivex] [PATCH 0/1] hivexml: Revise type names in output

2012-01-05 Thread Richard W.M. Jones
On Mon, Dec 12, 2011 at 10:03:54PM -0800, Alex Nelson wrote: > This patch revises the value type information printed. It is also > somewhat a test of how open to revision the output of a program is > according to RedHat's policies, of which I am not very aware beyond > strongly guaranteeing ABI co

Re: [Libguestfs] [hivex] [PATCH 2/2] hivex: Expose embedded hive file name

2012-01-05 Thread Richard W.M. Jones
On Mon, Dec 12, 2011 at 09:59:20PM -0800, Alex Nelson wrote: > Signed-off-by: Alex Nelson > --- > generator/generator.ml |6 ++ > lib/hivex.c|6 ++ > xml/hivexml.c |9 + > 3 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/generato

Re: [Libguestfs] [hivex] [PATCH 1/2] hivex: Expose hive major and minor version

2012-01-05 Thread Richard W.M. Jones
On Mon, Dec 12, 2011 at 09:59:18PM -0800, Alex Nelson wrote: > The major and minor version were being reported in a debug message. > This patch adds the version information to the ABI and reports with > hivexml. > + "major_version", (RInt32, [AHive]), > +"return the major version of the hive",

Re: [Libguestfs] [hivex] [PATCH 8/8] hivexml: Add byte run reporting functions

2012-01-05 Thread Richard W.M. Jones
Thanks. I have pushed patches 1-7. I made a small change to the description of the function in patch 3. However this patch (8) cannot go in because it provokes many gcc warnings. Try configuring hivex with: ./configure --enable-gcc-warnings and recompile hivexml (possibly you'll only see wa