[Libguestfs] Gobject binding for sylistic review

2012-01-13 Thread Matthew Booth
This is a snapshot of gobject bindings. This is literally mid-edit, and contains numerous known errors in its output! I'm posting it for review of the ocaml code. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A

Re: [Libguestfs] [PATCH 1/2] ext2: tweak the error returned message of resize2fs-M(BZ755729)

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 02:27:49PM +0800, Wanlong Gao wrote: Tweak the error message e2fsck -f and e2fsck -fy to e2fsck-f and e2fsck-fy. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/ext2.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-)

Re: [Libguestfs] [PATCH 2/2] NEW API: new api e2fsck-fy for resize2fs

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 02:27:50PM +0800, Wanlong Gao wrote: Add a new api e2fsck-fy for resize2fs. Sometimes e2fsck-f is not enough. If resiz2fs return the message says: Please use e2fsck-fy first, we just haven't such a command, it's so awkward. Since we are going to rewrite the error

Re: [Libguestfs] Libguestfs gobject bindings

2012-01-13 Thread Daniel P. Berrange
On Thu, Jan 12, 2012 at 11:59:22AM +, Matthew Booth wrote: I'm currently working on gobject bindings for libguestfs. I haven't got as far as compiling anything yet, but I've attached the C header for initial review. typedef struct _GuestfsPV GuestfsPV; struct _GuestfsPV { gchar

Re: [Libguestfs] [PATCH 2/2] NEW API: new api e2fsck-fy for resize2fs

2012-01-13 Thread Wanlong Gao
On 01/13/2012 06:12 PM, Richard W.M. Jones wrote: On Fri, Jan 13, 2012 at 02:27:50PM +0800, Wanlong Gao wrote: Add a new api e2fsck-fy for resize2fs. Sometimes e2fsck-f is not enough. If resiz2fs return the message says: Please use e2fsck-fy first, we just haven't such a command, it's so

Re: [Libguestfs] [PATCH 1/2] ext2: tweak the error returned message of resize2fs-M(BZ755729)

2012-01-13 Thread Wanlong Gao
On 01/13/2012 06:08 PM, Richard W.M. Jones wrote: On Fri, Jan 13, 2012 at 02:27:49PM +0800, Wanlong Gao wrote: Tweak the error message e2fsck -f and e2fsck -fy to e2fsck-f and e2fsck-fy. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/ext2.c | 20 ++-- 1

Re: [Libguestfs] [PATCH 1/2] ext2: tweak the error returned message of resize2fs-M(BZ755729)

2012-01-13 Thread Jim Meyering
Richard W.M. Jones wrote: On Fri, Jan 13, 2012 at 02:27:49PM +0800, Wanlong Gao wrote: Tweak the error message e2fsck -f and e2fsck -fy to e2fsck-f and e2fsck-fy. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/ext2.c | 20 ++-- 1 files changed, 18

Re: [Libguestfs] [PATCH 2/2] NEW API: new api e2fsck-fy for resize2fs

2012-01-13 Thread Wanlong Gao
On 01/13/2012 09:08 PM, Richard W.M. Jones wrote: On Fri, Jan 13, 2012 at 07:09:38PM +0800, Wanlong Gao wrote: On 01/13/2012 06:12 PM, Richard W.M. Jones wrote: On Fri, Jan 13, 2012 at 02:27:50PM +0800, Wanlong Gao wrote: Add a new api e2fsck-fy for resize2fs. Sometimes e2fsck-f is not

Re: [Libguestfs] Libguestfs gobject bindings

2012-01-13 Thread Daniel P. Berrange
On Fri, Jan 13, 2012 at 12:50:30PM +, Richard W.M. Jones wrote: On Fri, Jan 13, 2012 at 12:28:50PM +, Daniel P. Berrange wrote: GIO provides all the infrastructure you need to do this, via the GSimpleAsyncResult object, and its g_simple_async_result_run_in_thread method. So it