Re: [Libguestfs] [PATCH V3 2/2] xfs_info: resolve device when doing xfs_info on a device

2012-07-24 Thread Wanlong Gao
On 07/24/2012 04:32 PM, Richard W.M. Jones wrote: On Mon, Jul 23, 2012 at 05:51:32PM +0800, Wanlong Gao wrote: -style = RStruct (info, xfsinfo), [Pathname path], []; +style = RStruct (info, xfsinfo), [String pathordevice], []; Actually NACK to this. I don't understand why you don't

[Libguestfs] [PATCH V4 2/3] xfs_info: resolve device when doing xfs_info on a device

2012-07-24 Thread Wanlong Gao
Resolve device first, like do_umount. Use Dev_or_Path. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/xfs.c | 21 - generator/generator_actions.ml | 2 +- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/daemon/xfs.c

[Libguestfs] [PATCH V4 1/3] umount: add force umount and lazy umount

2012-07-24 Thread Wanlong Gao
Add the option force and lazy for force and lazy umount. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/mount.c | 25 +++-- generator/generator_actions.ml | 23 --- gobject/Makefile.inc | 2 ++ po/POTFILES

[Libguestfs] [PATCH V4 3/3] umount: use Dev_or_Path for the argument type

2012-07-24 Thread Wanlong Gao
Use Dev_or_Path. Remove the RESOLVE_DEVICE since Dev_or_Path will generate the resolve code. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/mount.c | 3 --- generator/generator_actions.ml | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [Libguestfs] [PATCH V4 2/3] xfs_info: resolve device when doing xfs_info on a device

2012-07-24 Thread Richard W.M. Jones
On Tue, Jul 24, 2012 at 04:47:22PM +0800, Wanlong Gao wrote: Resolve device first, like do_umount. Use Dev_or_Path. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/xfs.c | 21 - generator/generator_actions.ml | 2 +- 2 files changed,

[Libguestfs] [PATCH 03/12] Mac OS X: Use gnulib memmem module explicitly.

2012-07-24 Thread Masami HIRATA
m4/.gitignore: Update. Signed-off-by: Masami HIRATA msm...@gmail.com --- bootstrap | 1 + m4/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/bootstrap b/bootstrap index 6b1fb3f..64473d2 100755 --- a/bootstrap +++ b/bootstrap @@ -65,6 +65,7 @@ ignore-value lock

[Libguestfs] [PATCH 02/12] configure: Use $(PERL) instead of perl

2012-07-24 Thread Masami HIRATA
Signed-off-by: Masami HIRATA msm...@gmail.com --- configure.ac | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index 61d6f69..1d07b0e 100644 --- a/configure.ac +++ b/configure.ac @@ -460,22 +460,27 @@

[Libguestfs] [PATCH 06/12] Mac OS X: #define UNIX_PATH_MAX 104

2012-07-24 Thread Masami HIRATA
See http://developer.apple.com/library/mac/documentation/Darwin/Reference/Manpages/man4/unix.4.html Signed-off-by: Masami HIRATA msm...@gmail.com --- src/guestfs-internal.h | 4 1 file changed, 4 insertions(+) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index

[Libguestfs] [PATCH 12/12] Mac OS X: Use u_int64_t/uint64_t instead of unsigned hyper in .x file

2012-07-24 Thread Masami HIRATA
Signed-off-by: Masami HIRATA msm...@gmail.com --- configure.ac | 8 fish/Makefile.am | 13 +++-- generator/generator_xdr.ml | 31 +++ src/Makefile.am| 13 +++-- 4 files changed, 53 insertions(+), 12