[Libguestfs] [PATCH 1/2] golang: Fix for out-of-tree builds

2013-12-12 Thread Hilko Bengen
--- configure.ac | 2 +- golang/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4e2bc65..9abec95 100644 --- a/configure.ac +++ b/configure.ac @@ -1530,7 +1530,7 @@ AS_IF([test "x$enable_golang" != "xno"],[ AC_CHECK_PROG

[Libguestfs] [PATCH 2/2] golang: Don't run launch test if appliance has not been built.

2013-12-12 Thread Hilko Bengen
--- golang/Makefile.am | 7 ++- golang/src/libguestfs.org/guestfs/guestfs_100_launch_test.go | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/golang/Makefile.am b/golang/Makefile.am index a60c9ba..f59488e 100644 --- a/golang/Makefi

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Olaf Hering
On Thu, Dec 12, Pino Toscano wrote: > No, I'm saying a weak dependency is no guarantee the provided firstboot > commands can run successfully, and running them after $all should > provide a better safety. Pino, the weakness is really just about the order of what will be ordered. It will not pu

Re: [Libguestfs] [PATCH] fuse: provide a stub "flush" implementation (RHBZ#660687).

2013-12-12 Thread Richard W.M. Jones
On Thu, Dec 12, 2013 at 04:28:31PM +0100, Pino Toscano wrote: > It seems that FUSE can invoke flush to make sure the pending changes > (e.g. to the attributes) of a file are set. Since a missing flush > implementation is handled as if it were returning ENOSYS, this can cause > issues later. > > To

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Pino Toscano
On Thursday 12 December 2013 16:27:30 Olaf Hering wrote: > On Thu, Dec 12, Pino Toscano wrote: > > Sure, but as a Should-Start means it is a weak dependency, and can > > be > > skipped, which is what I don't want. > > Are you saying in Debian the Should-Start is not handled properly? > Even if Sho

[Libguestfs] [PATCH] fuse: provide a stub "flush" implementation (RHBZ#660687).

2013-12-12 Thread Pino Toscano
It seems that FUSE can invoke flush to make sure the pending changes (e.g. to the attributes) of a file are set. Since a missing flush implementation is handled as if it were returning ENOSYS, this can cause issues later. To overcome this, just provide a stub implementation which does nothing, sin

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Olaf Hering
On Thu, Dec 12, Pino Toscano wrote: > Sure, but as a Should-Start means it is a weak dependency, and can be > skipped, which is what I don't want. Are you saying in Debian the Should-Start is not handled properly? Even if Should-Start is weak it still has to be taken into account. Olaf ___

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Pino Toscano
On Thursday 12 December 2013 15:01:07 Olaf Hering wrote: > On Thu, Dec 12, Pino Toscano wrote: > > On Thursday 12 December 2013 14:49:36 Olaf Hering wrote: > > > On Thu, Dec 12, Pino Toscano wrote: > > > > What do you think? > > > > > > I think that your Should-Start handling is broken. Required m

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Olaf Hering
On Thu, Dec 12, Pino Toscano wrote: > On Thursday 12 December 2013 14:49:36 Olaf Hering wrote: > > On Thu, Dec 12, Pino Toscano wrote: > > > What do you think? > > > > I think that your Should-Start handling is broken. Required means the > > given file can not properly work without the listed ser

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Pino Toscano
On Thursday 12 December 2013 14:49:36 Olaf Hering wrote: > On Thu, Dec 12, Pino Toscano wrote: > > What do you think? > > I think that your Should-Start handling is broken. Required means the > given file can not properly work without the listed servers, insserv > will error out. Should means it c

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Olaf Hering
On Thu, Dec 12, Pino Toscano wrote: > What do you think? I think that your Should-Start handling is broken. Required means the given file can not properly work without the listed servers, insserv will error out. Should means it can very well work without them if they are not present or enabled. O

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Pino Toscano
Hello, (sorry for the late reply, I was not involved in libugestfs until recently.) On Friday 21 September 2012 20:00:34 Olaf Hering wrote: > Currently firstboot would only work on redhat-based images. > Handle redhat-based, suse-based and debian guests, error out in case > of an unknown distro.