Re: [Libguestfs] RFC: copy-attributes command

2014-01-13 Thread Pino Toscano
On Friday 10 January 2014 16:53:32 Richard W.M. Jones wrote: On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: [..] This still isn't quite what I meant. My meaning was that mode would be disabled by default (unless all:true). OK. How about: int copy_mode, copy_xattributes,

[Libguestfs] [PATCH 1/3] ruby: Fix tests for out-of-tree build, simplify test scripts

2014-01-13 Thread Hilko Bengen
--- configure.ac | 1 + ruby/run-ruby-tests| 27 --- ruby/run-ruby-tests.in | 27 +++ ruby/tests/tc_010_load.rb | 2 -- ruby/tests/tc_021_close.rb | 2 -- ruby/tests/tc_120_rlenvalue.rb | 4 +---

[Libguestfs] [PATCH 3/3] ruby: Add test for special keys and values

2014-01-13 Thread Hilko Bengen
--- ruby/tests/tc_130_special.rb | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 ruby/tests/tc_130_special.rb diff --git a/ruby/tests/tc_130_special.rb b/ruby/tests/tc_130_special.rb new file mode 100644 index 000..0623f4d --- /dev/null +++

Re: [Libguestfs] RFC: copy-attributes command

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 12:54:36PM +0100, Pino Toscano wrote: On Friday 10 January 2014 16:53:32 Richard W.M. Jones wrote: On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: [..] This still isn't quite what I meant. My meaning was that mode would be disabled by default

Re: [Libguestfs] [PATCH 1/7] Add a minimal hive with special keys and values

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:46AM +0100, Hilko Bengen wrote: --- images/README | 14 images/mkzero/Makefile | 9 images/mkzero/mkzero.c | 59 + images/special | Bin 0 - 8192 bytes 4 files changed,

Re: [Libguestfs] [PATCH 2/7] lib: Use vk-len for string conversion

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:47AM +0100, Hilko Bengen wrote: --- lib/value.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/value.c b/lib/value.c index 65404d7..e700c84 100644 --- a/lib/value.c +++ b/lib/value.c @@ -207,14 +207,8 @@ hivex_value_key

Re: [Libguestfs] [PATCH 2/7] lib: Use vk-len for string conversion

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 01:17:52PM +, Richard W.M. Jones wrote: Is there a reason for this patch? It seems like just an optimization. OK, I see that the reason is to avoid calling _hivex_utf8_strlen which would fail for the name containing a \0 character. However I still think we need to

Re: [Libguestfs] [PATCH 4/7] python: Add test for special keys and values

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:49AM +0100, Hilko Bengen wrote: --- python/t/130-special.py | 28 1 file changed, 28 insertions(+) create mode 100755 python/t/130-special.py diff --git a/python/t/130-special.py b/python/t/130-special.py new file mode 100755

Re: [Libguestfs] [PATCH 6/7] python: Python 3 no longer recognizes long integers

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:51AM +0100, Hilko Bengen wrote: --- python/t/120-rlenvalue.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/t/120-rlenvalue.py b/python/t/120-rlenvalue.py index ebc48f5..a9b2129 100644 --- a/python/t/120-rlenvalue.py +++

Re: [Libguestfs] [PATCH 7/7] python: fix test runner so scripts are found when building out-of-tree

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:52AM +0100, Hilko Bengen wrote: --- python/run-python-tests.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/run-python-tests.in b/python/run-python-tests.in index 90aee03..0df646b 100755 --- a/python/run-python-tests.in +++

Re: [Libguestfs] [PATCH 3/3] ruby: Add test for special keys and values

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 01:07:13PM +0100, Hilko Bengen wrote: --- ruby/tests/tc_130_special.rb | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 ruby/tests/tc_130_special.rb diff --git a/ruby/tests/tc_130_special.rb b/ruby/tests/tc_130_special.rb

Re: [Libguestfs] [Bug 1046905] New: RFE: add argument to virt-sysprep to disable individual default operations

2014-01-13 Thread Pino Toscano
On Friday 10 January 2014 10:09:19 Richard W.M. Jones wrote: On Thu, Jan 09, 2014 at 03:45:54PM +, Richard W.M. Jones wrote: On Thu, Jan 09, 2014 at 04:21:10PM +0100, Pino Toscano wrote: + and set_operations op_string = +let currentopset = + match (!operations) with

[Libguestfs] [PATCH] sysprep: add --operations

2014-01-13 Thread Pino Toscano
Add a new --operation parameter which, similarly to --enable, can be used to enable operations, but also to remove them, and to add/remove the default operations and all the available ones. --- sysprep/main.ml | 36 +++ sysprep/sysprep_operation.ml | 24

Re: [Libguestfs] [PATCH] sysprep: add --operations

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 02:39:24PM +0100, Pino Toscano wrote: Add a new --operation parameter which, similarly to --enable, can be used to enable operations, but also to remove them, and to add/remove the default operations and all the available ones. --- sysprep/main.ml | 36

[Libguestfs] [PATCH] New API: copy-attributes.

2014-01-13 Thread Pino Toscano
This allows one to copy attributes (like permissions, xattrs, ownership) from a file to another. --- daemon/daemon.h | 3 + daemon/file.c | 72 ++ daemon/xattr.c | 69 + fish/Makefile.am| 1 + fish/test-file-attrs.sh

Re: [Libguestfs] [PATCH] New API: copy-attributes.

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 02:45:08PM +0100, Pino Toscano wrote: This allows one to copy attributes (like permissions, xattrs, ownership) from a file to another. --- daemon/daemon.h | 3 + daemon/file.c | 72 ++ daemon/xattr.c | 69

[Libguestfs] [PATCH 2/7 take 2] lib: Use vk-len for string conversion

2014-01-13 Thread Hilko Bengen
--- lib/value.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/value.c b/lib/value.c index 65404d7..7b2e9d3 100644 --- a/lib/value.c +++ b/lib/value.c @@ -207,14 +207,14 @@ hivex_value_key (hive_h *h, hive_value_h value) struct ntreg_vk_record *vk =

Re: [Libguestfs] [PATCH 2/7] lib: Use vk-len for string conversion

2014-01-13 Thread Hilko Bengen
* Richard W.M. Jones: On Mon, Jan 13, 2014 at 01:17:52PM +, Richard W.M. Jones wrote: Is there a reason for this patch? It seems like just an optimization. OK, I see that the reason is to avoid calling _hivex_utf8_strlen which would fail for the name containing a \0 character. However

Re: [Libguestfs] [PATCH 2/7 take 2] lib: Use vk-len for string conversion

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 04:53:25PM +0100, Hilko Bengen wrote: --- lib/value.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/value.c b/lib/value.c index 65404d7..7b2e9d3 100644 --- a/lib/value.c +++ b/lib/value.c @@ -207,14 +207,14 @@

Re: [Libguestfs] [PATCH 5/7] perl: Properly decode node names, value keys from UTF-8

2014-01-13 Thread Hilko Bengen
* Richard W.M. Jones: I wonder what happens if the registry contains a garbage string (one which is not valid utf-8)? This should not happen because libhivex passes those strings through iconv. Cheers, -Hilko ___ Libguestfs mailing list

Re: [Libguestfs] Livecd-creator is disabling selinux

2014-01-13 Thread Richard W.M. Jones
[Moving this to the libguestfs mailing list] On Mon, Jan 13, 2014 at 03:05:14PM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2014 11:49 AM, Richard W.M. Jones wrote: On Mon, Jan 13, 2014 at 10:20:22AM -0500, Daniel J Walsh wrote: Secondly we prevent