Re: [Libguestfs] [PATCH] tests/regressions: remove C part of rhbz1044014

2014-01-27 Thread Richard W.M. Jones
On Mon, Jan 27, 2014 at 05:32:30PM +0100, Pino Toscano wrote: > All it did was checking for a libvirt version, which is what > libvirt-is-version now does; hence remove the C part, and use guestfish, > ignoring the launch failure (as the C test did). Yep this looks fine, ACK. Rich. -- Richard J

[Libguestfs] [PATCH] tests/regressions: remove C part of rhbz1044014

2014-01-27 Thread Pino Toscano
All it did was checking for a libvirt version, which is what libvirt-is-version now does; hence remove the C part, and use guestfish, ignoring the launch failure (as the C test did). --- .gitignore | 1 - tests/regressions/Makefile.am| 21 tests/regressions/

Re: [Libguestfs] [PATCH 2/2] tests/disks: skip test-qemu-drive-libvirt.sh if libvirt is < 1.1.3

2014-01-27 Thread Richard W.M. Jones
Can you put the tool into the directory where it is used? Or into some other directory which isn't a new subdirectory of tests/? (Maybe src/?) All the existing tests/ subdirectories are actual tests. Apart from that, looks sensible. Rich. -- Richard Jones, Virtualization Group, Red Hat http:

Re: [Libguestfs] [PATCH INCOMPLETE] Rewrite virt-make-fs in C (originally Perl).

2014-01-27 Thread Richard W.M. Jones
On Mon, Jan 27, 2014 at 03:09:03PM +0100, Pino Toscano wrote: > Reading this and other similar implementations, for example: > - fish/events.c, do_event_handler > - fish/fish.c, execute_and_inline and issue_command (which has a comment > regarding pipe commands) > - src/command.c, run_command > -

Re: [Libguestfs] [PATCH INCOMPLETE] Rewrite virt-make-fs in C (originally Perl).

2014-01-27 Thread Pino Toscano
On Monday 27 January 2014 13:29:54 Richard W.M. Jones wrote: > +/* Execute a command, sending output to a file. */ > +static int > +exec_command (char **argv, const char *file, int stderr_to_file) > +{ > + pid_t pid; > + int status, fd; > + FILE *fp; > + char line[256]; > + > + pid = fork ();

[Libguestfs] [PATCH 2/2] tests/disks: skip test-qemu-drive-libvirt.sh if libvirt is < 1.1.3

2014-01-27 Thread Pino Toscano
This test relies on the element in the domain XML, which has been introduced in libvirt 1.1.3. --- tests/disks/test-qemu-drive-libvirt.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/disks/test-qemu-drive-libvirt.sh b/tests/disks/test-qemu-drive-libvirt.sh index e85c249.

[Libguestfs] [PATCH 1/2] tests: add a a simple libvirt-is-version test tool

2014-01-27 Thread Pino Toscano
libvirt-is-version returns successfully in case the available version of libvirt is greater or equal than the specified major/minor/release values. --- .gitignore | 1 + Makefile.am| 1 + configure.ac | 1 + tests/libvirt/Mak

[Libguestfs] [PATCH 0/2] Skip test-qemu-drive-libvirt.sh if libvirt is < 1.1.3

2014-01-27 Thread Pino Toscano
Hi, test-qemu-drive-libvirt.sh fails to run with libvirt < 1.1.3, because the attribute (used to keep the domains shut off) has been introduced in that libvirt version. Create a small (uninstalled) C tool which just does this version check, to be used in all the tests (just one, so far) written

Re: [Libguestfs] [PATCH] tests/mountable: add missing space in test-mountable-inspect.sh

2014-01-27 Thread Richard W.M. Jones
On Mon, Jan 27, 2014 at 02:27:12PM +0100, Pino Toscano wrote: > No actual behaviour, other than getting rid of a bash warning. > --- > tests/mountable/test-mountable-inspect.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/mountable/test-mountable-inspect.sh > b/

[Libguestfs] [PATCH INCOMPLETE] Rewrite virt-make-fs in C (originally Perl).

2014-01-27 Thread Richard W.M. Jones
I thought it would be easy to rewrite virt-make-fs in C. Two days later ... The Perl program uses a lot of external commands, which makes it pretty tedious to implement in C. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.co

[Libguestfs] [PATCH] tests/mountable: add missing space in test-mountable-inspect.sh

2014-01-27 Thread Pino Toscano
No actual behaviour, other than getting rid of a bash warning. --- tests/mountable/test-mountable-inspect.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/mountable/test-mountable-inspect.sh b/tests/mountable/test-mountable-inspect.sh index 906263b..10d1e9f 100755 ---

Re: [Libguestfs] [RESOLVED] symbol lookup error: /lib64/libgnutls.so.28 - undefined symbol: nettle_secp_256r1

2014-01-27 Thread Kashyap Chamarthy
On 01/27/2014 03:10 PM, Richard W.M. Jones wrote: > On Mon, Jan 27, 2014 at 10:27:20AM +0100, Pino Toscano wrote: >> On Monday 27 January 2014 11:06:14 Kashyap Chamarthy wrote: >>> Running virt-builder in a guest Fedora-20 guest hypervisor w/ Rawhide >>> Kernel, throws the below: >>> >>> $ virt-b

Re: [Libguestfs] Errors Running on Ubuntu 13.10

2014-01-27 Thread Richard W.M. Jones
This fails in the same way, which suggests something other than qemu is at fault. You could try a different kernel. http://libguestfs.org/guestfs.3.html#environment-variables Also make sure you are not running out of some resource, such as memory, disk, etc (see previous email). Rich. -- Ric

Re: [Libguestfs] [virt-builder] symbol lookup error: /lib64/libgnutls.so.28 - undefined symbol: nettle_secp_256r1

2014-01-27 Thread Richard W.M. Jones
On Mon, Jan 27, 2014 at 10:27:20AM +0100, Pino Toscano wrote: > On Monday 27 January 2014 11:06:14 Kashyap Chamarthy wrote: > > Running virt-builder in a guest Fedora-20 guest hypervisor w/ Rawhide > > Kernel, throws the below: > > > > $ virt-builder fedora-20 --format qcow2 --size 20G > > vir

Re: [Libguestfs] [virt-builder] symbol lookup error: /lib64/libgnutls.so.28 - undefined symbol: nettle_secp_256r1

2014-01-27 Thread Pino Toscano
On Monday 27 January 2014 11:06:14 Kashyap Chamarthy wrote: > Running virt-builder in a guest Fedora-20 guest hypervisor w/ Rawhide > Kernel, throws the below: > > $ virt-builder fedora-20 --format qcow2 --size 20G > virt-builder: symbol lookup error: /lib64/libgnutls.so.28: undefined > symbol