Re: [Libguestfs] [PATCH] fish: use XDG paths for the config file

On Mon, Feb 17, 2014 at 06:52:47PM +0100, Pino Toscano wrote: > Read the configuration file from XDG paths for both global and > user-local locations, keeping the old paths as fallback. Horrible, but yes ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones

[Libguestfs] [PATCH] fish: use XDG paths for the config file

Read the configuration file from XDG paths for both global and user-local locations, keeping the old paths as fallback. --- fish/config.c | 68 ++ fish/guestfish.pod | 9 -- fish/libguestfs-tools.conf.pod | 52 ++

Re: [Libguestfs] [PATCH 2/2] fish: change order of config files being read

On Mon, Feb 17, 2014 at 05:23:11PM +0100, Pino Toscano wrote: > First read the global configuration and then the local one in user's > HOME, so the latter can really override system settings. > --- > fish/config.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/fis

[Libguestfs] [PATCH 1/2] fish: small refactor of config reading code

Even though so far there is just one possible setting to read, isolate in an own function the code to parse a configuration file and read the settings out of it. Now there's a new config_t handle used every time, but since config_read would reset an handle completely, there is no behaviour change.

[Libguestfs] [PATCH 2/2] fish: change order of config files being read

First read the global configuration and then the local one in user's HOME, so the latter can really override system settings. --- fish/config.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fish/config.c b/fish/config.c index 02d850b..9e5da87 100644 --- a/fish/config.c

Re: [Libguestfs] Libguestfs (1.22.6) driver/changes for mingw/win32

Here is an initial review. > diff --git a/src/actions-support.c b/src/actions-support.c > index c3bd863..2c2d927 100644 > --- a/src/actions-support.c > +++ b/src/actions-support.c > @@ -81,7 +81,11 @@ guestfs___trace_open (struct trace_buffer *tb) > { >tb->buf = NULL; >tb->len = 0; > +#if

Re: [Libguestfs] Libguestfs (1.22.6) driver/changes for mingw/win32

On Mon, Feb 17, 2014 at 01:53:02PM +, Richard W.M. Jones wrote: > On Thu, Feb 13, 2014 at 04:54:09PM +0200, Or Goshen wrote: > > Hi, > > > > I attached the changes I made to a vanilla libguestfs-1.22.6 in order to > > make it work in mingw/win32. > > Added is also the patch required to make QE

Re: [Libguestfs] Handling different architectures in virt-builder

On Mon, Feb 17, 2014 at 01:32:48PM +0100, Pino Toscano wrote: > On Friday 14 February 2014 16:19:39 Richard W.M. Jones wrote: > > On Fri, Feb 14, 2014 at 03:48:34PM +0100, Pino Toscano wrote: > > > a) adding arch=.. keys in entries > > > b) rename (or just copy, to avoid breaking older virt-builder

Re: [Libguestfs] Handling different architectures in virt-builder

On Mon, Feb 17, 2014 at 01:29:39PM +0100, Pino Toscano wrote: > On Friday 14 February 2014 16:08:10 Richard W.M. Jones wrote: > > If aarch64 becomes popular, then: > > > > virt-builder fedora-20 > > > > should build an aarch64 image. Reason: building an x86-64 image isn't > > very useful, beca

Re: [Libguestfs] Handling different architectures in virt-builder

On Friday 14 February 2014 16:19:39 Richard W.M. Jones wrote: > On Fri, Feb 14, 2014 at 03:48:34PM +0100, Pino Toscano wrote: > > a) adding arch=.. keys in entries > > b) rename (or just copy, to avoid breaking older virt-builders) keys > > to> > >$distro-$version-$arch > > > > c) to not brea

Re: [Libguestfs] Handling different architectures in virt-builder

On Friday 14 February 2014 16:08:10 Richard W.M. Jones wrote: > On Fri, Feb 14, 2014 at 03:48:34PM +0100, Pino Toscano wrote: > > Hi, > > > > currently virt-builder's index contains only x86_64/amd64 images, so > > asking virt-builder to produce an image always produce a x86_64 > > image, regardle

Re: [Libguestfs] [PATCH] builder: add index-struct.h as dependency for index-parser-c.c

On Sunday 16 February 2014 22:32:52 Richard W.M. Jones wrote: > BTW, although there is nothing wrong with this patch, it doesn't seem > to completely resolve the problem. It looks like there could be > another missing dependency. > > When I did: > > make distclean && ./configure && make -j5 >

[Libguestfs] [PATCH v2] builder: Fix dependencies which are not generated correctly by automake.

See the error messages here: https://www.redhat.com/archives/libguestfs/2014-February/msg00148.html This fixes commit e2cc8b6465a400024fe2f0fcce0d0ff5f7e7719c. --- builder/Makefile.am | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/builder/Makefile.am b/builder/Make

[Libguestfs] [Resolved] Re: Debugging nested KVM guest (L2) booting with libguestfs/gdb

On Thu, Feb 13, 2014 at 09:52:15AM +, Richard W.M. Jones wrote: > On Thu, Feb 13, 2014 at 12:08:37AM +0530, Kashyap Chamarthy wrote: > > The 'qemu-kvm' command-line just hung at: > > > > $ ./run libguestfs-test-tool > > [. . .] > > -chardev > > socket,path=/home/tuser1/src/lib

Re: [Libguestfs] [PATCH] builder: Really add extra dependencies on index-parse.h that automake doesn't generate correctly.

On Mon, Feb 17, 2014 at 09:17:02AM +, Richard W.M. Jones wrote: > See: > https://www.redhat.com/archives/libguestfs/2014-February/msg00148.html > > This updates commit e2cc8b6465a400024fe2f0fcce0d0ff5f7e7719c. This commit is wrong. Coming up with a better commit ... Rich. -- Richard Jones

[Libguestfs] [PATCH] builder: Really add extra dependencies on index-parse.h that automake doesn't generate correctly.

See: https://www.redhat.com/archives/libguestfs/2014-February/msg00148.html This updates commit e2cc8b6465a400024fe2f0fcce0d0ff5f7e7719c. Also use $(OBJECT) instead of hard-coding the .o extension. --- builder/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/