Re: [Libguestfs] [PATCH] ext: change e2fsck retcode processing during resize

2016-06-22 Thread Richard W.M. Jones
On Wed, Jun 22, 2016 at 04:43:13PM +0300, Maxim Perevedentsev wrote: > e2fsck returns 1 in case of "file system errors corrected". > We treat it as success in normal e2fsck, but fail if e2fsck > is run by resize2fs. > > Change 'manual' execution of e2fsck to dedicated function call. > --- >

[Libguestfs] [PATCH 1/2] v2v: Fix conversion of floppy removable devices (RHBZ#1309706).

2016-06-22 Thread Richard W.M. Jones
The previous code treated floppy disks and CD-ROMs as the same kind of thing, resulting in malformed libvirt XML. You would see the following error when importing a guest into libvirt: error: Failed to define domain from /tmp/v2vlibvirt063486.xml error: internal error: Invalid floppy device

[Libguestfs] [PATCH 2/2] v2v: Add a regression test for floppy assignment (RHBZ#1309706).

2016-06-22 Thread Richard W.M. Jones
--- v2v/Makefile.am | 4 +++ v2v/test-v2v-floppy.expected | 8 + v2v/test-v2v-floppy.sh | 77 v2v/test-v2v-floppy.xml | 42 4 files changed, 131 insertions(+) create mode 100644

[Libguestfs] [PATCH] ext: change e2fsck retcode processing during resize

2016-06-22 Thread Maxim Perevedentsev
e2fsck returns 1 in case of "file system errors corrected". We treat it as success in normal e2fsck, but fail if e2fsck is run by resize2fs. Change 'manual' execution of e2fsck to dedicated function call. --- daemon/ext2.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-)

Re: [Libguestfs] [PATCH v3 1/4] p2v: use yast2 lan on SUSE distros rather than NM

2016-06-22 Thread Richard W.M. Jones
On Wed, Jun 22, 2016 at 02:02:27PM +0200, Cédric Bosdonnat wrote: > NetworkManager isn't provided on SLES. As yast2 lan is available on all > openSUSE / SLE distro, use it instead. > --- > p2v/gui.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/p2v/gui.c

[Libguestfs] [PATCH v3 2/4] p2v: fix dependencies for SLES / openSUSE

2016-06-22 Thread Cédric Bosdonnat
Use the common denominator for SLES and openSUSE in the dependencies. For example most of NetworkManager pieces and metacity aren't provided on SLES. ifconfig is in the net-tools-deprecated package in openSUSE Factory, which means after openSUSE Leap 42.2. Older versions have it in the net-tools

[Libguestfs] [PATCH v3 4/4] p2v: add -x option to nm-online

2016-06-22 Thread Cédric Bosdonnat
On distros not running NetworkManager, use the nm-online -x parameter to exit quickly. The network connection will be checked just after anyway when attempting to connect to the conversion server using ssh. --- p2v/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Libguestfs] [PATCH v3 3/4] p2v: add virt-p2v-make-kiwi to generate kiwi config

2016-06-22 Thread Cédric Bosdonnat
Kiwi is the tool used by openSUSE / SLES to generate many sort of disk images. Add a virt-p2v-make-kiwi tool and his documentation to geneate the p2v appliance kiwi configuration. --- .gitignore | 3 + configure.ac | 2 + p2v/Makefile.am| 31 +-

[Libguestfs] [PATCH v3 1/4] p2v: use yast2 lan on SUSE distros rather than NM

2016-06-22 Thread Cédric Bosdonnat
NetworkManager isn't provided on SLES. As yast2 lan is available on all openSUSE / SLE distro, use it instead. --- p2v/gui.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index e720002..f8605a3 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -654,7

[Libguestfs] [PATCH v3 0/4] virt-p2v support for openSUSE / SLES

2016-06-22 Thread Cédric Bosdonnat
Diff to v2: * remove leftover variable declaration in gui.c Cédric Bosdonnat (4): p2v: use yast2 lan on SUSE distros rather than NM p2v: fix dependencies for SLES / openSUSE p2v: add virt-p2v-make-kiwi to generate kiwi config p2v: add -x option to nm-online .gitignore

[Libguestfs] [PATCH v2 4/4] p2v: add -x option to nm-online

2016-06-22 Thread Cédric Bosdonnat
On distros not running NetworkManager, use the nm-online -x parameter to exit quickly. The network connection will be checked just after anyway when attempting to connect to the conversion server using ssh. --- p2v/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Libguestfs] [PATCH v2 3/4] p2v: add virt-p2v-make-kiwi to generate kiwi config

2016-06-22 Thread Cédric Bosdonnat
Kiwi is the tool used by openSUSE / SLES to generate many sort of disk images. Add a virt-p2v-make-kiwi tool and his documentation to geneate the p2v appliance kiwi configuration. --- .gitignore | 3 + configure.ac | 2 + p2v/Makefile.am| 31 +-

[Libguestfs] [PATCH v2 2/4] p2v: fix dependencies for SLES / openSUSE

2016-06-22 Thread Cédric Bosdonnat
Use the common denominator for SLES and openSUSE in the dependencies. For example most of NetworkManager pieces and metacity aren't provided on SLES. ifconfig is in the net-tools-deprecated package in openSUSE Factory, which means after openSUSE Leap 42.2. Older versions have it in the net-tools

[Libguestfs] [PATCH v2 0/4] virt-p2v support for openSUSE / SLES

2016-06-22 Thread Cédric Bosdonnat
Diff to v1: * Use access rather than stat in gui.c * Remove now uneeded and missplaced include for stat.h Cédric Bosdonnat (4): p2v: use yast2 lan on SUSE distros rather than NM p2v: fix dependencies for SLES / openSUSE p2v: add virt-p2v-make-kiwi to generate kiwi config p2v: add -x

[Libguestfs] [PATCH v2 1/4] p2v: use yast2 lan on SUSE distros rather than NM

2016-06-22 Thread Cédric Bosdonnat
NetworkManager isn't provided on SLES. As yast2 lan is available on all openSUSE / SLE distro, use it instead. --- p2v/gui.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index e720002..58a68ec 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -654,7

Re: [Libguestfs] [PATCH 1/4] p2v: use yast2 lan on SUSE distros rather than NM

2016-06-22 Thread Cedric Bosdonnat
On Wed, 2016-06-22 at 10:58 +0100, Richard W.M. Jones wrote: > On Wed, Jun 22, 2016 at 11:45:32AM +0200, Cédric Bosdonnat wrote: > > NetworkManager isn't provided on SLES. As yast2 lan is available on > > all > > openSUSE / SLE distro, use it instead. > > --- > > p2v/gui.c | 7 ++- > > 1 file

Re: [Libguestfs] [PATCH 1/4] p2v: use yast2 lan on SUSE distros rather than NM

2016-06-22 Thread Richard W.M. Jones
On Wed, Jun 22, 2016 at 11:45:32AM +0200, Cédric Bosdonnat wrote: > NetworkManager isn't provided on SLES. As yast2 lan is available on all > openSUSE / SLE distro, use it instead. > --- > p2v/gui.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/p2v/gui.c

Re: [Libguestfs] [PATCH 2/4] p2v: fix dependencies for SLES / openSUSE

2016-06-22 Thread Richard W.M. Jones
On Wed, Jun 22, 2016 at 11:45:33AM +0200, Cédric Bosdonnat wrote: > Use the common denominator for SLES and openSUSE in the dependencies. > For example most of NetworkManager pieces and metacity aren't provided > on SLES. > > ifconfig is in the net-tools-deprecated package in openSUSE Factory, >

[Libguestfs] [PATCH 0/4] virt-p2v support for openSUSE / SLES

2016-06-22 Thread Cédric Bosdonnat
Hi there, Here are a few patches to get virt-p2v working on openSUSE and SLES. Note that I intentionnaly use icewm and yast2 lan for SLES and openSUSE since SLES doesn't ship metacity and all of NetworkManager pieces. Cédric Bosdonnat (4): p2v: use yast2 lan on SUSE distros rather than NM

[Libguestfs] [PATCH 3/4] p2v: add virt-p2v-make-kiwi to generate kiwi config

2016-06-22 Thread Cédric Bosdonnat
Kiwi is the tool used by openSUSE / SLES to generate many sort of disk images. Add a virt-p2v-make-kiwi tool and his documentation to geneate the p2v appliance kiwi configuration. --- .gitignore | 3 + configure.ac | 2 + p2v/Makefile.am| 31 +-

[Libguestfs] [PATCH 2/4] p2v: fix dependencies for SLES / openSUSE

2016-06-22 Thread Cédric Bosdonnat
Use the common denominator for SLES and openSUSE in the dependencies. For example most of NetworkManager pieces and metacity aren't provided on SLES. ifconfig is in the net-tools-deprecated package in openSUSE Factory, which means after openSUSE Leap 42.2. Older versions have it in the net-tools

[Libguestfs] [PATCH 1/4] p2v: use yast2 lan on SUSE distros rather than NM

2016-06-22 Thread Cédric Bosdonnat
NetworkManager isn't provided on SLES. As yast2 lan is available on all openSUSE / SLE distro, use it instead. --- p2v/gui.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index e720002..b50cadf 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -51,6 +51,7

[Libguestfs] [PATCH 4/4] p2v: add -x option to nm-online

2016-06-22 Thread Cédric Bosdonnat
On distros not running NetworkManager, use the nm-online -x parameter to exit quickly. The network connection will be checked just after anyway when attempting to connect to the conversion server using ssh. --- p2v/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Libguestfs] [libvirt-users] virt-sparsify changing the apparent-size of files

2016-06-22 Thread Richard W.M. Jones
On Wed, Jun 22, 2016 at 12:40:40AM -0500, libvirt_us...@skagitattic.com wrote: > So you are saying when I do the virt-sparsify its converting the image > from raw to [qcow2]? No. virt-sparsify will use the same input and output formats, unless you use the --convert option. > I studied the man

Re: [Libguestfs] [libvirt-users] virt-sparsify changing the apparent-size of files

2016-06-22 Thread libvirt_users
Hello Rich, Thanks for the reply and information. > What is file.img? Its simply a file I made while testing sparse files "truncate -s 512M file.img". > 'du --apparent-size' and 'ls -l' are the same thing, so it's not > really surprising that you see the same numbers here. Indeed, I expected