Re: [Libguestfs] [PATCH] appliance: mount also /dev/pts

2016-12-06 Thread Richard W.M. Jones
On Tue, Dec 06, 2016 at 06:10:23PM +0100, Pino Toscano wrote: > Tools could require the use of pseudo-terminals, so make sure we have > /dev/pts available in the appliance. The "command" API already > bind-mounts it when running commands, so this is the only bit needed. > --- > appliance/init |

[Libguestfs] [PATCH] appliance: mount also /dev/pts

2016-12-06 Thread Pino Toscano
Tools could require the use of pseudo-terminals, so make sure we have /dev/pts available in the appliance. The "command" API already bind-mounts it when running commands, so this is the only bit needed. --- appliance/init | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appliance/init

Re: [Libguestfs] [PATCH v2] v2v: -o vdsm: Add --vdsm-compat-11 flag, -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).

2016-12-06 Thread Pino Toscano
On Thursday, 1 December 2016 13:22:48 CET Richard W.M. Jones wrote: > Support for RHEV with RHEL 6 nodes required us to output the old style > qcow2 compat=0.10 images. Since RHEV 3.6 GA, RHEL 6 has not been > supported as a RHEV node type. Since RHV 4.1, compat=1.1 is supported. > > Support

Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.

2016-12-06 Thread Pino Toscano
On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > You can now use -o rhv (-o rhev is supported for compatibility). This LGTM -- the only concern is that "output:rhev" will disappear from the machine-readable output (and thus potentially breaking users). I have PoC for handling

[Libguestfs] [PATCH 3/5] daemon: debug: new "exists" subcommand

2016-12-06 Thread Pino Toscano
Easy way to check whether a file in the appliance exists. --- daemon/debug.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/daemon/debug.c b/daemon/debug.c index c646be7..2193fe6 100644 --- a/daemon/debug.c +++ b/daemon/debug.c @@ -67,6 +67,7 @@

[Libguestfs] [PATCH 2/5] inspect: mark CoreOS /usr partitions with own USR role

2016-12-06 Thread Pino Toscano
Add a new inspect role for "/usr" partitions, and use that to mark the /usr partition in CoreOS: this additional role allows to ease its lookup later on, when merging its results into those of the root. --- src/guestfs-internal.h | 1 + src/inspect-fs-unix.c | 1 + src/inspect.c | 2 +-

[Libguestfs] [PATCH 5/5] inspect: gather info from /usr filesystems as well (RHBZ#1401474)

2016-12-06 Thread Pino Toscano
Flag the filesystems for Linux /usr properly as USR role, and detect some data out of it, like the distro information from an os-release (if present), and the architecture (since the binaries used for our architecture check will be available there only). Later on, collect the results in a way

[Libguestfs] [PATCH 0/5] Improve inspection of /usr filesystems

2016-12-06 Thread Pino Toscano
Hi, this patch series improves the way /usr filesystems are handled: tag them appropriately, so later on we can find them and merge results they contain directly back for the root filesystem. The series includes also a new private debug API, and its usage to fix the resolution of /dev/mapper/..

[Libguestfs] [PATCH 4/5] inspect: fix existance check of /dev/mapper devices

2016-12-06 Thread Pino Toscano
When checking for the existance of /dev/mapper devices found in the fstab of a filesystem, using guestfs_exists means they are checked as files in the guest, while they really appear as devices on the appliance. Resort using a debug API to check whether a file in the appliance exists, instead.

Re: [Libguestfs] [PATCH v2 5/5] v2v: update tests to match changes in OVA import

2016-12-06 Thread Tomas Golembiovsky
On Wed, Nov 30, 2016 at 4:44 PM, Pino Toscano wrote: > On Wednesday, 23 November 2016 16:40:59 CET Tomáš Golembiovský wrote: > > On Mon, 21 Nov 2016 16:41:49 +0100 > > Pino Toscano wrote: > > > On Saturday, 12 November 2016 16:37:53 CET Tomáš

[Libguestfs] [PATCH 2/2] inspect: Fix inspection of arch with separate /usr & UsrMove (RHBZ#1401474).

2016-12-06 Thread Richard W.M. Jones
--- src/inspect-fs-unix.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index 0fea9c8..b2c5ce1 100644 --- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -455,6 +455,7 @@

[Libguestfs] [PATCH 1/2] inspect: fstab: Canonicalize paths appearing in fstab.

2016-12-06 Thread Richard W.M. Jones
For example, converts "///usr//local//" -> "/usr/local". --- src/inspect-fs-unix.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index a1a757c..0fea9c8 100644 --- a/src/inspect-fs-unix.c +++