Re: [Libguestfs] [PATCH 2/5] mllib: factorize code to add Checksum.get_checksum function

2017-01-04 Thread Pino Toscano
On Tuesday, 3 January 2017 11:18:53 CET Cédric Bosdonnat wrote: > Getting checksum involves the same code than verifying them. Create > a get_checksum function and use it in verify_checksum. > --- The idea is good, although there are few issues: - you need to rebase the patch on master, since

Re: [Libguestfs] [PATCH 5/5] Add a virt-builder-repository tool

2017-01-04 Thread Pino Toscano
On Tuesday, 3 January 2017 11:18:56 CET Cédric Bosdonnat wrote: > virt-builder-repository allows users to easily create or update > a virt-builder source repository out of disk images. The tool can > be run in either interactive or automated mode. > --- Lots of code to review, so this is not an

Re: [Libguestfs] [PATCH 4/5] mllib: add libosinfo DB reading helpers

2017-01-04 Thread Pino Toscano
On Tuesday, 3 January 2017 11:18:55 CET Cédric Bosdonnat wrote: > There is already a libosinfo reading function located in src folder to > get the iso informations. Provide a similar but more generic function > to be used in ocaml tools. > --- I'd rather avoid duplicating the logic used for

Re: [Libguestfs] [PATCH v4 0/6] Import directly from OVA tar archive if possible

2017-01-04 Thread Pino Toscano
Hi Tomáš, On Sunday, 18 December 2016 23:16:27 CET Tomáš Golembiovský wrote: > Tomáš Golembiovský (6): > mllib: compute checksum of file inside tar > v2v: ova: move the untar function > tests: rename guestfs-hashsums.sh to test-utils.sh These patches look simple and OK to me, so I have

Re: [Libguestfs] [PATCH v4 6/6] v2v: ova: don't extract files from OVA if it's not needed

2017-01-04 Thread Pino Toscano
On Sunday, 18 December 2016 23:16:33 CET Tomáš Golembiovský wrote: > We don't have to always extract all files from the OVA archive. The OVA, > as defined in the standard, is plain tar. We can work directly over the > tar archive if we use correct 'offset' and 'size' options when defining > the

Re: [Libguestfs] [PATCH v3 2/6] v2v: ova: don't detect compressed disks, read the OVF instead

2017-01-04 Thread Pino Toscano
On Saturday, 10 December 2016 13:50:08 CET Tomas Golembiovsky wrote: > On Fri, 09 Dec 2016 14:01:40 +0100 > Pino Toscano wrote: > > > On Wednesday, 7 December 2016 17:13:06 CET Tomáš Golembiovský wrote: > > > The information whether the disk is gzip compressed or not is