Re: [Libguestfs] [PATCH] ocaml: make sure to pass LDFLAGS to ocamlmklibs linker (RHBZ#1624130)

[Richard W.M. Jones]

On Thu, Sep 27, 2018 at 03:53:18PM +0200, Pino Toscano wrote:
> Pass the LDFLAGS properly as arguments for the C linker when using
> ocamlmklibs via the -ldopt option.
> 
> Followup of commit 34c23403c51a4d59d826c8045e06f9aabc2ceb16.
> ---
>  ocaml/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am
> index 752fc109c..4d13eed97 100644
> --- a/ocaml/Makefile.am
> +++ b/ocaml/Makefile.am
> @@ -64,14 +64,14 @@ endif
>  
>  stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm)
>   $(OCAMLMKLIB) -o mlguestfs \
> +   -ldopt '$(LDFLAGS)' \
> $(libguestfsocaml_a_OBJECTS) guestfs.cmo \
> -   $(LDFLAGS) \
> $(LTLIBINTL) \
> -L../lib/.libs -lguestfs
>  if HAVE_OCAMLOPT
>   $(OCAMLMKLIB) -o mlguestfs \
> +   -ldopt '$(LDFLAGS)' \
> $(libguestfsocaml_a_OBJECTS) guestfs.cmx \
> -   $(LDFLAGS) \
> $(LTLIBINTL) \
> -L../lib/.libs -lguestfs
>  endif

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH] ocaml: make sure to pass LDFLAGS to ocamlmklibs linker (RHBZ#1624130)

[Pino Toscano]

Pass the LDFLAGS properly as arguments for the C linker when using
ocamlmklibs via the -ldopt option.

Followup of commit 34c23403c51a4d59d826c8045e06f9aabc2ceb16.
---
 ocaml/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am
index 752fc109c..4d13eed97 100644
--- a/ocaml/Makefile.am
+++ b/ocaml/Makefile.am
@@ -64,14 +64,14 @@ endif
 
 stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm)
$(OCAMLMKLIB) -o mlguestfs \
+ -ldopt '$(LDFLAGS)' \
  $(libguestfsocaml_a_OBJECTS) guestfs.cmo \
- $(LDFLAGS) \
  $(LTLIBINTL) \
  -L../lib/.libs -lguestfs
 if HAVE_OCAMLOPT
$(OCAMLMKLIB) -o mlguestfs \
+ -ldopt '$(LDFLAGS)' \
  $(libguestfsocaml_a_OBJECTS) guestfs.cmx \
- $(LDFLAGS) \
  $(LTLIBINTL) \
  -L../lib/.libs -lguestfs
 endif
-- 
2.17.1

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] OpenStack output workflow

[Fabien Dupont]

Thanks Rich. I'll change the code for IMS 1.1. And I like more
and more that systemd thing.

On Wed, Sep 26, 2018 at 6:10 PM Richard W.M. Jones 
wrote:

> On Wed, Sep 26, 2018 at 04:57:19PM +0200, Fabien Dupont wrote:
> > It's not virt-v2v-wrapper that kills virt-v2v, it's ManageIQ. We have the
> > PID from virt-v2v-wrapper state file. What would be the preferred way
> > to interrupt it ?
>
> It's not too nice to send kill -9 to virt-v2v because it means none of
> the at-exit handlers get to run, so it will leave temporary files all
> over the place.  It's better to send an ordinary kill signal
> (eg. SIGTERM).  If virt-v2v doesn't exit after some grace period,
> eg. 30 seconds, then it's a bug, but maybe you could then send
> SIGKILL.
>
> This is actually another thing which a temporary systemd unit will
> solve for us:
> https://www.freedesktop.org/software/systemd/man/systemd.kill.html
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-top is 'top' for virtual machines.  Tiny program with many
> powerful monitoring features, net stats, disk stats, logging, etc.
> http://people.redhat.com/~rjones/virt-top
>


-- 

*Fabien Dupont*

PRINCIPAL SOFTWARE ENGINEER

Red Hat - Solutions Engineering

fab...@redhat.com M: +33 (0) 662 784 971 <+33662784971>

  *TRIED. TESTED. TRUSTED.*

Twitter: @redhatway  | Instagram: @redhatinc
 | Snapchat: @redhatsnaps
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs