Re: [Libguestfs] [v2v PATCH v2] output/create_libvirt_xml: relax VCPU feature checking for "qemu64"

2022-07-22 Thread Laszlo Ersek
On 07/22/22 11:35, Richard W.M. Jones wrote: > On Fri, Jul 22, 2022 at 09:36:27AM +0200, Laszlo Ersek wrote: >> When the source domain doesn't specify a VCPU model ("s_cpu_model" is >> None), and the guest OS is assumed to work with the default VCPU model >> ("gcaps_default_cpu" is true), we don't

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Richard W.M. Jones
On Fri, Jul 22, 2022 at 12:53:00PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 22, 2022 at 01:49:21PM +0200, Laszlo Ersek wrote: > > On 07/22/22 11:50, Richard W.M. Jones wrote: > > > On Fri, Jul 22, 2022 at 10:42:48AM +0100, Daniel P. Berrangé wrote: > > >> On Fri, Jul 22, 2022 at 10:34:44AM

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 01:49:21PM +0200, Laszlo Ersek wrote: > On 07/22/22 11:50, Richard W.M. Jones wrote: > > On Fri, Jul 22, 2022 at 10:42:48AM +0100, Daniel P. Berrangé wrote: > >> On Fri, Jul 22, 2022 at 10:34:44AM +0100, Richard W.M. Jones wrote: > >>> Sorry for the delayed response to

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Laszlo Ersek
On 07/22/22 11:50, Richard W.M. Jones wrote: > On Fri, Jul 22, 2022 at 10:42:48AM +0100, Daniel P. Berrangé wrote: >> On Fri, Jul 22, 2022 at 10:34:44AM +0100, Richard W.M. Jones wrote: >>> Sorry for the delayed response to this. I see you've posted an >>> updated patch, so this is just a bit of

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Richard W.M. Jones
On Fri, Jul 22, 2022 at 10:42:48AM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 22, 2022 at 10:34:44AM +0100, Richard W.M. Jones wrote: > > Sorry for the delayed response to this. I see you've posted an > > updated patch, so this is just a bit of FYI. > > > > I originally added CPU modelling

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 10:34:44AM +0100, Richard W.M. Jones wrote: > Sorry for the delayed response to this. I see you've posted an > updated patch, so this is just a bit of FYI. > > I originally added CPU modelling in commit 11505e4b84 (March 2017): > >

Re: [Libguestfs] [v2v PATCH v2] output/create_libvirt_xml: relax VCPU feature checking for "qemu64"

2022-07-22 Thread Richard W.M. Jones
On Fri, Jul 22, 2022 at 09:36:27AM +0200, Laszlo Ersek wrote: > When the source domain doesn't specify a VCPU model ("s_cpu_model" is > None), and the guest OS is assumed to work with the default VCPU model > ("gcaps_default_cpu" is true), we don't output any element. In that > case, libvirtd

Re: [Libguestfs] [v2v PATCH] output/create_libvirt_xml: generate @check='none' CPU attribute

2022-07-22 Thread Richard W.M. Jones
Sorry for the delayed response to this. I see you've posted an updated patch, so this is just a bit of FYI. I originally added CPU modelling in commit 11505e4b84 (March 2017): https://github.com/libguestfs/virt-v2v/commit/11505e4b84ce8d7eda4e2a275fdcecc5f2a3288d What we were actually trying to

[Libguestfs] [v2v PATCH v2] output/create_libvirt_xml: relax VCPU feature checking for "qemu64"

2022-07-22 Thread Laszlo Ersek
When the source domain doesn't specify a VCPU model ("s_cpu_model" is None), and the guest OS is assumed to work with the default VCPU model ("gcaps_default_cpu" is true), we don't output any element. In that case, libvirtd augments the domain config with: [1] qemu64 where the