Re: [Libguestfs] [libnbd PATCH 2/2] api: Test previous patch

2022-08-24 Thread Eric Blake
On Wed, Aug 24, 2022 at 02:49:27PM +0200, Laszlo Ersek wrote: > On 08/24/22 04:53, Eric Blake wrote: > > Add testsuite coverage that exposes the flaw fixed in the previous patch. > > > > --- > > tests/opt-info.c | 20 +--- > > 1 file changed, 13 insertions(+), 7 deletions(-) > >

Re: [Libguestfs] [libnbd PATCH 1/2] api: Better use of nbd_internal_reset_size_and_flags

2022-08-24 Thread Eric Blake
On Wed, Aug 24, 2022 at 01:56:03PM +0200, Laszlo Ersek wrote: > On 08/24/22 04:53, Eric Blake wrote: > > The documentation for nbd_internal_reset_size_and_flags() claims we > > should wipe all knowledge of previously-negotiated meta contexts when > > swapping export names. However, we weren't

Re: [Libguestfs] virt-p2v VM testing bitrot?

2022-08-24 Thread Richard W.M. Jones
On Wed, Aug 24, 2022 at 05:25:50PM +0200, Laszlo Ersek wrote: > On 08/24/22 16:13, Richard W.M. Jones wrote: > > On Wed, Aug 24, 2022 at 04:12:04PM +0200, Laszlo Ersek wrote: > >> I've started looking into RHBZ 1590721 for virt-p2v. > >> > >> For p2v development, quick local testing is helpful.

Re: [Libguestfs] virt-p2v VM testing bitrot?

2022-08-24 Thread Laszlo Ersek
On 08/24/22 16:13, Richard W.M. Jones wrote: > On Wed, Aug 24, 2022 at 04:12:04PM +0200, Laszlo Ersek wrote: >> I've started looking into RHBZ 1590721 for virt-p2v. >> >> For p2v development, quick local testing is helpful. "make >> run-virt-p2v-directly" seems to be working great; however, the

Re: [Libguestfs] virt-p2v VM testing bitrot?

2022-08-24 Thread Richard W.M. Jones
On Wed, Aug 24, 2022 at 04:12:04PM +0200, Laszlo Ersek wrote: > I've started looking into RHBZ 1590721 for virt-p2v. > > For p2v development, quick local testing is helpful. "make > run-virt-p2v-directly" seems to be working great; however, the VM-based > test methods seem to have developed

[Libguestfs] virt-p2v VM testing bitrot?

2022-08-24 Thread Laszlo Ersek
I've started looking into RHBZ 1590721 for virt-p2v. For p2v development, quick local testing is helpful. "make run-virt-p2v-directly" seems to be working great; however, the VM-based test methods seem to have developed problems, since I last looked. Namely: - "make run-virt-p2v-in-a-vm" boots

Re: [Libguestfs] [libnbd PATCH 2/2] api: Test previous patch

2022-08-24 Thread Laszlo Ersek
On 08/24/22 04:53, Eric Blake wrote: > Add testsuite coverage that exposes the flaw fixed in the previous patch. > > --- > tests/opt-info.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/tests/opt-info.c b/tests/opt-info.c > index b9739a5..2402a31

Re: [Libguestfs] [libnbd PATCH 1/2] api: Better use of nbd_internal_reset_size_and_flags

2022-08-24 Thread Laszlo Ersek
On 08/24/22 04:53, Eric Blake wrote: > The documentation for nbd_internal_reset_size_and_flags() claims we > should wipe all knowledge of previously-negotiated meta contexts when > swapping export names. However, we weren't actually doing that, which > could lead to a user calling nbd_opt_info()