Re: [Libguestfs] [PATCH] inspect: check presence of BIOS boot partition to handle BIOS+GPT setup

2022-12-20 Thread Andrey Drobyshev
On 12/20/22 11:51, Laszlo Ersek wrote: > On 12/19/22 23:16, Andrey Drobyshev wrote: > >> Now I'm a bit confused myself as a result of our discussion: should we >> really give priority to BIOS Boot partition? Because I tried to >> replay the opposite scenario -- i.e. to convert a disk previously

[Libguestfs] [V2V PATCH v5] parse_libvirt_xml: look for manual firmware in "/domain/os/loader/@type"

2022-12-20 Thread Andrey Drobyshev
According to [1], there're different ways to specify which firmware is to be used by a libvirt-driven VM. Namely, there's an automatic firmware selection, e.g.: ... ... and a manual one, e.g.: ... /usr/share/OVMF/OVMF_CODE.fd ... ... with the

Re: [Libguestfs] [V2V PATCH v4] parse_libvirt_xml: look for manual firmware in "/domain/os/loader/@type"

2022-12-20 Thread Andrey Drobyshev
On 12/20/22 12:07, Laszlo Ersek wrote: > Hi Andrey, > > On 12/19/22 19:59, Andrey Drobyshev wrote: >> According to [1], there're different ways to specify which firmware is >> to be used by a libvirt-driven VM. Namely, there's an automatic >> firmware selection, e.g.: >> >> ... >> >>

Re: [Libguestfs] [V2V PATCH v4] parse_libvirt_xml: look for manual firmware in "/domain/os/loader/@type"

2022-12-20 Thread Richard W.M. Jones
BTW I'm on holiday, and I'm quite happy to go with whatever Laszlo agrees with. He is also able to push it upstream. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder

Re: [Libguestfs] [V2V PATCH v4] parse_libvirt_xml: look for manual firmware in "/domain/os/loader/@type"

2022-12-20 Thread Laszlo Ersek
Hi Andrey, On 12/19/22 19:59, Andrey Drobyshev wrote: > According to [1], there're different ways to specify which firmware is > to be used by a libvirt-driven VM. Namely, there's an automatic > firmware selection, e.g.: > > ... > > ... > > and a manual one, e.g.: > > ... >

Re: [Libguestfs] [PATCH] inspect: check presence of BIOS boot partition to handle BIOS+GPT setup

2022-12-20 Thread Laszlo Ersek
On 12/19/22 23:16, Andrey Drobyshev wrote: > Now I'm a bit confused myself as a result of our discussion: should we > really give priority to BIOS Boot partition? Because I tried to > replay the opposite scenario -- i.e. to convert a disk previously used > by BIOS machine to be used by UEFI