Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Richard W.M. Jones
On Wed, Jan 11, 2023 at 10:52:01AM -0500, Stefan Hajnoczi wrote: > On Wed, Jan 04, 2023 at 06:14:34PM +, Richard W.M. Jones wrote: > > (1) There is no way to know which properties are readable, writable, > > and those which need to be set before or after blkio_connect (see > >

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Richard W.M. Jones
On Wed, Jan 11, 2023 at 11:34:50AM -0500, Stefan Hajnoczi wrote: > On Sat, Jan 07, 2023 at 07:44:37PM +, Richard W.M. Jones wrote: > > > > This is upstream in nbdkit now: > > https://gitlab.com/nbdkit/nbdkit/-/tree/master/plugins/blkio > > > > Another question: > > > > (6) vhost-user +

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Sat, Jan 07, 2023 at 07:44:37PM +, Richard W.M. Jones wrote: > > This is upstream in nbdkit now: > https://gitlab.com/nbdkit/nbdkit/-/tree/master/plugins/blkio > > Another question: > > (6) vhost-user + "read-only" property acts a bit strangely. After > opening virtio-blk-vhost-user it

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Wed, Jan 04, 2023 at 09:43:57PM +, Richard W.M. Jones wrote: > On Wed, Jan 04, 2023 at 06:14:34PM +, Richard W.M. Jones wrote: > > (3) It seems like some drivers require pre-allocated memory regions, > > and since some do that means we might as well implement this. It > > also seems

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Wed, Jan 04, 2023 at 07:01:24PM +, Richard W.M. Jones wrote: > (5) "The application is responsible for thread-safety. No thread > synchronization is necessary when a queue is only used from a single > thread. Proper synchronization is required when sharing a queue > between multiple

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Wed, Jan 04, 2023 at 06:14:34PM +, Richard W.M. Jones wrote: > This is an incomplete outline implementation for a libblkio plugin for > nbdkit. At the moment it only supports reading the same ("capacity") > of the device, and not even reading or writing. I have some questions > about the