Re: [Libguestfs] [PATCH v2v v2] -o rhv-upload: Improve error message for invalid or missing -os parameter

2023-01-28 Thread Nir Soffer
On Fri, Jan 27, 2023 at 2:26 PM Richard W.M. Jones wrote: > > For -o rhv-upload, the -os parameter specifies the storage domain. > Because the RHV API allows globs when searching for a domain, if you > used a parameter like -os 'data*' then this would confuse the Python > code, since it can glob

Re: [Libguestfs] [nbdkit PATCH 1/2] retry: Add in retry support during .open

2023-01-28 Thread Richard W.M. Jones
On Fri, Jan 27, 2023 at 02:41:22PM -0600, Eric Blake wrote: > Now that a filter can open a backend as many times as it wants, > there's no longer a technical reason we can't retry .open. However, > adding retry logic here does mean we have to weaken an assert in the > server backend code, since

[Libguestfs] [PATCH libnbd] generator: Pass LISTEN_FDNAMES=nbd with systemd socket activation

2023-01-28 Thread Richard W.M. Jones
systemd allows sockets passed through socket activation to be named with the protocol they require. We only ever pass one socket, name it. This environment variable is currently ignored by qemu-nbd and nbdkit, but might be used by qemu-storage-daemon: