On Thu, Jun 09, 2022 at 02:14:07PM +0100, Daniel P. Berrangé wrote:
> Setting GODEBUG=cgocheck=1 or GODEBUG=cgocheck=2 can sometimes
> get more info.
Took me a while to work out that we are actually setting that already
(in ./run) which explains a couple of things: why I couldn't reproduce
the
make[2]: Entering directory '/home/rjones/d/libnbd/golang'
perl /home/rjones/d/libnbd/podwrapper.pl --section=3 --man libnbd-golang.3 \
--html ../html/libnbd-golang.3.html \
libnbd-golang.pod
/home/rjones/d/libnbd/run go build
write of Go pointer 0x3fa8028000 to non-Go memory 0x3fd2c0fb20
On Thu, Jun 09, 2022 at 11:58:32AM +0200, Laszlo Ersek wrote:
> On 06/09/22 10:46, Richard W.M. Jones wrote:
> > On Thu, Jun 09, 2022 at 10:25:08AM +0200, Laszlo Ersek wrote:
> >> On 06/09/22 10:11, Richard W.M. Jones wrote:
> >>> On Thu, Jun 09, 2022 at 10:02:
On Thu, Jun 09, 2022 at 10:25:08AM +0200, Laszlo Ersek wrote:
> On 06/09/22 10:11, Richard W.M. Jones wrote:
> > On Thu, Jun 09, 2022 at 10:02:54AM +0200, Laszlo Ersek wrote:
> >> On 06/08/22 18:48, Richard W.M. Jones wrote:
> >>> When we split virt-v2v from libgu
On Thu, Jun 09, 2022 at 10:20:47AM +0200, Laszlo Ersek wrote:
> On 06/08/22 18:49, Richard W.M. Jones wrote:
> > As well as testing a full Fedora conversion which was not really
> > tested properly before, this also adds tests of conversions of Btrfs,
> > RAID and LUKS guest
On Thu, Jun 09, 2022 at 10:13:52AM +0200, Laszlo Ersek wrote:
> Looks OK to me, I just suggest using a different function name rather
> than "basename". While the C code is certainly OK, conceptually we
> already have two standard basename() functions, a POSIX compatible one
> from , and a glibc
On Thu, Jun 09, 2022 at 10:02:54AM +0200, Laszlo Ersek wrote:
> On 06/08/22 18:48, Richard W.M. Jones wrote:
> > When we split virt-v2v from libguestfs many moons ago, I copied the
> > test-data/ subdirectory over. I didn't modify it much, and it
> > contains much test da
On Wed, Jun 08, 2022 at 05:49:01PM +0100, Richard W.M. Jones wrote:
> +# Virt-v2v also needs a kernel, initrd and modules path.
> +$g->touch ("/boot/vmlinuz-$kver");
> +$g->touch ("/boot/initramfs-$kver.img");
> +$g->mkdir_p ("/lib/modules/$kver/kern
We didn't use the phony Fedora guest before with virt-v2v (only the
phony Windows image). This commit makes miscellaneous changes so that
it can be used for testing:
- Add dummy rpm and dracut commands.
- Add dummy kernel, initramfs and modules directory.
- Add dummy grub configuration
As well as testing a full Fedora conversion which was not really
tested properly before, this also adds tests of conversions of Btrfs,
RAID and LUKS guests.
---
tests/Makefile.am | 8 ++
tests/test-v2v-fedora-btrfs-conversion.sh | 31 +
When we split virt-v2v from libguestfs many moons ago, I copied the
test-data/ subdirectory over. I didn't modify it much, and it
contains much test data that is irrelevant to virt-v2v. (This change
does _not_ clean up any of that ...) However we did use the phony
Windows image
Avoid this error in virt-v2v when trying to convert the phony Fedora
guest image:
[ 8.1] Checking for sufficient free disk space in the guest
virt-v2v: error: not enough free space for conversion on filesystem
‘/’. 21.6 MB free < 100 MB needed
---
test-data/phony-guests/make-fedora-img.pl | 4
On Tue, Jun 07, 2022 at 01:59:30PM +0100, Richard W.M. Jones wrote:
> On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote:
> > +(* Disable SELinux temporarily around package installation.
> > Refer to
> > + * <https://bugzilla.redhat.com/sh
On Tue, Jun 07, 2022 at 08:53:23AM -0500, Eric Blake wrote:
> On Tue, Jun 07, 2022 at 09:00:08AM +0100, Richard W.M. Jones wrote:
> > On Mon, Jun 06, 2022 at 09:08:29PM -0500, Eric Blake wrote:
> > > + pr ":nbd_%s\",\n" name;
> >
> &
ect *ret = NULL;
>
>if (!PyArg_ParseTuple (args,
> - "Onn:nbd_internal_py_aio_buffer_is_zero",
> - , , ))
> + "y*nnp:nbd_internal_py_aio_buffer_is_zero",
> + ,
| n, Some default -> pr ", %s=%s" n default
>) args);
>pr "):\n";
>let longdesc = Str.global_replace py_fn_rex "C" longdesc in
> @@ -842,8 +842,7 @@ let
>pr "self._o";
>Li
rnal_py_get_aio_buffer (capsule);
> + struct py_aio_buffer *buf = nbd_internal_py_get_aio_buffer (object);
>
>assert (buf);
>buf->initialized = true;
> diff --git a/python/utils.c b/python/utils.c
> index 37f0c55..e0df181 100644
> --- a/python/utils.c
> +++ b/python/utils.
->len);\n" n n;
> - pr "%s_buf->initialized = true;\n" n;
> - pr " }\n"
> | BytesPersistOut (n, _) ->
> - pr " %s_buf->initialized = true;\n" n
> + pr " if (nbd_internal_py_init_aio_buffer (%s) < 0) goto ou
t/510-aio-pwrite.py b/python/t/510-aio-pwrite.py
> index 89599fc..d09e249 100644
> --- a/python/t/510-aio-pwrite.py
> +++ b/python/t/510-aio-pwrite.py
> @@ -45,6 +45,12 @@ while not h.aio_command_completed(cookie):
>
> assert buf == buf2.to_bytearray()
>
> +# Check t
ot;;
> "aio_buffer_size";
> - "aio_buffer_is_zero" ] @ List.map fst handle_calls);
> + "aio_buffer_is_zero"] @ List.map fst handle_calls);
>pr " { NULL, NULL, 0, NULL }\n";
>pr "};\n";
>pr &
> @@ -855,7 +860,7 @@ let
>let longdesc = Str.global_replace py_fn_rex "C" longdesc in
>let longdesc = Str.global_replace py_const_rex "C<" longdesc in
>let longdesc = pod2text longdesc in
> - pr " '''▶ %s\n\n%s'''\n&q
This patch and the companion patch to libguestfs-common:
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines
On Tue, Jun 07, 2022 at 01:39:53PM +0100, Richard W.M. Jones wrote:
> OTOH ... my comment here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c2
>
> was about more social issues where we've not been able to put the
> qemu-ga RPMs on the ISO, and firstboot seemed li
On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote:
> Register a firstboot script, for installing the guest agent with the
> guest's own package manager -- that is, "Guest_packages.install_command".
>
> For installing the package, network connectivity is required; for lack of
> a
manual.")
> +| Some qga_pkg ->
> +let has_qemu_guest_agent =
> + List.exists (
> +fun { G.app2_name = name } ->
> + name = qga_pkg
> + ) inspect.i_apps in
> +if not has_qemu_guest_agent then
> +
I'm not a big fan of dead code/features, so we should probably just do
this regardless of any other changes, so:
Acked-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http
The patch looks OK, but qemu-ga supports vsock (-m listen-vsock), so
wouldn't it be easier to use that? I thought that virtio-serial was
unmaintained these days and so vsock would be preferred.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my
On Mon, Jun 06, 2022 at 04:19:37PM +0200, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2028764
>
> I'm going to post the pre-requisite libguestfs-common and guestfs-tools
> patches (one patch for each project) in response to this cover letter,
> too.
>
> I'm not
uldn't need to print
spaces to indent (because pr_wrap should do it for you).
It all looks sensible and equivalent to the old code, and the output
is cleaner too, so:
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my prog
On Fri, Jun 03, 2022 at 05:26:35PM -0500, Eric Blake wrote:
> After the work in the previous patch, this one is a trivial feature
> addition ;) Now you can do h.aio_pwrite(b'123', 0).
> ---
> python/handle.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/python/handle.c
turn PyObject_GetAttrString(buffer, "_o");
>
> + if (PyObject_CheckBuffer (buffer)) {
> +Py_INCREF (buffer);
> +return buffer;
> + }
> +
>PyErr_SetString (PyExc_TypeError,
> "aio_buffer: expecting nbd.Buffer instance");
>r
))
> -return NULL;
> -
> - buf = nbd_internal_py_get_aio_buffer (obj);
> - if (buf == NULL)
> -return NULL;
> -
> - return PyByteArray_FromStringAndSize (buf->data, buf->len);
> -}
> -
> -PyObject *
> -nbd_internal_py_a
gt;List.iter (
> function
> -| n, None, _ -> pr ", %s" n
> -| n, Some default, _ -> pr ", %s=%s" n default
> +| n, None -> pr ", %s" n
> +| n, Some default -> pr ", %s
PyObject *capsule = PyObject_GetAttrString(buffer, "_o");
> + return PyCapsule_GetPointer (capsule, aio_buffer_name);
> + }
> +
> + PyErr_SetString (PyExc_TypeError,
> + "aio_buffer: expecting nbd.Buffer instance");
> + return NULL;
nbd_internal_py_Error = PyErr_NewException (\"nbd.Error\", NULL, NULL);
> - if (nbd_internal_py_Error == NULL)
> + if (PyModule_AddObject (mod, \"Error\", nbd_internal_py_Error) < 0) {
> +Py_XDECREF (nbd_internal_py_Error);
> +Py_DECREF (mod);
> return NULL;
I agree with Nir's feedback and R-b's and don't have anything else to add.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.
On Tue, May 31, 2022 at 07:24:03PM -0500, Eric Blake wrote:
> On Wed, Jun 01, 2022 at 02:20:48AM +0300, Nir Soffer wrote:
> > Does this work?
> >
> > PySlice_New(NULL, NULL, NULL);
> > PySlice_AdjustIndices(length, start, stop, step);
>
> New in python 3.6.1. README says we still target
On Tue, May 31, 2022 at 10:52:35AM -0500, Eric Blake wrote:
> And I really wish python didn't make it so hard to grab a slice of
> another object using C code. Having to create 3 temporary PyObjects
> instead of having a utility C function that takes normal integers was
> annoying.
You can add
y-out.test2
> - download /linuxdisk/nbdkit-linuxdisk-plugin.pod linuxdisk-copy-out.test3
> - download /linuxdisk/filesystem.c linuxdisk-copy-out.test4
> + download /Makefile linuxdisk-copy-out.test1
> + download /Makefile.am linuxdisk-copy-out.test2
> + download /nbdkit-linuxdi
nit b/appliance/init
> index 7076821d2250..19aa151b73aa 100755
> --- a/appliance/init
> +++ b/appliance/init
> @@ -134,6 +134,17 @@ mdadm -As --auto=yes --no-degraded
> # Empty LVM configuration file means "all defaults".
> mkdir -p /tmp/lvm
> touch /tmp/lvm/lvm
On Mon, May 30, 2022 at 09:12:48AM +0100, Richard W.M. Jones wrote:
> > > git push -o ci.variable="LIBVIRT_CI_CONTAINERS=1"
>
> Let's see if this works:
>
> https://gitlab.com/nbdkit/libnbd/-/pipelines/550978621
That did in fact work.
The OpenSUSE Leap test faile
> > git push -o ci.variable="LIBVIRT_CI_CONTAINERS=1"
Let's see if this works:
https://gitlab.com/nbdkit/libnbd/-/pipelines/550978621
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
On Mon, May 30, 2022 at 09:25:11AM +0200, Martin Kletzander wrote:
> On Sun, May 29, 2022 at 11:22:05AM +0100, Richard W.M. Jones wrote:
> >
> >I added this commit and regenerated the CI files:
> >
> >https://gitlab.com/nbdkit/libnbd/-/commit/b6a98aacbe22d599f000d4
I added this commit and regenerated the CI files:
https://gitlab.com/nbdkit/libnbd/-/commit/b6a98aacbe22d599f000d4d1c84c27081ec06957
https://gitlab.com/nbdkit/libnbd/-/commit/2439fd5c7a07b314ce47728c6fbae16b9a26dcdb
However apparently gitlab CI cannot create the Fedora 36 & OpenSUSE
Leap 15.3
;
>
> Project nbdkit / libnbd
> Branch● master
> Commit● 2439fd5c
> ci: Update generated files With the latest lib...
> Commit Author ● Richard W.M. Jones
>
> Pipeline #550544496 triggered by ● Richard W.M. Jones
&g
set zeroes as they are read (and the user gets their
> + * own garbage back in the case of a non-compliant server).
> */
> + cmd->initialized = h->pread_initialize;
>
>/* Add the command to the end of the queue. Kick the state machine
> * if there is no other command being p
; n;
> + pr " %s = NULL;\n" n;
> use_ret := false
> | Bool _
> | BytesIn _
> @@ -572,7 +573,7 @@ let
> | BytesIn (n, _) ->
> pr " if (%s.obj)\n" n;
> pr "PyBuffer_Release (&%s);\n" n
&g
+os.unlink(witness)
> +
> +out = h.pread(16,0)
> +print(out)
> +t = end_t - start_t
> +print(t)
> +assert out in [b"4"*4 + b"3"*12, b"4"*16]
> +assert t >= 8
> +
> +# Next pass: try to kick off aligned first
> +print("aligned first"
On Thu, May 26, 2022 at 10:53:59AM +0200, Laszlo Ersek wrote:
> On 05/25/22 18:02, Richard W.M. Jones wrote:
> > In libguestfs we didn't bother to check the return values from any
> > librpm calls. In some cases where possibly the RPM database is
> > faulty, this caused us to
We always wanted "-cpu best", which means basically the CPU which
always works best (NB: I used the both words "works" and "best").
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Is there any way to do this without the literal sleeps? Gitlab CI in
particular appears to be very contended (I guess it runs in parallel
on huge systems with vast numbers of unrelated containers). I've seen
threads being created that are so starved they never run at all even
in tests running
rr);
> return NULL;
>}
>
> @@ -187,9 +197,11 @@ nbd_internal_py_aio_buffer_from_bytearray (PyObject
> *self, PyObject *args)
>if (buf->data == NULL) {
> PyErr_NoMemory ();
> free (buf);
> +Py_XDECREF (arr);
> return NULL;
>
On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote:
> On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote:
> >
> > + Drew & Peter
> >
> > On 05/25/22 15:30, Daniel P. Berrangé wrote:
> > - The patch seems to do what it says in the commit message.
> >
> > - QEMU commit bab52d4bba3f
We previously didn't bother to check the return values from any librpm
calls. In some cases where possibly the RPM database is faulty, this
caused us to return a zero-length list of installed applications (but
no error indication).
One way to reproduce this is given below. Note this reproducer
In libguestfs we didn't bother to check the return values from any
librpm calls. In some cases where possibly the RPM database is
faulty, this caused us to return a zero-length list of installed
applications (but no error indication). Libguestfs has subsequently
been fixed so now it returns an
I've updated the HTML man pages on the website:
https://libguestfs.org/nbdkit.1.html
Note the synopsis section of that first page is wrong, but I kind of
knew that already. That particular section is generated by the
podwrapper --verbatim option, unlike all the others.
Rich.
--
Richard
I have tested both patches this time with the three affected tools
(virt-builder, virt-customize & virt-sysprep) and the --selinux-relabel
option is now present and ignored.
For the series:
Reviewed-by: Richard W.M. Jones
Thanks for fixing this, I'll get it into C9S soon.
Rich.
--
Ric
Thanks - the series was pushed in:
b2612d2c..43b341b0 master -> master
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs,
On Tue, May 24, 2022 at 09:01:28AM -0500, Eric Blake wrote:
> On Sat, May 21, 2022 at 01:21:11PM +0100, Nikolaus Rath wrote:
> > Hi,
> >
> > How does the blocksize filter take into account writes that end-up
> > overlapping due to read-modify-write cycles?
> >
> > Specifically, suppose there
POD verbatim paragraphs are introduced by a line starting with
whitespace and continue to the next line containing only whitespace
(or empty). In the output they appear as preformatted text (like
in HTML). We use them extensively, but also as it turns out,
wrongly.
I previously assumed that
Now that trailing whitespace should no longer appear in POD files,
enhance podwrapper to detect this and error out.
I had to modify podwrapper so it doesn't introduce trailing whitespace
when it encounters a blank line in a --verbatim include.
Acked-by: Laszlo Ersek
Acked-by: Eric Blake
---
Fixes: commit 7d96ec5136c778e54fa27c70b2ca4b4f1456a706
---
docs/nbdkit-release-notes-1.16.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/nbdkit-release-notes-1.16.pod
b/docs/nbdkit-release-notes-1.16.pod
index 7e8d76fa..5334e33b 100644
---
Logically group the C code examples together into a single verbatim
section. Note that a following commit will correct this one.
Fixes: commit 4ca66f70a5865efbad67d719ba84950ddafefc01
Fixes: commit d4c58f93d0589c522d5a3422e61ba7fde1c64255
Thanks: Laszlo Ersek
---
docs/nbdkit-filter.pod | 4 ++--
v1 was here:
https://listman.redhat.com/archives/libguestfs/2022-May/thread.html#28934
v2:
- Patches 1-3 are new. They fix verbatim grouping and whitespace in
existing documentation.
- Patch 4 (was patch 1): I fixed the Perl script since it didn't work
if you had multiple adjacent
Fixes: commit 666ec24437932b27b393f7670ec0ecc5f11550bc
Thanks: Laszlo Ersek
---
plugins/rust/nbdkit-rust-plugin.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/rust/nbdkit-rust-plugin.pod
b/plugins/rust/nbdkit-rust-plugin.pod
index 9e3ef10e..ff9d9c09 100644
---
On Tue, May 24, 2022 at 03:59:24PM +0200, Laszlo Ersek wrote:
> On 05/24/22 12:04, Richard W.M. Jones wrote:
> > So I didn't realise that these commits break --selinux-relabel, eg:
> >
> > $ rpm -q guestfs-tools
> > guestfs-tools-1.49.1-1.fc37.x86_64
> > $ virt-bu
FYI I found a few other mistakes, and a mistake in the perl script,
so v2 definitely incoming ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual
On Tue, May 24, 2022 at 03:20:19PM +0200, Laszlo Ersek wrote:
> > @@ -118,7 +118,7 @@ that the filter wants to intercept.
> > .config= myfilter_config,
> > /* etc */
> > };
> > -
> > +
> > NBDKIT_REGISTER_FILTER(filter)
> >
> > The C<.name> field is the name of the
On Tue, May 24, 2022 at 11:04:49AM +0100, Richard W.M. Jones wrote:
> So I didn't realise that these commits break --selinux-relabel, eg:
>
> $ rpm -q guestfs-tools
> guestfs-tools-1.49.1-1.fc37.x86_64
> $ virt-builder fedora-36 --selinux-relabel
> virt-builder: unrecognized
So I didn't realise that these commits break --selinux-relabel, eg:
$ rpm -q guestfs-tools
guestfs-tools-1.49.1-1.fc37.x86_64
$ virt-builder fedora-36 --selinux-relabel
virt-builder: unrecognized option '--selinux-relabel'
Try ‘virt-builder --help’ or consult virt-builder(1) for more information.
On Mon, May 23, 2022 at 10:32:16AM +0200, Attilio Greco wrote:
> mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot
> open shared object file: No such file or directory
This error is weird. What's the output of:
rpm -q coreutils pcre2
ldd /usr/bin/mkdir
rpm -qf
On Sun, May 22, 2022 at 06:41:14PM +0100, Richard W.M. Jones wrote:
> The current code for working out the distro uses the ID entry from
> /etc/os-release, and then we map those strings into a smaller set of
> values (basically, what package manager to use). However it was
> sugge
The current code for working out the distro uses the ID entry from
/etc/os-release, and then we map those strings into a smaller set of
values (basically, what package manager to use). However it was
suggested that we should try ID_LIKE first so that distros which act
like other distros would
On Sat, May 21, 2022 at 05:37:10PM +0100, Nikolaus Rath wrote:
> On May 21 2022, "Richard W.M. Jones" wrote:
> > On Sat, May 21, 2022 at 01:21:11PM +0100, Nikolaus Rath wrote:
> >> Hi,
> >>
> >> How does the blocksize filter take into account writes t
On Sat, May 21, 2022 at 01:21:11PM +0100, Nikolaus Rath wrote:
> Hi,
>
> How does the blocksize filter take into account writes that end-up
> overlapping due to read-modify-write cycles?
>
> Specifically, suppose there are two non-overlapping writes handled
> by two different threads, that, due to
Now that trailing whitespace should no longer appear in POD files,
enhance podwrapper to detect this and error out.
I had to modify podwrapper so it doesn't introduce trailing whitespace
when it encounters a blank line in a --verbatim include.
I also fixed an instance of unwanted trailing
POD verbatim paragraphs are introduced by a line starting with
whitespace and continue to the next line containing only whitespace
(or empty). In the output they appear as preformatted text (like
in HTML). We use them extensively, but also as it turns out,
wrongly.
I previously assumed that
Fix POD verbatim paragraphs in nbdkit, per discussion last week.
If this is right, I'll roll out something similar to other projects.
Rich.
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
On Sat, May 21, 2022 at 10:55:00AM +0100, Richard W.M. Jones wrote:
> On Fri, May 20, 2022 at 12:45:20PM +0200, Attilio Greco wrote:
> > Hi all,
> > I'm hitting an error during disk resize.
> >
> > Pakage is installed via repo pakage info:
> > libguestfs.x86_64
On Fri, May 20, 2022 at 12:45:20PM +0200, Attilio Greco wrote:
> Hi all,
> I'm hitting an error during disk resize.
>
> Pakage is installed via repo pakage info:
> libguestfs.x86_64 1:1.48.1-1.fc35
> @updates
>
> Disrtro info:
>
> lsb_release -a
> LSB
On Thu, May 19, 2022 at 01:27:38PM +0200, Laszlo Ersek wrote:
> On 05/19/22 12:52, Richard W.M. Jones wrote:
> > From: Ming Xie
> >
> > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1817050
> > ---
> > docs/virt-v2v-input-vmware.pod | 6 --
> &
On Thu, May 19, 2022 at 12:29:36PM +0200, Laszlo Ersek wrote:
> On 05/19/22 10:52, Richard W.M. Jones wrote:
> > From: Ming Xie
> >
> > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1817050
> > ---
> > docs/virt-v2v-input-vmware.pod | 1 +
> > 1 fil
From: Ming Xie
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1817050
---
docs/virt-v2v-input-vmware.pod | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/virt-v2v-input-vmware.pod b/docs/virt-v2v-input-vmware.pod
index ab2d28e41f..bccf0f7490 100644
---
On Thu, May 19, 2022 at 12:25:53PM +0200, Laszlo Ersek wrote:
> On 05/18/22 15:30, Richard W.M. Jones wrote:
> > But the keyboard doesn't work. This is also surprising because I
> > *thought* that both virt and baremetal basically use emulated or real
> > USB keyboard t
On Thu, May 19, 2022 at 11:57:21AM +0200, Laszlo Ersek wrote:
> On 05/18/22 12:04, Richard W.M. Jones wrote:
> > On Wed, May 18, 2022 at 08:49:29AM +0200, Laszlo Ersek wrote:
> >> Remove any space characters that directly precede a newline character.
> >>
> >> B
From: Ming Xie
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1817050
---
docs/virt-v2v-input-vmware.pod | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/virt-v2v-input-vmware.pod b/docs/virt-v2v-input-vmware.pod
index ab2d28e41f..60cff93994 100644
---
Thanks - I pushed both patches.
Now to see if I can remember how to update the website ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to
On Wed, May 18, 2022 at 01:56:36PM +0100, Richard W.M. Jones wrote:
>
> On Wed, May 18, 2022 at 01:20:27PM +0200, Guilherme De Oliveira Santos wrote:
> > Greetings masters,
> >
> > I got pointed to you guys as experts on smtg I'm struggling with.
> > I'm trying
On Wed, May 18, 2022 at 01:20:27PM +0200, Guilherme De Oliveira Santos wrote:
> Greetings masters,
>
> I got pointed to you guys as experts on smtg I'm struggling with.
> I'm trying to move an ovirt vm raw image to a bm machine and though
[bm = baremetal]
> I could do it successfully using dd
acters|https://en.wikipedia.org/wiki/Percent-encoding#Reserved_characters>
> +that you find in the individual pathname components. For example, space
> +characters must be specified as C<%20>:
> +
> + /vmfs/volumes/datastore1/my%20guest/my%20guest.vmx
> +
> +R
On Wed, May 18, 2022 at 08:49:29AM +0200, Laszlo Ersek wrote:
> Remove any space characters that directly precede a newline character.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1938954
> Signed-off-by: Laszlo Ersek
> ---
>
> Notes:
> I've verified in the rendered HTMLs that
//bugzilla.redhat.com/2033247>.
> +
> =head3 FTP, HTTP AND TFTP
Seems fine. I had to look at perlpod(1) to check that the piped L<>
references were correct, but they seem to be!
Acked-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redha
Thanks - upstream in:
https://github.com/libguestfs/virt-v2v/commit/4ad661b545f476f8dfa00f3cdc28be01f6cc0510
https://github.com/libguestfs/virt-v2v/commit/e06cf5b5dcbfd3f0a798eaf75c8778502c9e3bc6
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my
On Tue, May 17, 2022 at 01:10:32PM +0200, Laszlo Ersek wrote:
> On 05/17/22 12:59, Richard W.M. Jones wrote:
> > These devices can be left around by grub2 when it runs the osprober
> > tool after we run “/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg”.
> > They are read-onl
On Tue, May 17, 2022 at 11:59:26AM +0100, Richard W.M. Jones wrote:
> Still testing this one as well ...
The version (with rm) fixes the bug for me.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: h
On Tue, May 17, 2022 at 11:20:32AM +0100, Richard W.M. Jones wrote:
> Still running virt-v2v to test this one ...
Whether or not we still want to go with this, I have now tested this
version and it works for me.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.
On Tue, May 17, 2022 at 01:10:32PM +0200, Laszlo Ersek wrote:
> On 05/17/22 12:59, Richard W.M. Jones wrote:
> > These devices can be left around by grub2 when it runs the osprober
> > tool after we run “/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg”.
> > They are read-onl
On Tue, May 17, 2022 at 12:50:53PM +0200, Laszlo Ersek wrote:
> On 05/17/22 12:11, Richard W.M. Jones wrote:
> >
> > OK I see what's going on.
> >
> > test-S3.sh uses the mocked boto3 in tests/test-S3/ to do an end-to-end
> > test (nbdcopy).
> >
> &g
These devices can be left around by grub2 when it runs the osprober
tool after we run “/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg”.
They are read-only mirrors of existing filesystems. These confuse
later steps in conversion, specifically fstrim.
Reported-by: Ming Xie
Fixes:
Still testing this one as well ...
Rich.
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
1101 - 1200 of 10948 matches
Mail list logo
