Re: [Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

2013-12-16 Thread Richard W.M. Jones
On Mon, Dec 16, 2013 at 01:42:51PM +0100, Pino Toscano wrote: > On Saturday 14 December 2013 22:50:28 Richard W.M. Jones wrote: > > Earlier in the test, you'll probably need to add this: > > > > if [ ! -s ../guests/fedora.img -o ! -s ../guests/debian.img ]; then > &

Re: [Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

2013-12-16 Thread Richard W.M. Jones
On Mon, Dec 16, 2013 at 01:43:54PM +0100, Pino Toscano wrote: > The current add_cdrom way basically appends a new raw "-cdrom /path" > parameter to the qemu invocation (even when using libvirt as backend), > hence such images are seen as "CD-ROM drives" inside the appliance. > However, there is no

Re: [Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

2013-12-18 Thread Richard W.M. Jones
On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh > new file mode 100755 > index 000..6fa6f2b > --- /dev/null > +++ b/tests/regressions/rhbz563450.sh > @@ -0,0 +1,54 @@ > +#!/bin/bash - > +# libguestfs

[Libguestfs] [PATCH] launch: libvirt: Don't default to using NULL for libvirt connection URI (RHBZ#1045033).

2013-12-19 Thread Richard W.M. Jones
From: "Richard W.M. Jones" NULL means that libvirt gets to guess what connection URI we meant. Currently it guesses qemu:///session for non-root and qemu:///system for root. Except if LIBVIRT_DEFAULT_URI is set in which case this is used even if it's not appropriate. Except if X

Re: [Libguestfs] [PATCH] Re-add regression tests for rh#563450

2013-12-19 Thread Richard W.M. Jones
On Thu, Dec 19, 2013 at 04:30:57PM +0100, Pino Toscano wrote: > Added in 2392fae6803b9de4a4761509007c160339d57f50 and removed in > be025369ad622867ecf08d5c9170e8e59d2d6294; now they should work with any > backend, as the device names are normalised and not change the guestfish > output depending on

Re: [Libguestfs] [PATCH] inspect: fix detection of newer CirrOS versions (RHBZ#1045450).

2013-12-20 Thread Richard W.M. Jones
On Fri, Dec 20, 2013 at 03:09:05PM +0100, Pino Toscano wrote: > Add an own case for CirrOS, based on the /etc/cirros/version file > provided in newer version instead of the Buildroot-generated > /etc/br-version. > --- > src/inspect-fs-unix.c | 12 > 1 file changed, 12 insertions(+) >

Re: [Libguestfs] [PATCH] tests/mountable: skip if btrfs is not available

2013-12-23 Thread Richard W.M. Jones
On Mon, Dec 23, 2013 at 04:45:43PM +0100, Pino Toscano wrote: > This test uses btrfs, so skip it if the "btrfs" feature is not > available. > --- > tests/mountable/test-internal-parse-mountable.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/mountable/test-internal-parse-m

Re: [Libguestfs] [PATCH] tests/mountable: skip if btrfs is not available

2013-12-23 Thread Richard W.M. Jones
On Mon, Dec 23, 2013 at 05:06:14PM +0100, Pino Toscano wrote: > This test uses btrfs, so skip it if either the "btrfs" feature or the > btrfs filesystem is not available. > --- > tests/mountable/test-internal-parse-mountable.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git

[Libguestfs] [PATCH] ruby: Fix .new method (RHBZ#1046509).

2013-12-27 Thread Richard W.M. Jones
The .new method was unintentionally broken in commit 9466060201600db47016133d80af22eb38091a49. This fixes the .new method and allows it to be called with multiple parameters, so you can use: Guestfs::Guestfs.new Guestfs::Guestfs.new() Guestfs::Guestfs.new(:close_on_exit => false) etc. Fo

[Libguestfs] [PATCH 1/2] lib: write: Remove unused variable.

2013-12-31 Thread Richard W.M. Jones
--- lib/write.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/write.c b/lib/write.c index 8c4dd8e..384c6b2 100644 --- a/lib/write.c +++ b/lib/write.c @@ -954,7 +954,6 @@ hivex_node_set_values (hive_h *h, hive_node_h node, for (i = 0; i < nr_values; ++i) { /* Allocate vk record to

[Libguestfs] [PATCH 2/2] lib: utf16: Fix const-correctness issues in _hivex_recode function.

2013-12-31 Thread Richard W.M. Jones
This patch assumes that iconv doesn't actually modify the input buffer, even though it is declared as char *. --- lib/hivex-internal.h | 6 +++--- lib/utf16.c | 9 + 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/hivex-internal.h b/lib/hivex-internal.h index 7a

[Libguestfs] [PATCH] Allow ./configure --without-qemu.

2014-01-01 Thread Richard W.M. Jones
From: "Richard W.M. Jones" This means there will be no default hypervisor, and effectively the user will always have to specify one (eg. by setting LIBGUESTFS_HV or calling guestfs_set_hv). This is useful on platforms where qemu doesn't work, or where qemu is not needed (eg. if

Re: [Libguestfs] libguestfs build fails with: /usr/lib64/golang/pkg/linux_amd64/libguestfs.org/guestfs.a -- no such file

2014-01-01 Thread Richard W.M. Jones
On Tue, Dec 31, 2013 at 04:29:37PM +0100, Kashyap Chamarthy wrote: > I'm on libguestfs Fedora git master branch: [...] > go install libguestfs.org/guestfs: open > /usr/lib64/golang/pkg/linux_amd64/libguestfs.org/guestfs.a: permission denied I believe this happens if you have golang-guestfs install

[Libguestfs] IRC question: does anyone know if libguestfs supports any sort of COW (copy on write) functionality?

2014-01-02 Thread Richard W.M. Jones
21:51 < foxx> hello! does anyone know if libguestfs supports any sort of COW (copy on write) functionality? for example, if i mount an image which is RO, can i make it write any changes out to a higher dir (such as how overlayfs/aufs works)

[Libguestfs] [PATCH] libvirt-auth: Provide a friendlier wrapper around virConnectAuthPtrDefault (RHBZ#1044014).

2014-01-02 Thread Richard W.M. Jones
--- src/guestfs-internal.h | 1 + src/libvirt-auth.c | 55 +- 2 files changed, 46 insertions(+), 10 deletions(-) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index 5356920..d81fa6b 100644 --- a/src/guestfs-internal.h +++ b/src/g

[Libguestfs] IRC question: virt-builder & size of qcow2 output files

2014-01-04 Thread Richard W.M. Jones
This question was asked on IRC: $ virt-builder centos-6 --output box.img --format qcow2 --size 40G # ... $ qemu-img convert -O qcow2 box.img box-qcow2.img $ ls -lAhs 1.6G -rw-r--r--. 1 james 41G Jan 2 21:53 box.img 1.1G -rw-r--r--. 1 james 1.1G Jan 3 18:54 box-qcow2.img $ file box*

Re: [Libguestfs] Build libguestfs error with undefined reference to `tgetnum'

2014-01-05 Thread Richard W.M. Jones
On Sun, Jan 05, 2014 at 02:11:21PM +0700, Nguyễn Trường Sơn wrote: > Hi > > I want to build libguestfs on my laptop. > I run Centos 6.4, libguestfs libguestfs-1.24.3. > > I get this error: > > Wide character in print at /root/libguestfs-1.24.3/podwrapper.pl line 418. > podwrapper.pl: wrote guest

Re: [Libguestfs] Build libguestfs error with undefined reference to `tgetnum'

2014-01-05 Thread Richard W.M. Jones
On Sun, Jan 05, 2014 at 10:27:43PM +0700, Nguyễn Trường Sơn wrote: > hi mr Jones > > Thank for your quick reply. > I only run ./configure. > > I've just deleted config.cache as you say, but nothing changed. > > Even i get new library : libguestfs-1.24.4, still get error. Did you try doing: s

Re: [Libguestfs] [PATCH 2/2] lib: utf16: Fix const-correctness issues in _hivex_recode function.

2014-01-06 Thread Richard W.M. Jones
On Mon, Jan 06, 2014 at 11:31:18AM +0100, Pino Toscano wrote: > On Tuesday 31 December 2013 14:27:11 Richard W.M. Jones wrote: > > This patch assumes that iconv doesn't actually modify the > > input buffer, even though it is declared as char *. > > --- >

Re: [Libguestfs] Issue with virt-sysprep

2014-01-07 Thread Richard W.M. Jones
On Tue, Jan 07, 2014 at 10:06:16AM +, Graeme Lambert wrote: > Hi, > > I'm trying to run virt-sysprep against a disk in Ceph RBD storage > but I appear to be unable to do so. > > The commands (bold) and outputs I've had are: > > On Ceph node: > *virt-sysprep -a rbd://localhost/libvirt-pool/ub

Re: [Libguestfs] [Bug 1046905] New: RFE: add argument to virt-sysprep to disable individual default operations

2014-01-07 Thread Richard W.M. Jones
On Tue, Jan 07, 2014 at 11:16:08AM +0100, Pino Toscano wrote: > On Friday 27 December 2013 10:58:15 you wrote: > > virt-sysprep either runs with all default operations or a selected > > list of operations with the --enable argument. A few times I've > > found I'd like to use the default list, but

Re: [Libguestfs] RFC: copy-attributes command

2014-01-07 Thread Richard W.M. Jones
On Tue, Jan 07, 2014 at 04:06:43PM +0100, Pino Toscano wrote: > Hi, > > attached there is a prototype of patch for adding a new copy-attributes > command. Such command would allow copy the attributes of a "file" to > another, so for example in guestfish: > copy-attributes foo bar permissions:t

Re: [Libguestfs] RFC: copy-attributes command

2014-01-07 Thread Richard W.M. Jones
On Tue, Jan 07, 2014 at 09:04:36PM +, Richard W.M. Jones wrote: > - Should it default to copying attributes? > > The common use case (for virt-edit) is: "I want this other file which > is identical to this original file, except in name and content". That > is

Re: [Libguestfs] hivex: Make node names and value names with embedded null characters accessible

2014-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2014 at 01:26:23AM +0100, Hilko Bengen wrote: > On Windows, there exist at least two APIs for dealing with the > Registry: The Win32 API (RegCreateKeyA, RegCreateKeyW, etc.) works > with null-terminated ASCII or UTF-16 strings. The native API > (ZwCreateKey, etc.), on the other hand

Re: [Libguestfs] [Bug 1046905] New: RFE: add argument to virt-sysprep to disable individual default operations

2014-01-09 Thread Richard W.M. Jones
On Thu, Jan 09, 2014 at 04:21:10PM +0100, Pino Toscano wrote: > + and set_operations op_string = > +let currentopset = > + match (!operations) with No need for parentheses around !operations. > +let n = ref op_name in > +let remove = string_prefix op_name "-" in > +

Re: [Libguestfs] RFC: copy-attributes command

2014-01-09 Thread Richard W.M. Jones
On Thu, Jan 09, 2014 at 05:41:30PM +0100, Pino Toscano wrote: > At least in the gnu/stubs-$bits.h of RHEL 5 they are not declared as > __stub_*, so they should be implemented (and being Linux, it means that > most probably there are the right syscalls for them). > So I would not think the change

Re: [Libguestfs] Virt-builder?

2014-01-09 Thread Richard W.M. Jones
On Thu, Jan 09, 2014 at 12:05:35PM -0800, Scott Baker wrote: > I just upgraded to Fedora 20 and I see it includes > libguestfs-1.24.3-1.fc20.x86_64. After I install that I do NOT see > virt-builder though :( > > I thought 1.24 included virt-builder? You probably want: yum install libguestfs-to

Re: [Libguestfs] [PATCH] Add a minimal hive with "special" keys and values

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 01:14:51AM +0100, Hilko Bengen wrote: > + was created using the 'mkzero/mkzero.c'. (\0 = zero character) Extra whitespace at the end of this ^ line ... > + InitializeObjectAttributes (&key_obj, &key_name, .. and this line. --- So there's no problem with adding this

Re: [Libguestfs] [Bug 1046905] New: RFE: add argument to virt-sysprep to disable individual default operations

2014-01-10 Thread Richard W.M. Jones
On Thu, Jan 09, 2014 at 03:45:54PM +, Richard W.M. Jones wrote: > On Thu, Jan 09, 2014 at 04:21:10PM +0100, Pino Toscano wrote: > > + and set_operations op_string = > > +let currentopset = > > + match (!operations) with > > No need for par

Re: [Libguestfs] RFC: copy-attributes command

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 02:17:48PM +0100, Pino Toscano wrote: > > This code looks as if it will copy the xattrs, but it won't > > remove any which don't exist in the source. eg: > > > > source xattrs before: > > user.foo = 1 > > dest xattrs before: > > user.bar = 2 > > dest xattrs a

Re: [Libguestfs] RFC: copy-attributes command

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 01:33:38PM +, Richard W.M. Jones wrote: > The API is now pretty confusing. Each OBool flag is really a > tristate. It can either be "true", "false" or "not specified". > > Therefore I think it should be: > > xatt

Re: [Libguestfs] [PATCH] daemon: xattr: move the listxattrs code in an own function

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 03:15:04PM +0100, Pino Toscano wrote: > Move in an own function the code that does the (l)listxattrs allocating > the buffer of the right legth, as it will be useful later. > > No functional changes, just code motion. > --- > daemon/xattr.c | 64 >

Re: [Libguestfs] RFC: copy-attributes command

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > +int > +copy_xattrs (const char *src, const char *dest) > +{ > + abort (); > +} Is this called in the case where someone does copy-attributes foo bar xattributes:true on a version of libguestfs with no support for xattrs? It's p

Re: [Libguestfs] RFC: copy-attributes command

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: [..] This still isn't quite what I meant. My meaning was that mode would be disabled by default (unless all:true). How about: int copy_mode, copy_xattributes, copy_ownership; /* Set defaults. */ if (all) copy_mode = copy_xattribut

[Libguestfs] [PATCH 0/3] Timezone and keyboard layout settings in virt-builder and virt-sysprep.

2014-01-10 Thread Richard W.M. Jones
Setting timezone is easy. It turns out to be almost impossible to set keyboard layout in virt-builder sanely, so I have added some examples instead. Coming up next, setting languages in virt-builder (clue: very very very hard). Rich. ___ Libguestfs ma

[Libguestfs] [PATCH 2/3] builder: docs: Remove confusing reference to timezone.

2014-01-10 Thread Richard W.M. Jones
--- builder/virt-builder.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/virt-builder.pod b/builder/virt-builder.pod index a703346..6db3dd9 100644 --- a/builder/virt-builder.pod +++ b/builder/virt-builder.pod @@ -1233,8 +1233,8 @@ least one character of whitespace (

[Libguestfs] [PATCH 1/3] sysprep, builder: Add --timezone option to set timezone of guest.

2014-01-10 Thread Richard W.M. Jones
You can use it like this: virt-sysprep --timezone Europe/London ... virt-builder --timezone Europe/London ... --- builder/Makefile.am | 1 + builder/builder.ml| 12 ++- builder/cmdline.ml| 9 - builder/test-virt-builder.sh

[Libguestfs] [PATCH 3/3] builder: Document how to change keyboard layout.

2014-01-10 Thread Richard W.M. Jones
This is too complex to implement directly in virt-builder. Instead we just document how to do it for some common Linux distros using --run-command, --edit etc. --- builder/virt-builder.pod | 40 1 file changed, 40 insertions(+) diff --git a/builder/virt-b

Re: [Libguestfs] RFC: copy-attributes command

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 06:08:15PM +0100, Pino Toscano wrote: > On Friday 10 January 2014 16:55:38 Richard W.M. Jones wrote: > > On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > > > +int > > > +copy_xattrs (const char *src, const char *de

Re: [Libguestfs] RFC: copy-attributes command

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 12:54:36PM +0100, Pino Toscano wrote: > On Friday 10 January 2014 16:53:32 Richard W.M. Jones wrote: > > On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > > [..] > > > > This still isn't quite what I meant. My meaning was th

Re: [Libguestfs] [PATCH 3/7] perl: Add test for "special" keys and values

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:48AM +0100, Hilko Bengen wrote: > --- > perl/t/130-special.t | 34 ++ > 1 file changed, 34 insertions(+) > create mode 100644 perl/t/130-special.t > > diff --git a/perl/t/130-special.t b/perl/t/130-special.t > new file mode 100644 > i

Re: [Libguestfs] [PATCH 1/7] Add a minimal hive with "special" keys and values

2014-01-13 Thread Richard W.M. Jones
EADME > +++ b/images/README > @@ -11,3 +11,17 @@ hand-crafted binary blob. > tests. > > - Richard W.M. Jones 2010-02-24. > + > +'special' was created by importing 'minimal' into a VM running Windows > +XP, loading it into HKEY_LOCAL_MACHINE\minimal using

Re: [Libguestfs] [PATCH 2/7] lib: Use vk->len for string conversion

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:47AM +0100, Hilko Bengen wrote: > --- > lib/value.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/lib/value.c b/lib/value.c > index 65404d7..e700c84 100644 > --- a/lib/value.c > +++ b/lib/value.c > @@ -207,14 +207,8 @@ hivex_value_ke

Re: [Libguestfs] [PATCH 2/7] lib: Use vk->len for string conversion

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 01:17:52PM +, Richard W.M. Jones wrote: > Is there a reason for this patch? It seems like just an optimization. OK, I see that the reason is to avoid calling _hivex_utf8_strlen which would fail for the name containing a \0 character. However I still think we need

Re: [Libguestfs] [PATCH 4/7] python: Add test for "special" keys and values

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:49AM +0100, Hilko Bengen wrote: > --- > python/t/130-special.py | 28 > 1 file changed, 28 insertions(+) > create mode 100755 python/t/130-special.py > > diff --git a/python/t/130-special.py b/python/t/130-special.py > new file mode 1007

Re: [Libguestfs] [PATCH 5/7] perl: Properly decode node names, value keys from UTF-8

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:50AM +0100, Hilko Bengen wrote: > --- > generator/generator.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/generator/generator.ml b/generator/generator.ml > index 6b1eef7..4119b04 100755 > --- a/generator/generator.ml > +++ b/generator/ge

Re: [Libguestfs] [PATCH 6/7] python: Python 3 no longer recognizes long integers

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:51AM +0100, Hilko Bengen wrote: > --- > python/t/120-rlenvalue.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/python/t/120-rlenvalue.py b/python/t/120-rlenvalue.py > index ebc48f5..a9b2129 100644 > --- a/python/t/120-rlenvalue.py > ++

Re: [Libguestfs] [PATCH 7/7] python: fix test runner so scripts are found when building out-of-tree

2014-01-13 Thread Richard W.M. Jones
On Sat, Jan 11, 2014 at 12:12:52AM +0100, Hilko Bengen wrote: > --- > python/run-python-tests.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/python/run-python-tests.in b/python/run-python-tests.in > index 90aee03..0df646b 100755 > --- a/python/run-python-tests.in > ++

Re: [Libguestfs] [PATCH 3/3] ruby: Add test for "special" keys and values

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 01:07:13PM +0100, Hilko Bengen wrote: > --- > ruby/tests/tc_130_special.rb | 30 ++ > 1 file changed, 30 insertions(+) > create mode 100644 ruby/tests/tc_130_special.rb > > diff --git a/ruby/tests/tc_130_special.rb b/ruby/tests/tc_130_special.r

Re: [Libguestfs] [PATCH] sysprep: add --operations

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 02:39:24PM +0100, Pino Toscano wrote: > Add a new --operation parameter which, similarly to --enable, can be > used to enable operations, but also to remove them, and to add/remove > the default operations and all the available ones. > --- > sysprep/main.ml |

Re: [Libguestfs] [PATCH] New API: copy-attributes.

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 02:45:08PM +0100, Pino Toscano wrote: > This allows one to copy attributes (like permissions, xattrs, > ownership) from a file to another. > --- > daemon/daemon.h | 3 + > daemon/file.c | 72 ++ > daemon/xattr.c | 69 ++

Re: [Libguestfs] [PATCH 2/7 take 2] lib: Use vk->len for string conversion

2014-01-13 Thread Richard W.M. Jones
On Mon, Jan 13, 2014 at 04:53:25PM +0100, Hilko Bengen wrote: > --- > lib/value.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/lib/value.c b/lib/value.c > index 65404d7..7b2e9d3 100644 > --- a/lib/value.c > +++ b/lib/value.c > @@ -207,14 +207,14 @@ hivex

Re: [Libguestfs] Livecd-creator is disabling selinux

2014-01-13 Thread Richard W.M. Jones
[Moving this to the libguestfs mailing list] On Mon, Jan 13, 2014 at 03:05:14PM -0500, Daniel J Walsh wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/13/2014 11:49 AM, Richard W.M. Jones wrote: > > On Mon, Jan 13, 2014 at 10:20:22AM -0500, Daniel J Walsh wr

Re: [Libguestfs] [PATCH] builder, edit, fish: use copy-attributes

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 11:16:40AM +0100, Pino Toscano wrote: > Make use of the new copy-attributes command to properly copy all file > attributes from a file to the new version of it. > --- > builder/perl_edit.ml | 29 +--- > edit/edit.c | 49 ++---

Re: [Libguestfs] Libguestfs can't launch with one of the disk images in the RHEV cluster

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 08:07:43AM +, Исаев Виталий Анатольевич wrote: > [00072ms] /usr/libexec/qemu-kvm \ > -global virtio-blk-pci.scsi=off \ > -nodefconfig \ > -nodefaults \ > -nographic \ > -drive > file=/dev/mapper/1a9aa971--f81f--4ad8--932f--607034c924fc-666faa62--da7

Re: [Libguestfs] [PATCH] builder: test-virt-builder: check some results

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 02:44:03PM +0100, Pino Toscano wrote: > Check at least some basic modifications in the image created with > virt-builder. > --- > builder/test-virt-builder.sh | 47 > +++- > 1 file changed, 46 insertions(+), 1 deletion(-) > > diff -

Re: [Libguestfs] [PATCH 1/7] Add a minimal hive with "special" keys and values

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 12:10:59PM -0500, Alex Nelson wrote: > Hi Hilko, > > Thanks a lot for creating this test hive! > > I think another thing that will trip up Registry programs is value names > that include back slashes. For example, under the System hive, the key > "\MountedDevices" has chil

Re: [Libguestfs] [PATCH 1/7] Add a minimal hive with "special" keys and values

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 12:10:59PM -0500, Alex Nelson wrote: > Have these values caused enough troubles to warrant another test hive? Another thing to say is that we cannot add proprietary test hives to the main repository for license reasons. "minimal" and "special" are both on the edge of what

Re: [Libguestfs] [PATCH] hivex: Make empty strings in REG_MULTI_SZ values available.

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 04:41:34PM +0100, Hilko Bengen wrote: > --- > lib/value.c | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > > diff --git a/lib/value.c b/lib/value.c > index db6396f..c4e21ec 100644 > --- a/lib/value.c > +++ b/lib/value.c > @@ -462,7 +462

Re: [Libguestfs] Libguestfs can't launch with one of the disk images in the RHEV cluster

2014-01-14 Thread Richard W.M. Jones
On Tue, Jan 14, 2014 at 02:57:35PM +, Исаев Виталий Анатольевич wrote: > Dear Rich, thank you for a prompt reply on my question. The similar > problems have been found with all of the rest Thin Provisioned disks > in the cluster, while all the Preallocated disks were handled with > libguestfs c

Re: [Libguestfs] [PATCH] fuse: remove extra trailing \n in debug messages

2014-01-15 Thread Richard W.M. Jones
On Wed, Jan 15, 2014 at 02:03:25PM +0100, Pino Toscano wrote: > debug() adds it already. ACK. You can just commit these kinds of obvious cleanups. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to instal

Re: [Libguestfs] [PATCH 1/4] hivex: Python 2.6 does not have sysconfig.

2014-01-15 Thread Richard W.M. Jones
ACK to all 4 patches in this series. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjone

Re: [Libguestfs] Double fault panic in L2 upon v2v conversion

2014-01-16 Thread Richard W.M. Jones
On Wed, Jan 15, 2014 at 04:35:29PM +0200, Rom Freiman wrote: > Hi everybody, > > Wanted to hear your opinion and to receive a smart advice. > > I'm trying to use virt-v2v in order to convert ova image (exported from > vcenter) to run on libvirt/kvm - all this inside a VM of fedora. > The converte

Re: [Libguestfs] [PATCH] fuse: clear stat structs (RHBZ#660687).

2014-01-16 Thread Richard W.M. Jones
On Wed, Jan 15, 2014 at 07:02:03PM +0100, Pino Toscano wrote: > Not all the fields of struct stat are actually filled by us. This caused > rubbish to appear in the microseconds fields, which were then used as > base when changing atime/ctime (with e.g. touch), triggering EINVAL by > futimens/utimen

Re: [Libguestfs] Mounting Snapshots

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 11:32:04AM +0100, Thorsten Sick wrote: > Hello > > I am doing a research project (http://www.ites-project.org/) and want to > be able to mount VM images (all kinds of VMs, starting with VirtualBox). > For that libguestfs seems perfect. I am already able to mount the base >

Re: [Libguestfs] [PATCH 2/2] hivex: Make sure that pod2html finds the POD file when building out-of-tree

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 08:22:59AM +0100, Hilko Bengen wrote: > Otherwise we get "Can't open ..." warnings which don't seem to be fatal. > --- > regedit/Makefile.am | 2 +- > sh/Makefile.am | 4 ++-- > xml/Makefile.am | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --

Re: [Libguestfs] [PATCH 2/3] builder: add --list-format

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 03:04:31PM +0100, Pino Toscano wrote: > Add a --list-format which allows to choose which in format should be the > output of --list. > --- > builder/cmdline.ml | 11 ++- > builder/virt-builder.pod | 24 +--- > 2 files changed, 31 insertions

Re: [Libguestfs] [PATCH 3/3] builder: add a JSON output for --list

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 03:04:32PM +0100, Pino Toscano wrote: > + let json_optional_printf_string key value = > +match value with > +| None -> () > +| Some str -> > + printf "\"%s\": \"%s\",\n" key (json_string_escape str) in > + let json_optional_printf_int64 key value = > +

Re: [Libguestfs] LVM mounting issue

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 03:57:50PM +, Исаев Виталий Анатольевич wrote: > > add /dev/dm-40 BTW don't do this if the virtual machine using /dev/dm-40 is running. You could (and probably will) end up with irreparable disk corruption in that guest. Use 'add-ro' instead. Rich. -- Richard Jones,

Re: [Libguestfs] LVM mounting issue

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 03:57:50PM +, Исаев Виталий Анатольевич wrote: > Hello, It's me again with one more misunderstanding of libguestfs usage... > Guestfish (as well as python libguestfs module) refuse to mount logical > volume containing the root partition of the VM's filesystem. > Accordi

[Libguestfs] [PATCH 0/2] Don't use snapshot=on

2014-01-16 Thread Richard W.M. Jones
QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because has never worked, and the UML backend was r

[Libguestfs] [PATCH 1/2] fish: Fix tests that specified qcow2 format, but passed a raw format disk.

2014-01-16 Thread Richard W.M. Jones
In some tests we were specifying qcow2 as the image format when adding a disk, but actually passing a raw format image. Libguestfs previously did not detect this until guestfs_launch, but it was still a bug to pass an incorrect format to guestfs_add_drive_opts. It only worked because these tests

Re: [Libguestfs] [PATCH 0/2] Don't use snapshot=on

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 04:16:09PM +, Richard W.M. Jones wrote: > Tested by: > > make -j1 check check-valgrind check-direct check-valgrind-direct > > I have not tested the UML backend yet. This lot passes 'make check-release' (which includes UML tests) so I

Re: [Libguestfs] [PATCH] hivex: ruby: Support 'make INSTALLDIRS=vendor install' for Ruby

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 08:29:04PM +0100, Hilko Bengen wrote: > (This is the same change as 87c9ec881cb695724e01d9f6fc9df996d4c67cb6 > in libguestfs.) > --- > ruby/Makefile.am | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/ruby/Makefile.am b/ruby/Makefi

Re: [Libguestfs] [PATCH] hivex: ruby: Minor fix for building with Ruby 1.8

2014-01-16 Thread Richard W.M. Jones
@ end > begin >require 'rubygems/package_task' >gempackagetask='Gem::PackageTask' > -rescue > +rescue LoadError >require 'rake/gempackagetask' >gempackagetask='Rake::GemPackageTask' > end > -- > 1.8.5.2 ACK, same as

Re: [Libguestfs] Double fault panic in L2 upon v2v conversion

2014-01-16 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 11:25:10PM +0200, Rom Freiman wrote: > Thanks Richard for a fast reply. > > Yes, indeed, im working on a nested environment. I try to run v2v inside a > VM (L1) and to create an L2 by the conversion process. And on Intel. As I > wrote, it fails once in few times, mainly whe

[Libguestfs] [PATCH INCOMPLETE] launch: libvirt: Use C macros to simplify XML generation.

2014-01-17 Thread Richard W.M. Jones
This commit implements some hairy C macros to simplify XML generation. Given the target XML: The old code would have looked like this: XMLERROR (-1, xmlTextWriterStartElement (xo, BAD_CAST "cpu")); XMLERROR (-1, xmlTextWriterWriteAttribute (xo, BAD_CAST "mode",

Re: [Libguestfs] LVM mounting issue

2014-01-17 Thread Richard W.M. Jones
On Fri, Jan 17, 2014 at 09:45:34AM +, Исаев Виталий Анатольевич wrote: > Be sure, that “unknown device” was not written by me :) > > I use libguestfs 1.16.34: > [root@rhevh1 ~]# rpm -qa | grep guest > libguestfs-1.16.34-2.el6.x86_64 > libguestfs-winsupport-1.0-7.el6.x86_64 > python-libguestfs-

Re: [Libguestfs] hivex -- time for 1.3.9?

2014-01-17 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 09:31:05PM +0100, Hilko Bengen wrote: > * Richard W.M. Jones: > > > ACK, same as this libguestfs fix: > > It looks like I might be able to ship the Debian package for the next > version without any specific patches. Hooray! > > I believe

Re: [Libguestfs] hivex -- time for 1.3.9?

2014-01-17 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 09:31:05PM +0100, Hilko Bengen wrote: > * Richard W.M. Jones: > > > ACK, same as this libguestfs fix: > > It looks like I might be able to ship the Debian package for the next > version without any specific patches. Hooray! > > I believe

Re: [Libguestfs] Double fault panic in L2 upon v2v conversion

2014-01-17 Thread Richard W.M. Jones
On Thu, Jan 16, 2014 at 11:25:10PM +0200, Rom Freiman wrote: > Thanks Richard for a fast reply. > > Yes, indeed, im working on a nested environment. I try to run v2v inside a > VM (L1) and to create an L2 by the conversion process. And on Intel. As I > wrote, it fails once in few times, mainly whe

Re: [Libguestfs] Double fault panic in L2 upon v2v conversion

2014-01-17 Thread Richard W.M. Jones
[Please keep libguestfs mailing list in CC] On Fri, Jan 17, 2014 at 04:14:03PM +0200, Rom Freiman wrote: > How do you know that the problem is with KVM/QEMU and not with libguestfs? The guestfsd daemon is simply running the regular 'mount' command. The mount command causes the kernel to panic. T

Re: [Libguestfs] LVM mounting issue

2014-01-17 Thread Richard W.M. Jones
On Fri, Jan 17, 2014 at 02:38:43PM +, Исаев Виталий Анатольевич wrote: > 3. Now I go to the RHEV-H to look for the disk image itself: > > [root@rhevh1 /]# find / -name cc6e4400-7c98-4170-9075-5f5790dfcff3 > /dev/1a9aa971-f81f-4ad8-932f-607034c924fc/cc6e4400-7c98-4170-9075-5f5790dfcff3 >

Re: [Libguestfs] libguestfs hanging on CentOS 6.2

2014-01-19 Thread Richard W.M. Jones
On Sun, Jan 19, 2014 at 09:22:55AM -0300, Christopher Pereira wrote: > Just in case, here is also the output after exiting the > libguestfs-test-tool: > > ... > febootstrap: internal insmod ext2.ko > [0.965626] input: ImExPS/2 Generic Explorer Mouse as > /devices/platform/i8042/serio1/input/in

Re: [Libguestfs] libguestfs hanging on CentOS 6.2

2014-01-19 Thread Richard W.M. Jones
On Sun, Jan 19, 2014 at 12:58:38PM +, Richard W.M. Jones wrote: > febootstrap: cmdline: panic=1 console=ttyS0 udevtimeout=600 no_timer_check > acpi=off printk.time=1 cgroup_disable=memory root=/dev/sdb selinux=0 > guestfs_verbose=1 TERM=xterm Actually, looking more closely, I

Re: [Libguestfs] mke2fs fails due to wipefs --force

2014-01-19 Thread Richard W.M. Jones
7bebe8412a02 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Sun, 19 Jan 2014 20:28:35 + Subject: [PATCH] daemon: Use wipefs_has_force_option to decide whether to add wipefs --force option. --- daemon/zero.c | 24 +--- 1 file changed, 17 insertions(+),

Re: [Libguestfs] [PATCH] daemon: add missing GUESTFSD_EXT_CMD usage

2014-01-19 Thread Richard W.M. Jones
On Sun, Jan 19, 2014 at 08:22:49PM +0100, Olaf Hering wrote: > Signed-off-by: Olaf Hering > --- > Not even compile tested, against 1.24 branch. ACK. It seems to work here, so I have pushed it. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedo

Re: [Libguestfs] mke2fs fails due to wipefs --force

2014-01-20 Thread Richard W.M. Jones
On Mon, Jan 20, 2014 at 10:24:28AM +0100, Olaf Hering wrote: > On Sun, Jan 19, Richard W.M. Jones wrote: > > > How about the attached patch (only compile-tested)? > > This patch works for me. Thanks. I ran 'make check' and that passed, so pushed. Rich. -- Richard

Re: [Libguestfs] guestfish and luks-format

2014-01-20 Thread Richard W.M. Jones
On Mon, Jan 20, 2014 at 04:39:42PM +0100, Olaf Hering wrote: > > Is "luks-format" supposed to work with guestfish? Like guestfish < luks-format /dev/sda4 0 > EOF > > Appearently it lacks an option to give the passphrase programmatically. > Was this option skipped on purpose? The underlying API t

Re: [Libguestfs] newlines with write-append

2014-01-20 Thread Richard W.M. Jones
On Mon, Jan 20, 2014 at 08:54:17PM +0100, Olaf Hering wrote: > Silly bash scripts have stuff like below to get things done, but equally > silly guestfish scripts fail to add the required newline. Why is that? > > echo "$dev1 $mnt1 $fs $opts 1 2" >> /etc/fstab > echo "$dev2 $mnt2 $fs $opts 1 2" >>

Re: [Libguestfs] [PATCH] builder: add index-struct.h as dependency for index-parser-c.c

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 10:56:32AM +0100, Pino Toscano wrote: > Just like with index-parse.h, also index-struct.h is a dependency of > index-parser-c.c which automake cannot generate correctly. > Thus, add it manually. > --- > builder/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

[Libguestfs] [PATCH 1/2] sysprep: Update comments.

2014-01-21 Thread Richard W.M. Jones
--- sysprep/sysprep_operation.mli | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sysprep/sysprep_operation.mli b/sysprep/sysprep_operation.mli index 61dde72..eb89db4 100644 --- a/sysprep/sysprep_operation.mli +++ b/sysprep/sysprep_operation.mli @@ -16,14 +16,16 @@ * 51 Fr

[Libguestfs] [PATCH 2/2] sysprep: Replace flags list with side_effects object.

2014-01-21 Thread Richard W.M. Jones
Previously callbacks would return a list of flags, such as [] or [`Created_files]. In this commit we introduce two new objects, filesystem_side_effects and device_side_effects (the latter is not used yet). The callbacks that create files now need to call side_effects#created_file () instead o

Re: [Libguestfs] Double fault panic in L2 upon v2v conversion

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 04:38:30PM +0100, Kashyap Chamarthy wrote: > On 01/17/2014 04:06 PM, Rom Freiman wrote: > > Kashyap, just to be sure - it happens to you during the v2v > > conversion? on L2? > > I haven't done any v2v conversions in L2 (or at any other level). I'm highly doubtful this pr

[Libguestfs] virt-builder & virt-sysprep: Avoiding SELinux relabelling

2014-01-21 Thread Richard W.M. Jones
A common problem that people have with virt-builder and virt-sysprep is which guests that use SELinux, like Fedora and RHEL. In both cases we touch /.autorelabel in the guest, which means the guest has to reboot once during its first boot. Recap: SELinux file labels -- SE

Re: [Libguestfs] [PATCH] builder: proper consider subkeys in index files

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 05:18:27PM +0100, Pino Toscano wrote: > + sv = caml_copy_string (fields->subkey ? fields->subkey : ""); >Store_field (v, 1, sv); Heh, sure would be nice if this was an option type :-) I believe the following should work: (1) Change CAMLlocal4 (..) at the top

Re: [Libguestfs] [PATCH] builder: proper consider subkeys in index files

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 05:18:27PM +0100, Pino Toscano wrote: > let entries = >List.map ( > fun (n, fields) -> > + let find_elem key subkey fields = > +match List.filter ( > +fun (iterkey, itersubkey, itervalue) -> > + iter

Re: [Libguestfs] [PATCH] builder: allow more empty lines in index files

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 05:18:28PM +0100, Pino Toscano wrote: > Improve the index grammar tp allow more than one empty line between > sections, and to allow any number of empty lines at the end of the file > (after the last section). > --- > builder/index-parse.y | 12 +--- > 1 file change

Re: [Libguestfs] virt-builder & virt-sysprep: Avoiding SELinux relabelling

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 12:01:45PM -0500, R P Herrold wrote: > (5) it can do an additional step at very end of the post > install: > restorecon -R / This doesn't work on its own. I suspect this would work: load_policy && restorecon -R / except it gives an error for me: SELinux: Co

Re: [Libguestfs] [PATCH] builder: proper consider subkeys in index files

2014-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2014 at 07:06:57PM +0100, Pino Toscano wrote: > The index files already allowed the 'key[subkey]=...' syntax for keys, > but considering such string as whole key. Proper split the parsing and > the handling of the subkeys, so they can be searched a bit easier. > > This causes no ac

<    1   2   3   4   5   6   7   8   9   10   >