Re: [Libguestfs] [PATCH v3 0/3] New API - find_block

2016-09-23 Thread Pino Toscano
On Tuesday, 20 September 2016 16:19:29 CEST Matteo Cafasso wrote:
> v3:
> 
>  - fixed attribute walk callback: checking against TSK_FS_BLOCK_FLAG_RAW flag 
> would
>exclude compressed data blocks which are still important.
>Yet we want to exclude sparse blocks (TSK_FS_BLOCK_FLAG_SPARSE) as they 
> are not stored
>on the disk.
> 
> Matteo Cafasso (3):
>   New API: internal_find_block
>   New API: find_block
>   find_block: added API tests

Patches #2, and #3 LGTM.

Thanks,
-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH v3 0/3] New API - find_block

2016-09-20 Thread Matteo Cafasso
v3:

 - fixed attribute walk callback: checking against TSK_FS_BLOCK_FLAG_RAW flag 
would
   exclude compressed data blocks which are still important.
   Yet we want to exclude sparse blocks (TSK_FS_BLOCK_FLAG_SPARSE) as they are 
not stored
   on the disk.

Matteo Cafasso (3):
  New API: internal_find_block
  New API: find_block
  find_block: added API tests

 daemon/tsk.c | 91 
 generator/actions.ml | 25 
 src/MAX_PROC_NR  |  2 +-
 src/tsk.c| 17 +
 tests/tsk/Makefile.am|  1 +
 tests/tsk/test-find-block.sh | 66 
 6 files changed, 201 insertions(+), 1 deletion(-)
 create mode 100755 tests/tsk/test-find-block.sh

--
2.9.3

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs