Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-07-20 Thread Laszlo Ersek
On 07/20/22 13:51, Richard W.M. Jones wrote: > On Wed, Jul 20, 2022 at 10:14:00AM +0200, Laszlo Ersek wrote: >> On 05/27/22 10:21, Laszlo Ersek wrote: >>> On 05/25/22 15:30, Daniel P. Berrangé wrote: The current logic for selecting CPU model to use with the appliance selects 'max' for

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-07-20 Thread Richard W.M. Jones
On Wed, Jul 20, 2022 at 10:14:00AM +0200, Laszlo Ersek wrote: > On 05/27/22 10:21, Laszlo Ersek wrote: > > On 05/25/22 15:30, Daniel P. Berrangé wrote: > >> The current logic for selecting CPU model to use with the appliance > >> selects 'max' for all architectures except for ppc64le and aarch64.

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-07-20 Thread Laszlo Ersek
On 05/27/22 10:21, Laszlo Ersek wrote: > On 05/25/22 15:30, Daniel P. Berrangé wrote: >> The current logic for selecting CPU model to use with the appliance >> selects 'max' for all architectures except for ppc64le and aarch64. >> >> On aarch64, it selects 'host' if KVM is available which is

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-27 Thread Laszlo Ersek
On 05/25/22 15:30, Daniel P. Berrangé wrote: > The current logic for selecting CPU model to use with the appliance > selects 'max' for all architectures except for ppc64le and aarch64. > > On aarch64, it selects 'host' if KVM is available which is identical > to 'max'. For TCG it selects

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Richard W.M. Jones
We always wanted "-cpu best", which means basically the CPU which always works best (NB: I used the both words "works" and "best"). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Andrew Jones
On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote: > On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: ... > > Therefore it seems that starting with qemu-4.2, but strictly preceding > > qemu-7.0, "-cpu max" and "-cpu host" are not "identical" when KVM is > > enabled; "-cpu max"

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Peter Maydell
On Thu, 26 May 2022 at 09:17, Daniel P. Berrangé wrote: > We've never said that 'max' is the same for TCG and KVM, nor do > apps using it require/expect that to be the case. > > It is simply intended to expose the maximum featureset available to > any given accelerator backend. On KVM "maximum

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Laszlo Ersek
On 05/26/22 10:10, Andrew Jones wrote: > On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote: >> On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: > ... >>> Therefore it seems that starting with qemu-4.2, but strictly preceding >>> qemu-7.0, "-cpu max" and "-cpu host" are not

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Laszlo Ersek
On 05/25/22 18:13, Peter Maydell wrote: > On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: >> >> + Drew & Peter >> >> On 05/25/22 15:30, Daniel P. Berrangé wrote: >> - The patch seems to do what it says in the commit message. >> >> - QEMU commit bab52d4bba3f ("target/arm: Add "-cpu max"

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-26 Thread Daniel P . Berrangé
On Thu, May 26, 2022 at 10:10:02AM +0200, Andrew Jones wrote: > On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote: > > On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: > ... > > > Therefore it seems that starting with qemu-4.2, but strictly preceding > > > qemu-7.0, "-cpu max"

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-25 Thread Peter Maydell
On Wed, 25 May 2022 at 18:34, Richard W.M. Jones wrote: > > On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote: > > On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: > > > > > > + Drew & Peter > > > > > > On 05/25/22 15:30, Daniel P. Berrangé wrote: > > > - The patch seems to do what

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-25 Thread Richard W.M. Jones
On Wed, May 25, 2022 at 05:13:53PM +0100, Peter Maydell wrote: > On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: > > > > + Drew & Peter > > > > On 05/25/22 15:30, Daniel P. Berrangé wrote: > > - The patch seems to do what it says in the commit message. > > > > - QEMU commit bab52d4bba3f

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-25 Thread Peter Maydell
On Wed, 25 May 2022 at 16:07, Laszlo Ersek wrote: > > + Drew & Peter > > On 05/25/22 15:30, Daniel P. Berrangé wrote: > - The patch seems to do what it says in the commit message. > > - QEMU commit bab52d4bba3f ("target/arm: Add "-cpu max" support", > 2018-03-09) confirms what the commit

Re: [Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-25 Thread Laszlo Ersek
+ Drew & Peter On 05/25/22 15:30, Daniel P. Berrangé wrote: > The current logic for selecting CPU model to use with the appliance > selects 'max' for all architectures except for ppc64le and aarch64. > > On aarch64, it selects 'host' if KVM is available which is identical > to 'max'. For TCG it

[Libguestfs] [PATCH] always 'max' for the appliance CPU model on all targes except ppc

2022-05-25 Thread Daniel P . Berrangé
The current logic for selecting CPU model to use with the appliance selects 'max' for all architectures except for ppc64le and aarch64. On aarch64, it selects 'host' if KVM is available which is identical to 'max'. For TCG it selects 'cortex-a57'. The 'max' model is a superset of 'cortex-a57', so